Remove unused definitions

PEZ · PEZ · commit fced94a68d4a · 2026-06-28T21:15:11.000+02:00
diff --git a/e2e-test-ws/.joyride/src/e2e/baldr.cljc b/e2e-test-ws/.joyride/src/e2e/baldr.cljc
@@ -1,4 +1,4 @@
-(ns pez.baldr
+(ns e2e.baldr
   (:require #?(:cljs [cljs.test :as t]
                :clj [clojure.test :as t])
             [clojure.string :as string]))
@@ -35,7 +35,7 @@
                                                    (context-color ctx)))
                                             new-contexts))
       :always (conj (str (indent (+ 2 (count contexts)))
-                         (str (bullet-color bullet) " " (color message)))))))
+                         (bullet-color bullet) " " (color message))))))
 
 (defn- report! [m config]
   (let [contexts #?(:cljs (:testing-contexts (t/get-current-env))
diff --git a/e2e-test-ws/.joyride/src/e2e/test_runner.cljs b/e2e-test-ws/.joyride/src/e2e/test_runner.cljs
@@ -79,7 +79,7 @@
       (js/setTimeout #(run-when-ws-activated nss-syms (inc tries)) 10)
       (:running @db/!state))))
 
-(defn run-all-tests [src-path]
+(defn ^:export run-all-tests [src-path]
   (let [running (p/deferred)]
     (swap! db/!state assoc :running running)
     (p/let [nss-syms (find-test-nss+ src-path)
diff --git a/e2e-test-ws/.joyride/src/tests/mcp/a_activation_test.cljs b/e2e-test-ws/.joyride/src/tests/mcp/a_activation_test.cljs
@@ -1,7 +1,7 @@
 (ns tests.mcp.a-activation-test
   (:require
    ["vscode" :as vscode]
-   [cljs.test :refer [deftest is testing]]
+   [cljs.test :refer [is testing]]
    [e2e.macros :refer [deftest-async]]
    [e2e.utils :refer [wait-for+]]
    [promesa.core :as p]))
diff --git a/e2e-test-ws/.joyride/src/tests/mcp/structural_editing_test.cljs b/e2e-test-ws/.joyride/src/tests/mcp/structural_editing_test.cljs
@@ -116,7 +116,7 @@
 
 (defn- edit-with-decoy-and-verify+
   "Activate decoy editor, perform edit, verify active editor unchanged and file not visible."
-  [socket file-path tool-call-fn prev-content]
+  [_socket _file-path tool-call-fn prev-content]
   (p/let [_ (activate-decoy-editor+)
           active-before (active-editor-path)
           result (tool-call-fn)
@@ -142,7 +142,7 @@
       "Edit should not leave more than 1 consecutive blank line"))
 
 (defn- test-replace-trims-whitespace+ [socket file-path]
-  (p/let [{:keys [result content] :as ctx}
+  (p/let [ctx
           (edit-with-decoy-and-verify+
            socket file-path
            #(mcp/call-tool socket 101 "clojure_edit_files"
@@ -173,7 +173,7 @@
 
 (defn- test-insert-proper-spacing+ [socket file-path]
   (p/let [content-before (read-test-file+ nil)
-          {:keys [result content] :as ctx}
+          {:keys [_result content] :as ctx}
           (edit-with-decoy-and-verify+
            socket file-path
            #(mcp/call-tool socket 103 "clojure_edit_files"
@@ -252,15 +252,15 @@
 
 (defn- test-delete-first-form+ [socket file-path]
   (delete-and-verify-gone+ socket file-path
-    {:id 106 :line 3 :target-text "(defn multiply-numbers"
-     :form-name "(defn multiply-numbers"
-     :test-label "delete first form keeps spacing stable"}))
+                           {:id 106 :line 3 :target-text "(defn multiply-numbers"
+                            :form-name "(defn multiply-numbers"
+                            :test-label "delete first form keeps spacing stable"}))
 
 (defn- test-delete-last-form+ [socket file-path]
   (delete-and-verify-gone+ socket file-path
-    {:id 107 :line 8 :target-text "(defn divide-numbers"
-     :form-name "(defn divide-numbers"
-     :test-label "delete last form keeps spacing stable"}))
+                           {:id 107 :line 8 :target-text "(defn divide-numbers"
+                            :form-name "(defn divide-numbers"
+                            :test-label "delete last form keeps spacing stable"}))
 
 (defn- test-wrong-target-text+ [socket file-path]
   (p/let [result (mcp/call-tool socket 108 "clojure_edit_files"
@@ -340,29 +340,29 @@
 
 (defn- test-continue-on-runtime-failure+ [socket]
   (test-continue-on-failure+ socket
-    {:test-label "batch continues past runtime failure"
-     :id-create 120 :id-batch 121
-     :valid-edit {:type "replace" :filePath (continue-file-path)
-                  :line 3 :targetLineText "(defn add-numbers"
-                  :newForm "(defn add-numbers\n  \"Adds two numbers\"\n  [a b]\n  (+ a b))"}
-     :invalid-edit {:type "replace" :filePath (continue-file-path)
-                    :line 8 :targetLineText "(defn nonexistent-function"
-                    :newForm "(defn replaced [] :replaced)"}
-     :expected-content "Adds two numbers"
-     :expected-error "Target line text not found"}))
+                             {:test-label "batch continues past runtime failure"
+                              :id-create 120 :id-batch 121
+                              :valid-edit {:type "replace" :filePath (continue-file-path)
+                                           :line 3 :targetLineText "(defn add-numbers"
+                                           :newForm "(defn add-numbers\n  \"Adds two numbers\"\n  [a b]\n  (+ a b))"}
+                              :invalid-edit {:type "replace" :filePath (continue-file-path)
+                                             :line 8 :targetLineText "(defn nonexistent-function"
+                                             :newForm "(defn replaced [] :replaced)"}
+                              :expected-content "Adds two numbers"
+                              :expected-error "Target line text not found"}))
 
 (defn- test-continue-on-edit-validation-failure+ [socket]
   (test-continue-on-failure+ socket
-    {:test-label "batch continues past edit-level validation failure"
-     :id-create 122 :id-batch 123
-     :valid-edit {:type "replace" :filePath (continue-file-path)
-                  :line 3 :targetLineText "(defn add-numbers"
-                  :newForm "(defn add-numbers\n  \"Modified\"\n  [a b]\n  (+ a b))"}
-     :invalid-edit {:type "replace" :filePath (continue-file-path)
-                    :line 8 :targetLineText "; this is a comment"
-                    :newForm "(defn replaced [] :replaced)"}
-     :expected-content "\"Modified\""
-     :expected-error "comment"}))
+                             {:test-label "batch continues past edit-level validation failure"
+                              :id-create 122 :id-batch 123
+                              :valid-edit {:type "replace" :filePath (continue-file-path)
+                                           :line 3 :targetLineText "(defn add-numbers"
+                                           :newForm "(defn add-numbers\n  \"Modified\"\n  [a b]\n  (+ a b))"}
+                              :invalid-edit {:type "replace" :filePath (continue-file-path)
+                                             :line 8 :targetLineText "; this is a comment"
+                                             :newForm "(defn replaced [] :replaced)"}
+                              :expected-content "\"Modified\""
+                              :expected-error "comment"}))
 
 ;; --- Test orchestrator ---
 
diff --git a/scripts/tasks.clj b/scripts/tasks.clj
@@ -8,17 +8,14 @@
 
 (def vsix-test-workspace "./e2e-test-vsix")
 
-#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
-(defn publish! [args]
+(defn ^:export publish! [args]
   (publish/yolo! args))
 
-#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
-(defn print-release-notes! [{:keys [version]}]
+(defn ^:export print-release-notes! [{:keys [version]}]
   (let [changelog-text (publish/get-changelog-text-for-version version)]
     (println changelog-text)))
 
-#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
-(defn bump-version! [{:keys [bump-branch user-email user-name dry force]}]
+(defn ^:export bump-version! [{:keys [bump-branch user-email user-name dry force]}]
   (if force
     (do
       (println "Bumping version")
@@ -98,8 +95,7 @@
         (println (format "Status: TESTS FAILED (%d problems, exit code %d, %.1fs)" problems exit-code elapsed-s))
         (throw (ex-info "E2E tests failed" {:babashka/exit exit-code}))))))
 
-#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
-(defn run-e2e-tests-with-vsix! [{:keys [vsix calva-vsix]}]
+(defn ^:export run-e2e-tests-with-vsix! [{:keys [vsix calva-vsix]}]
   (println "Running end-to-end tests using vsix:" vsix)
   (apply util/shell false "node" "./e2e-test-ws/launch.js" (str "--vsix=" vsix)
          (when calva-vsix [(str "--calva-vsix=" calva-vsix)])))
@@ -116,8 +112,7 @@
         (fs/copy src (fs/path e2e-tmp-dir item)))))
   e2e-tmp-dir)
 
-#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
-(defn run-e2e-tests-from-working-dir! [{:keys [is-ci calva-vsix]}]
+(defn ^:export run-e2e-tests-from-working-dir! [{:keys [is-ci calva-vsix]}]
   (println "Running end-to-end tests using working directory")
   (if is-ci
     (util/shell false "node" "./e2e-test-ws/launch.js")
@@ -126,7 +121,6 @@
       (apply run-e2e-launch! (str "--test-workspace=" tmp-ws)
              (when calva-vsix [(str "--calva-vsix=" calva-vsix)])))))
 
-#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
 (defn package-pre-release! [{:keys [slug dry]}]
   (let [current-version (-> (util/sh false "node" "-p" "require('./package').version")
                             :out string/trim)
@@ -147,17 +141,15 @@
     (util/shell dry "npm" "version" "--no-git-tag-version" current-version)
     {:vsix-file vsix-file}))
 
-#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
-(defn package-and-test-prerelease! [{:keys [slug dry]}]
+(defn ^:export package-and-test-prerelease! [{:keys [slug dry]}]
   (let [opts {:slug slug :dry dry}
         vsix-result (package-pre-release! opts)
         vsix-file (:vsix-file vsix-result)]
     (println "Created VSIX:" vsix-file)
     (println "Running e2e tests on the packaged VSIX...")
     (run-e2e-tests-with-vsix! {:vsix vsix-file})))
 
-#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
-(defn launch-with-vsix! [{:keys [vsix]}]
+(defn ^:export launch-with-vsix! [{:keys [vsix]}]
   (println "Uninstalling any existing Calva Backseat Driver extension...")
   (util/shell false "code-insiders" "--uninstall-extension" "betterthantomorrow.calva-backseat-driver")
 
@@ -167,8 +159,7 @@
   (println "Launching VS Code Insiders with test workspace...")
   (util/shell false "code-insiders" vsix-test-workspace))
 
-#_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}
-(defn run-mcp-inspector! [{:keys [vsix port-file]}]
+(defn ^:export run-mcp-inspector! [{:keys [vsix port-file]}]
   (let [server-script (if vsix
                         (let [vsix-basename (fs/strip-ext (fs/file-name vsix))
                               extension-path (str (fs/home)
diff --git a/src/calva_backseat_driver/integrations/calva/editor.cljs b/src/calva_backseat_driver/integrations/calva/editor.cljs
@@ -235,8 +235,8 @@
                       :editor/original-line-number (:editor/line-number opts)))))
           (p/catch (fn [e] {:success false :error (.-message e)}))))))
 
+#_{:clojure-lsp/ignore [:clojure-lsp/unused-public-var]}
 (comment
-
   (p/let [edit-result (apply-form-edit-by-line-with-text-targeting
                        {:editor/file-path "/Users/pez/Projects/calva-mcp-server/test-projects/example/src/mini/playground.clj"
                         :editor/line-number 214
@@ -310,18 +310,6 @@
                           :error (.-message error)
                           :file-path file-path})))))))
 
-(defn structural-create-file+
-  "Create a new Clojure file with exact content using vscode/workspace.fs API"
-  [file-path content]
-  (p/let [result (create-file-core+ file-path content)]
-    (if (:success result)
-      (p/let [_ (p/delay 1000)
-              diagnostics-after-edit (get-diagnostics-for-file file-path)]
-        (assoc result
-               :message "File created successfully"
-               :diagnostics-after-edit diagnostics-after-edit))
-      result)))
-
 (defn append-code-core+
   "Append a top-level form to the end of a file. Returns {:success true :appended-at-end true} or {:success false ...}"
   [file-path code]
@@ -352,15 +340,3 @@
           (p/catch (fn [error]
                      {:success false
                       :error (.-message error)}))))))
-
-(defn append-code+
-  "Append a top-level form to the end of a file at guaranteed top level"
-  [file-path code]
-  (p/let [diagnostics-before-edit (get-diagnostics-for-file file-path)
-          result (append-code-core+ file-path code)]
-    (if (:success result)
-      (p/let [diagnostics-after-edit (poll-diagnostics+ file-path diagnostics-before-edit)]
-        (assoc result
-               :diagnostics-before-edit diagnostics-before-edit
-               :diagnostics-after-edit diagnostics-after-edit))
-      result)))
diff --git a/src/calva_backseat_driver/integrations/calva/features.cljs b/src/calva_backseat_driver/integrations/calva/features.cljs
@@ -204,22 +204,6 @@
     {:search-padding (.get config "fuzzyLineTargetingPadding")
      :context-padding (.get config "lineContextResponsePadding")}))
 
-
-
-(defn- form-edit+ [{:ex/keys [dispatch!]
-                    :calva/keys [file-path line target-line-text new-form]
-                    :keys [ranges-fn-key log-verb]}]
-  (let [{:keys [search-padding context-padding]} (get-editor-config)]
-    (dispatch! [[:app/ax.log :debug "[Editor]" log-verb "form at line" line "in" file-path]])
-    (editor/apply-form-edit-by-line-with-text-targeting
-     {:editor/file-path file-path
-      :editor/line-number line
-      :editor/target-line target-line-text
-      :editor/new-form new-form
-      :editor/ranges-fn-key ranges-fn-key
-      :editor/search-padding search-padding
-      :editor/context-padding context-padding})))
-
 (defn- apply-single-edit+
   "Apply a single edit operation. Returns {:success true ...} or {:success false ...}"
   [edit search-padding context-padding]
diff --git a/src/calva_backseat_driver/integrations/vscode/cursor_config.cljs b/src/calva_backseat_driver/integrations/vscode/cursor_config.cljs
@@ -4,7 +4,6 @@
 
 (def cursor-mcp-server-name "backseat-driver")
 (def cursor-mcp-extension-segment "extension")
-(def cursor-mcp-reload-client-command-id "mcp.reloadClient")
 
 (defn cursor-mcp-settings-display-name []
   (str cursor-mcp-extension-segment "-" cursor-mcp-server-name))
