feat(sdk-core): type BitGoBase.wallets() as BitGoApiV1Wallets#9280
Open
mmcshinsky-bitgo wants to merge 1 commit into
Open
feat(sdk-core): type BitGoBase.wallets() as BitGoApiV1Wallets#9280mmcshinsky-bitgo wants to merge 1 commit into
mmcshinsky-bitgo wants to merge 1 commit into
Conversation
mmcshinsky-bitgo
force-pushed
the
side/types-sdk-api-wallets
branch
from
July 16, 2026 16:07
5411630 to
9255ffb
Compare
mmcshinsky-bitgo
changed the title
mmcshinsky-bitgo
force-pushed
the
side/types-sdk-api-wallets
branch
3 times, most recently
from
July 16, 2026 16:44
1627f3b to
2d25b54
Compare
mmcshinsky-bitgo
marked this pull request as ready for review
July 16, 2026 19:23
Define the full deprecated v1 wallets facade and use it on BitGoBase and BitGoAPI.wallets(). BitGoApiV1BitGo is a leaf type (imports api only) to avoid a bitgoBase/v1Wallets circular dependency. Docs make clear this is v1-only; v2 is coin().wallets() / IWallets. get/getWallet/add still return Promise<any> for the CommonJS v1 Wallet instance so abstract-utxo recovery (recover/sweep, WalletV1) keeps typechecking until v1/wallet.ts is typed. WEB-000
mmcshinsky-bitgo
force-pushed
the
side/types-sdk-api-wallets
branch
from
July 16, 2026 19:26
2d25b54 to
0dcccf8
Compare
Contributor
|
@claude review this PR and concentrate if this has any implications for v2 wallets or have unintended sideeffects for v2 wallets |
Contributor
|
Claude finished @davidkaplanbitgo's task —— View job I'll analyze this and get back to you. |
davidkaplanbitgo
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BitGoBase.wallets(): anywith a full v1-only type:BitGoApiV1Wallets.BitGoAPI.wallets()(re-exported from@bitgo/sdk-core).modules/sdk-api/src/v1/wallets.ts(all 16 prototype methods).v1 vs v2 (important)
bitgo.wallets()BitGoApiV1Walletsbitgo.coin(name).wallets()IWalletsRetail / modern callers that use
sdkCoin.wallets().get(...)are on v2 and are unaffected.What this covers
list,get/getWallet,add,remove,createKey,createWalletWithKeychains,createForwardWalletlistInvites,cancelInvite,listShares,getShare,updateShare,cancelShare,acceptShare,resendShareInviteBitGoApiV1*Params)BitGoApiV1BitGo/BitGoApiV1Keychains— minimal client surface used by the v1 facade (leaf types; no import ofBitGoBase)Wallet instance returns (
get/getWallet/add)Still
Promise<any>. A stubBitGoApiV1Walletreturn with[key: string]: unknownbrokeabstract-utxorecovery (v1wallet.recover/.sweep, assignability to localWalletV1). Full typing ofsdk-api/src/v1/wallet.tsis a follow-up.Circular-deps note
BitGoApiV1Wallets.bitgoisBitGoApiV1BitGo, notBitGoBase. Import graph:bitgoBase → v1Wallets → api(acyclic).Intentionally out of scope
sdk-api/src/v1/wallet.tsanyv1 facades onBitGoAPI(keychains(),pendingApprovals(), etc.)IWallets/IWalletTest plan
yarn tsc --noEmitinmodules/sdk-core,modules/sdk-api,modules/abstract-utxoyarn mocha test/unit/bitgoAPI.ts --grep walletsNo ticket — local side improvement (
WEB-000).