Merge pull request #16 from BlackVectorOps/fix/safe-type-assertion-topology-4482181730806486940

Refactor: Use safe type assertion helper for closures in topology analysis

Author: xkilldash9x

pkg/analysis/topology/topology.go

@@ -298,9 +298,8 @@ func extractCallSignature(call *ssa.Call) string {
 	case *ssa.Builtin:
 		return fmt.Sprintf("builtin:%s", v.Name())
 	case *ssa.MakeClosure:
-		// FIX: Use Safe Type Assertion to avoid panic
-		if fn, ok := v.Fn.(*ssa.Function); ok && fn != nil {
-			return fmt.Sprintf("closure:%s", fn.Signature.String())
+		if sig := extractClosureSignature(v); sig != "" {
+			return sig
 		}
 	}
 
@@ -326,9 +325,8 @@ func extractGoSignature(g *ssa.Go) string {
 	case *ssa.Function:
 		return extractFunctionSig(v)
 	case *ssa.MakeClosure:
-		// FIX: Use Safe Type Assertion
-		if fn, ok := v.Fn.(*ssa.Function); ok && fn != nil {
-			return fmt.Sprintf("closure:%s", fn.Signature.String())
+		if sig := extractClosureSignature(v); sig != "" {
+			return sig
 		}
 	}
 	// Fallback for dynamic function pointers
@@ -349,9 +347,8 @@ func extractDeferSignature(d *ssa.Defer) string {
 	case *ssa.Function:
 		return extractFunctionSig(v)
 	case *ssa.MakeClosure:
-		// FIX: Use Safe Type Assertion
-		if fn, ok := v.Fn.(*ssa.Function); ok && fn != nil {
-			return fmt.Sprintf("closure:%s", fn.Signature.String())
+		if sig := extractClosureSignature(v); sig != "" {
+			return sig
 		}
 	}
 	if d.Call.Value != nil {
@@ -360,6 +357,13 @@ func extractDeferSignature(d *ssa.Defer) string {
 	return "unknown"
 }
 
+func extractClosureSignature(v *ssa.MakeClosure) string {
+	if fn, ok := v.Fn.(*ssa.Function); ok && fn != nil {
+		return fmt.Sprintf("closure:%s", fn.Signature.String())
+	}
+	return ""
+}
+
 func extractFunctionSig(fn *ssa.Function) string {
 	// Fix: Detect anonymous/nested functions to provide stable signatures.
 	// This handles optimizations where simple closures become plain Functions.