Fix: Use dynamic permission check for CanWrite instead of hardcoded true #4275
kbeaugrandci-tests.yml
on: push
Unit tests
2m 36s
Codecov
8s
Annotations
10 warnings
|
Unit tests:
src/IoTHub.Portal.Tests.E2E/Pages/LoginPage.cs#L13
Member 'LoginButton' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
Unit tests:
src/IoTHub.Portal.Tests.E2E/Pages/LoginPage.cs#L12
Member 'PasswordField' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
Unit tests:
src/IoTHub.Portal.Tests.E2E/Pages/LoginPage.cs#L11
Member 'UsernameField' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
Unit tests:
src/IoTHub.Portal.Tests.E2E/Pages/LoginPage.cs#L19
In externally visible method 'LoginPage.LoginPage(IConfiguration configuration)', validate parameter 'configuration' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
|
Unit tests:
src/IoTHub.Portal.Tests.E2E/Pages/LoginPage.cs#L21
Modify 'LoginPage.LoginPage(IConfiguration)' to call 'INavigation.GoToUrl(Uri)' instead of 'INavigation.GoToUrl(string)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2234)
|
|
Unit tests:
src/IoTHub.Portal.Tests.E2E/E2ETest.cs#L24
Member 'AddBorwserLogs' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
Unit tests:
src/IoTHub.Portal.Tests.E2E/Pages/DevicePage.cs#L16
In externally visible method 'DevicePage.DevicePage(IWebDriver driver, WebDriverWait wait)', validate parameter 'driver' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
|
Unit tests:
src/IoTHub.Portal.Tests.E2E/Pages/DevicePage.cs#L15
In externally visible method 'DevicePage.DevicePage(IWebDriver driver, WebDriverWait wait)', validate parameter 'wait' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
|
Unit tests:
src/IoTHub.Portal.Tests.E2E/Pages/TagsConfigurationPage.cs#L8
Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051)
|
|
Unit tests:
src/IoTHub.Portal.Crosscutting/PredicateBuilder.cs#L16
In externally visible method 'Expression<Func<T, bool>> PredicateBuilder.And<T>(Expression<Func<T, bool>> expr1, Expression<Func<T, bool>> expr2)', validate parameter 'expr1' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
test-results
Expired
|
974 KB |
sha256:c95f687cea7dd2b650fd864de4e01dc93513c0ebeee68da3b21fcea11d9484e6
|
|