style: fix Solidity style violations across src/ — function order, NatSpec coverage, relative imports

  (behaviour-preserving)

Author: rya-sge

src/mocks/IAddressListInterfaceIdHelper.sol

@@ -17,14 +17,61 @@ import {AddressListInterfaceId} from "../rules/interfaces/library/AddressListInt
  */
 interface IAddressListAllFunctions {
     /* ==== From IAddressList ==== */
+
+    /**
+     * @notice Adds several addresses to the set.
+     * @param targetAddresses The addresses to add.
+     */
     function addAddresses(address[] calldata targetAddresses) external;
+
+    /**
+     * @notice Removes several addresses from the set.
+     * @param targetAddresses The addresses to remove.
+     */
     function removeAddresses(address[] calldata targetAddresses) external;
+
+    /**
+     * @notice Adds a single address to the set.
+     * @param targetAddress The address to add.
+     */
     function addAddress(address targetAddress) external;
+
+    /**
+     * @notice Removes a single address from the set.
+     * @param targetAddress The address to remove.
+     */
     function removeAddress(address targetAddress) external;
+
+    /**
+     * @notice Returns the number of addresses currently in the set.
+     * @return count The number of listed addresses.
+     */
     function listedAddressCount() external view returns (uint256 count);
+
+    /**
+     * @notice Returns whether a single address is in the set.
+     * @param targetAddress The address to check.
+     * @return isListed True if the address is listed.
+     */
     function isAddressListed(address targetAddress) external view returns (bool isListed);
+
+    /**
+     * @notice Returns membership for several addresses in one call.
+     * @param targetAddresses The addresses to check.
+     * @return results One boolean per input address, in the same order.
+     */
     function areAddressesListed(address[] memory targetAddresses) external view returns (bool[] memory results);
+
     /* ==== From IIdentityRegistryContains ==== */
+
+    /**
+     * @notice Returns whether an address is in the set.
+     * @dev This is the selector that `type(IAddressList).interfaceId` OMITS, because it is
+     *      inherited rather than declared directly. Redeclaring it here is the whole point of
+     *      this flattened interface.
+     * @param _userAddress The address to check.
+     * @return True if the address is listed.
+     */
     function contains(address _userAddress) external view returns (bool);
 }
 
@@ -36,27 +83,31 @@ interface IAddressListAllFunctions {
 contract IAddressListInterfaceIdHelper {
     /**
      * @notice Returns `type(IAddressList).interfaceId` — INCOMPLETE, omits inherited selectors.
+     * @return The naive interface ID, which does NOT include the inherited `contains(address)`.
      */
     function getIAddressListInterfaceId() external pure returns (bytes4) {
         return type(IAddressList).interfaceId;
     }
 
     /**
      * @notice Returns the XOR of ALL selectors in the {IAddressList} hierarchy (flattened).
+     * @return The complete interface ID, including the inherited `contains(address)` selector.
      */
     function getIAddressListAllFunctionsInterfaceId() external pure returns (bytes4) {
         return type(IAddressListAllFunctions).interfaceId;
     }
 
     /**
      * @notice Returns the constant defined in the {AddressListInterfaceId} library.
+     * @return The pre-computed constant the rules actually advertise via ERC-165.
      */
     function getAddressListInterfaceIdConstant() external pure returns (bytes4) {
         return AddressListInterfaceId.IADDRESS_LIST_INTERFACE_ID;
     }
 
     /**
      * @notice Returns the interface ID of the inherited parent interface.
+     * @return The interface ID of {IIdentityRegistryContains}.
      */
     function getIIdentityRegistryContainsInterfaceId() external pure returns (bytes4) {
         return type(IIdentityRegistryContains).interfaceId;

src/mocks/IdentityRegistryMock.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MPL-2.0
 pragma solidity ^0.8.20;
 
-import {IIdentityRegistryVerified} from "src/rules/interfaces/IIdentityRegistry.sol";
+import {IIdentityRegistryVerified} from "../rules/interfaces/IIdentityRegistry.sol";
 
 /**
  * @title IdentityRegistryMock — test double for an ERC-3643 identity registry

src/mocks/MockERC20WithTransferContext.sol

@@ -2,7 +2,7 @@
 pragma solidity ^0.8.20;
 
 import {ERC20} from "@openzeppelin/contracts/token/ERC20/ERC20.sol";
-import {ITransferContext} from "src/rules/interfaces/ITransferContext.sol";
+import {ITransferContext} from "../rules/interfaces/ITransferContext.sol";
 
 /**
  * @title MockERC20WithTransferContext — ERC20 mock that notifies a transfer-context rule

src/mocks/MockERC721WithTransferContext.sol

@@ -2,7 +2,7 @@
 pragma solidity ^0.8.20;
 
 import {ERC721} from "@openzeppelin/contracts/token/ERC721/ERC721.sol";
-import {ITransferContext} from "src/rules/interfaces/ITransferContext.sol";
+import {ITransferContext} from "../rules/interfaces/ITransferContext.sol";
 
 /**
  * @title MockERC721WithTransferContext — ERC721 mock that notifies a transfer-context rule

src/mocks/SanctionListOracle.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MPL-2.0
 pragma solidity ^0.8.20;
 
-import {ISanctionsList} from "src/rules/interfaces/ISanctionsList.sol";
+import {ISanctionsList} from "../rules/interfaces/ISanctionsList.sol";
 
 /**
  * @title SanctionListOracle — test double for a Chainalysis-style sanctions oracle

src/mocks/harness/DeploymentCoverageHarnesses.sol

@@ -1,16 +1,16 @@
 // SPDX-License-Identifier: MPL-2.0
 pragma solidity ^0.8.20;
 
-import {ISanctionsList} from "src/rules/interfaces/ISanctionsList.sol";
-import {RuleBlacklist} from "src/rules/validation/deployment/RuleBlacklist.sol";
-import {RuleWhitelist} from "src/rules/validation/deployment/RuleWhitelist.sol";
-import {RuleWhitelistWrapper} from "src/rules/validation/deployment/RuleWhitelistWrapper.sol";
-import {RuleERC2980} from "src/rules/validation/deployment/RuleERC2980.sol";
-import {RuleSanctionsList} from "src/rules/validation/deployment/RuleSanctionsList.sol";
-import {RuleBlacklistOwnable2Step} from "src/rules/validation/deployment/RuleBlacklistOwnable2Step.sol";
-import {RuleWhitelistOwnable2Step} from "src/rules/validation/deployment/RuleWhitelistOwnable2Step.sol";
-import {RuleWhitelistWrapperOwnable2Step} from "src/rules/validation/deployment/RuleWhitelistWrapperOwnable2Step.sol";
-import {RuleERC2980Ownable2Step} from "src/rules/validation/deployment/RuleERC2980Ownable2Step.sol";
+import {ISanctionsList} from "../../rules/interfaces/ISanctionsList.sol";
+import {RuleBlacklist} from "../../rules/validation/deployment/RuleBlacklist.sol";
+import {RuleWhitelist} from "../../rules/validation/deployment/RuleWhitelist.sol";
+import {RuleWhitelistWrapper} from "../../rules/validation/deployment/RuleWhitelistWrapper.sol";
+import {RuleERC2980} from "../../rules/validation/deployment/RuleERC2980.sol";
+import {RuleSanctionsList} from "../../rules/validation/deployment/RuleSanctionsList.sol";
+import {RuleBlacklistOwnable2Step} from "../../rules/validation/deployment/RuleBlacklistOwnable2Step.sol";
+import {RuleWhitelistOwnable2Step} from "../../rules/validation/deployment/RuleWhitelistOwnable2Step.sol";
+import {RuleWhitelistWrapperOwnable2Step} from "../../rules/validation/deployment/RuleWhitelistWrapperOwnable2Step.sol";
+import {RuleERC2980Ownable2Step} from "../../rules/validation/deployment/RuleERC2980Ownable2Step.sol";
 
 /**
  * @title RuleBlacklistHarness — test harness exposing RuleBlacklist internals
@@ -85,6 +85,7 @@ contract RuleWhitelistWrapperHarness is RuleWhitelistWrapper {
      * @param admin Address granted the admin role
      * @param forwarderIrrevocable Trusted ERC-2771 forwarder address
      * @param checkSpender_ Whether the spender is also checked against the whitelist
+     * @param allowMintBurn Whether minting and burning are permitted (sets both flags)
      */
     constructor(address admin, address forwarderIrrevocable, bool checkSpender_, bool allowMintBurn)
         RuleWhitelistWrapper(admin, forwarderIrrevocable, checkSpender_, allowMintBurn)
@@ -238,6 +239,7 @@ contract RuleWhitelistWrapperOwnable2StepHarness is RuleWhitelistWrapperOwnable2
      * @param owner Address set as the contract owner
      * @param forwarderIrrevocable Trusted ERC-2771 forwarder address
      * @param checkSpender_ Whether the spender is also checked against the whitelist
+     * @param allowMintBurn Whether minting and burning are permitted (sets both flags)
      */
     constructor(address owner, address forwarderIrrevocable, bool checkSpender_, bool allowMintBurn)
         RuleWhitelistWrapperOwnable2Step(owner, forwarderIrrevocable, checkSpender_, allowMintBurn)

src/mocks/harness/RuleSanctionsListOwnable2StepHarness.sol

@@ -1,8 +1,8 @@
 // SPDX-License-Identifier: MPL-2.0
 pragma solidity ^0.8.20;
 
-import {ISanctionsList} from "src/rules/interfaces/ISanctionsList.sol";
-import {RuleSanctionsListOwnable2Step} from "src/rules/validation/deployment/RuleSanctionsListOwnable2Step.sol";
+import {ISanctionsList} from "../../rules/interfaces/ISanctionsList.sol";
+import {RuleSanctionsListOwnable2Step} from "../../rules/validation/deployment/RuleSanctionsListOwnable2Step.sol";
 
 /**
  * @title RuleSanctionsListOwnable2StepHarness — test harness exposing RuleSanctionsListOwnable2Step internals

src/mocks/harness/RuleSpenderWhitelistHarnesses.sol

@@ -1,8 +1,8 @@
 // SPDX-License-Identifier: MPL-2.0
 pragma solidity ^0.8.20;
 
-import {RuleSpenderWhitelist} from "src/rules/validation/deployment/RuleSpenderWhitelist.sol";
-import {RuleSpenderWhitelistOwnable2Step} from "src/rules/validation/deployment/RuleSpenderWhitelistOwnable2Step.sol";
+import {RuleSpenderWhitelist} from "../../rules/validation/deployment/RuleSpenderWhitelist.sol";
+import {RuleSpenderWhitelistOwnable2Step} from "../../rules/validation/deployment/RuleSpenderWhitelistOwnable2Step.sol";
 
 /**
  * @title RuleSpenderWhitelistHarness — test harness exposing RuleSpenderWhitelist internals

src/mocks/harness/RuleWhitelistWrapperHarnessInternal.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MPL-2.0
 pragma solidity ^0.8.20;
 
-import {RuleWhitelistWrapper} from "src/rules/validation/deployment/RuleWhitelistWrapper.sol";
+import {RuleWhitelistWrapper} from "../../rules/validation/deployment/RuleWhitelistWrapper.sol";
 
 /**
  * @title RuleWhitelistWrapperHarnessInternal — test harness exposing RuleWhitelistWrapper internal transfer hook
@@ -16,6 +16,7 @@ contract RuleWhitelistWrapperHarnessInternal is RuleWhitelistWrapper {
      * @param admin Address granted the admin role
      * @param forwarderIrrevocable Trusted ERC-2771 forwarder address
      * @param checkSpender_ Whether the spender is also checked against the whitelist
+     * @param allowMintBurn Whether minting and burning are permitted (sets both flags)
      */
     constructor(address admin, address forwarderIrrevocable, bool checkSpender_, bool allowMintBurn)
         RuleWhitelistWrapper(admin, forwarderIrrevocable, checkSpender_, allowMintBurn)

src/rules/operation/abstract/RuleConditionalTransferLightMultiTokenBase.sol

@@ -313,39 +313,6 @@ abstract contract RuleConditionalTransferLightMultiTokenBase is
             == uint8(IERC1404Extend.REJECTED_CODE_BASE.TRANSFER_OK);
     }
 
-    /**
-     * @notice Computes the restriction code for a transfer of `token`, independently of the caller.
-     * @dev Single source of truth for the read path: {detectTransferRestriction} feeds it
-     *      `_msgSender()`, while {detectTransferRestrictionForToken} feeds it an explicit token, so
-     *      the two can never disagree. Mints and burns are exempt; an unbound token has no
-     *      consumable approvals and is therefore always restricted (fail-closed).
-     * @param token The token the transfer applies to.
-     * @param from The sender of the transfer.
-     * @param to The recipient of the transfer.
-     * @param value The amount of the transfer.
-     * @return The restriction code, or TRANSFER_OK when an approval exists.
-     */
-    function _detectTransferRestrictionForToken(address token, address from, address to, uint256 value)
-        internal
-        view
-        virtual
-        returns (uint8)
-    {
-        if (from == address(0) || to == address(0)) {
-            return uint8(IERC1404Extend.REJECTED_CODE_BASE.TRANSFER_OK);
-        }
-
-        if (!isTokenBound(token)) {
-            return CODE_TRANSFER_REQUEST_NOT_APPROVED;
-        }
-
-        if (approvalCounts[_transferHash(token, from, to, value)] == 0) {
-            return CODE_TRANSFER_REQUEST_NOT_APPROVED;
-        }
-
-        return uint8(IERC1404Extend.REJECTED_CODE_BASE.TRANSFER_OK);
-    }
-
     /**
      * @notice Authorizes changes to compliance binding: restricted to the compliance manager.
      * @dev NOT `view`, unlike every other access-control hook in this codebase. This is structural,
@@ -415,6 +382,39 @@ abstract contract RuleConditionalTransferLightMultiTokenBase is
         emit TransferExecuted(token, from, to, value, approvalCounts[transferHash]);
     }
 
+    /**
+     * @notice Computes the restriction code for a transfer of `token`, independently of the caller.
+     * @dev Single source of truth for the read path: {detectTransferRestriction} feeds it
+     *      `_msgSender()`, while {detectTransferRestrictionForToken} feeds it an explicit token, so
+     *      the two can never disagree. Mints and burns are exempt; an unbound token has no
+     *      consumable approvals and is therefore always restricted (fail-closed).
+     * @param token The token the transfer applies to.
+     * @param from The sender of the transfer.
+     * @param to The recipient of the transfer.
+     * @param value The amount of the transfer.
+     * @return The restriction code, or TRANSFER_OK when an approval exists.
+     */
+    function _detectTransferRestrictionForToken(address token, address from, address to, uint256 value)
+        internal
+        view
+        virtual
+        returns (uint8)
+    {
+        if (from == address(0) || to == address(0)) {
+            return uint8(IERC1404Extend.REJECTED_CODE_BASE.TRANSFER_OK);
+        }
+
+        if (!isTokenBound(token)) {
+            return CODE_TRANSFER_REQUEST_NOT_APPROVED;
+        }
+
+        if (approvalCounts[_transferHash(token, from, to, value)] == 0) {
+            return CODE_TRANSFER_REQUEST_NOT_APPROVED;
+        }
+
+        return uint8(IERC1404Extend.REJECTED_CODE_BASE.TRANSFER_OK);
+    }
+
     /**
      * @notice Authorizes transfer execution: only a bound token may call the execution hooks.
      */