Skip to content

Commit cc2f959

Browse files
rya-sgerya-sge
committed
Run coverage, static analyser, improve code
1 parent 1a14740 commit cc2f959

64 files changed

Lines changed: 2201 additions & 1720 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎doc/coverage/coverage/home/ryan/Pictures/dev/Rules/src/modules/AccessControlModuleStandalone.sol.func-sort-c.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
</tr>
3838
<tr>
3939
<td class="headerItem">Date:</td>
40-
<td class="headerValue">2025-12-03 14:12:50</td>
40+
<td class="headerValue">2025-12-03 15:05:37</td>
4141
<td></td>
4242
<td class="headerItem">Functions:</td>
4343
<td class="headerCovTableEntry">2</td>

‎doc/coverage/coverage/home/ryan/Pictures/dev/Rules/src/modules/AccessControlModuleStandalone.sol.func.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
</tr>
3838
<tr>
3939
<td class="headerItem">Date:</td>
40-
<td class="headerValue">2025-12-03 14:12:50</td>
40+
<td class="headerValue">2025-12-03 15:05:37</td>
4141
<td></td>
4242
<td class="headerItem">Functions:</td>
4343
<td class="headerCovTableEntry">2</td>

‎doc/coverage/coverage/home/ryan/Pictures/dev/Rules/src/modules/AccessControlModuleStandalone.sol.gcov.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
</tr>
3838
<tr>
3939
<td class="headerItem">Date:</td>
40-
<td class="headerValue">2025-12-03 14:12:50</td>
40+
<td class="headerValue">2025-12-03 15:05:37</td>
4141
<td></td>
4242
<td class="headerItem">Functions:</td>
4343
<td class="headerCovTableEntry">2</td>

‎doc/coverage/coverage/home/ryan/Pictures/dev/Rules/src/modules/index-sort-b.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
</tr>
3838
<tr>
3939
<td class="headerItem">Date:</td>
40-
<td class="headerValue">2025-12-03 14:12:50</td>
40+
<td class="headerValue">2025-12-03 15:05:37</td>
4141
<td></td>
4242
<td class="headerItem">Functions:</td>
4343
<td class="headerCovTableEntry">2</td>

‎doc/coverage/coverage/home/ryan/Pictures/dev/Rules/src/modules/index-sort-f.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
</tr>
3838
<tr>
3939
<td class="headerItem">Date:</td>
40-
<td class="headerValue">2025-12-03 14:12:50</td>
40+
<td class="headerValue">2025-12-03 15:05:37</td>
4141
<td></td>
4242
<td class="headerItem">Functions:</td>
4343
<td class="headerCovTableEntry">2</td>

‎doc/coverage/coverage/home/ryan/Pictures/dev/Rules/src/modules/index-sort-l.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
</tr>
3838
<tr>
3939
<td class="headerItem">Date:</td>
40-
<td class="headerValue">2025-12-03 14:12:50</td>
40+
<td class="headerValue">2025-12-03 15:05:37</td>
4141
<td></td>
4242
<td class="headerItem">Functions:</td>
4343
<td class="headerCovTableEntry">2</td>

‎doc/coverage/coverage/home/ryan/Pictures/dev/Rules/src/modules/index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
</tr>
3838
<tr>
3939
<td class="headerItem">Date:</td>
40-
<td class="headerValue">2025-12-03 14:12:50</td>
40+
<td class="headerValue">2025-12-03 15:05:37</td>
4141
<td></td>
4242
<td class="headerItem">Functions:</td>
4343
<td class="headerCovTableEntry">2</td>

‎doc/coverage/coverage/index-sort-b.html‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -31,27 +31,27 @@
3131
<td class="headerValue">lcov.info</td>
3232
<td></td>
3333
<td class="headerItem">Lines:</td>
34-
<td class="headerCovTableEntry">206</td>
35-
<td class="headerCovTableEntry">247</td>
36-
<td class="headerCovTableEntryMed">83.4 %</td>
34+
<td class="headerCovTableEntry">230</td>
35+
<td class="headerCovTableEntry">253</td>
36+
<td class="headerCovTableEntryHi">90.9 %</td>
3737
</tr>
3838
<tr>
3939
<td class="headerItem">Date:</td>
40-
<td class="headerValue">2025-12-03 14:12:50</td>
40+
<td class="headerValue">2025-12-03 15:05:37</td>
4141
<td></td>
4242
<td class="headerItem">Functions:</td>
43-
<td class="headerCovTableEntry">56</td>
44-
<td class="headerCovTableEntry">73</td>
45-
<td class="headerCovTableEntryMed">76.7 %</td>
43+
<td class="headerCovTableEntry">66</td>
44+
<td class="headerCovTableEntry">76</td>
45+
<td class="headerCovTableEntryMed">86.8 %</td>
4646
</tr>
4747
<tr>
4848
<td></td>
4949
<td></td>
5050
<td></td>
5151
<td class="headerItem">Branches:</td>
52-
<td class="headerCovTableEntry">57</td>
52+
<td class="headerCovTableEntry">65</td>
5353
<td class="headerCovTableEntry">68</td>
54-
<td class="headerCovTableEntryMed">83.8 %</td>
54+
<td class="headerCovTableEntryHi">95.6 %</td>
5555
</tr>
5656
<tr><td><img src="glass.png" width=3 height=3 alt=""></td></tr>
5757
</table>
@@ -81,29 +81,17 @@
8181
<td class="tableHead" colspan=2>Functions <span class="tableHeadSort"><a href="index-sort-f.html"><img src="updown.png" width=10 height=14 alt="Sort by function coverage" title="Sort by function coverage" border=0></a></span></td>
8282
<td class="tableHead" colspan=2>Branches <span class="tableHeadSort"><img src="glass.png" width=10 height=14 alt="Sort by branch coverage" title="Sort by branch coverage" border=0></span></td>
8383
</tr>
84-
<tr>
85-
<td class="coverFile"><a href="validation/abstract/index.html">validation/abstract</a></td>
86-
<td class="coverBar" align="center">
87-
<table border=0 cellspacing=0 cellpadding=1><tr><td class="coverBarOutline"><img src="amber.png" width=76 height=10 alt="75.9%"><img src="snow.png" width=24 height=10 alt="75.9%"></td></tr></table>
88-
</td>
89-
<td class="coverPerMed">75.9&nbsp;%</td>
90-
<td class="coverNumMed">22 / 29</td>
91-
<td class="coverPerLo">70.0&nbsp;%</td>
92-
<td class="coverNumLo">7 / 10</td>
93-
<td class="coverPerMed">80.0&nbsp;%</td>
94-
<td class="coverNumMed">8 / 10</td>
95-
</tr>
9684
<tr>
9785
<td class="coverFile"><a href="validation/index.html">validation</a></td>
9886
<td class="coverBar" align="center">
99-
<table border=0 cellspacing=0 cellpadding=1><tr><td class="coverBarOutline"><img src="amber.png" width=82 height=10 alt="81.7%"><img src="snow.png" width=18 height=10 alt="81.7%"></td></tr></table>
87+
<table border=0 cellspacing=0 cellpadding=1><tr><td class="coverBarOutline"><img src="amber.png" width=90 height=10 alt="89.9%"><img src="snow.png" width=10 height=10 alt="89.9%"></td></tr></table>
10088
</td>
101-
<td class="coverPerMed">81.7&nbsp;%</td>
102-
<td class="coverNumMed">134 / 164</td>
103-
<td class="coverPerLo">72.7&nbsp;%</td>
104-
<td class="coverNumLo">32 / 44</td>
105-
<td class="coverPerMed">83.0&nbsp;%</td>
106-
<td class="coverNumMed">44 / 53</td>
89+
<td class="coverPerMed">89.9&nbsp;%</td>
90+
<td class="coverNumMed">151 / 168</td>
91+
<td class="coverPerMed">84.8&nbsp;%</td>
92+
<td class="coverNumMed">39 / 46</td>
93+
<td class="coverPerHi">94.3&nbsp;%</td>
94+
<td class="coverNumHi">50 / 53</td>
10795
</tr>
10896
<tr>
10997
<td class="coverFile"><a href="validation/abstract/RuleAddressSet/index.html">validation/abstract/RuleAddressSet</a></td>
@@ -129,6 +117,18 @@
129117
<td class="coverPerHi">100.0&nbsp;%</td>
130118
<td class="coverNumHi">3 / 3</td>
131119
</tr>
120+
<tr>
121+
<td class="coverFile"><a href="validation/abstract/index.html">validation/abstract</a></td>
122+
<td class="coverBar" align="center">
123+
<table border=0 cellspacing=0 cellpadding=1><tr><td class="coverBarOutline"><img src="emerald.png" width=94 height=10 alt="93.5%"><img src="snow.png" width=6 height=10 alt="93.5%"></td></tr></table>
124+
</td>
125+
<td class="coverPerHi">93.5&nbsp;%</td>
126+
<td class="coverNumHi">29 / 31</td>
127+
<td class="coverPerHi">90.9&nbsp;%</td>
128+
<td class="coverNumHi">10 / 11</td>
129+
<td class="coverPerHi">100.0&nbsp;%</td>
130+
<td class="coverNumHi">10 / 10</td>
131+
</tr>
132132
</table>
133133
</center>
134134
<br>

‎doc/coverage/coverage/index-sort-f.html‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -31,27 +31,27 @@
3131
<td class="headerValue">lcov.info</td>
3232
<td></td>
3333
<td class="headerItem">Lines:</td>
34-
<td class="headerCovTableEntry">206</td>
35-
<td class="headerCovTableEntry">247</td>
36-
<td class="headerCovTableEntryMed">83.4 %</td>
34+
<td class="headerCovTableEntry">230</td>
35+
<td class="headerCovTableEntry">253</td>
36+
<td class="headerCovTableEntryHi">90.9 %</td>
3737
</tr>
3838
<tr>
3939
<td class="headerItem">Date:</td>
40-
<td class="headerValue">2025-12-03 14:12:50</td>
40+
<td class="headerValue">2025-12-03 15:05:37</td>
4141
<td></td>
4242
<td class="headerItem">Functions:</td>
43-
<td class="headerCovTableEntry">56</td>
44-
<td class="headerCovTableEntry">73</td>
45-
<td class="headerCovTableEntryMed">76.7 %</td>
43+
<td class="headerCovTableEntry">66</td>
44+
<td class="headerCovTableEntry">76</td>
45+
<td class="headerCovTableEntryMed">86.8 %</td>
4646
</tr>
4747
<tr>
4848
<td></td>
4949
<td></td>
5050
<td></td>
5151
<td class="headerItem">Branches:</td>
52-
<td class="headerCovTableEntry">57</td>
52+
<td class="headerCovTableEntry">65</td>
5353
<td class="headerCovTableEntry">68</td>
54-
<td class="headerCovTableEntryMed">83.8 %</td>
54+
<td class="headerCovTableEntryHi">95.6 %</td>
5555
</tr>
5656
<tr><td><img src="glass.png" width=3 height=3 alt=""></td></tr>
5757
</table>
@@ -81,29 +81,17 @@
8181
<td class="tableHead" colspan=2>Functions <span class="tableHeadSort"><img src="glass.png" width=10 height=14 alt="Sort by function coverage" title="Sort by function coverage" border=0></span></td>
8282
<td class="tableHead" colspan=2>Branches <span class="tableHeadSort"><a href="index-sort-b.html"><img src="updown.png" width=10 height=14 alt="Sort by branch coverage" title="Sort by branch coverage" border=0></a></span></td>
8383
</tr>
84-
<tr>
85-
<td class="coverFile"><a href="validation/abstract/index.html">validation/abstract</a></td>
86-
<td class="coverBar" align="center">
87-
<table border=0 cellspacing=0 cellpadding=1><tr><td class="coverBarOutline"><img src="amber.png" width=76 height=10 alt="75.9%"><img src="snow.png" width=24 height=10 alt="75.9%"></td></tr></table>
88-
</td>
89-
<td class="coverPerMed">75.9&nbsp;%</td>
90-
<td class="coverNumMed">22 / 29</td>
91-
<td class="coverPerLo">70.0&nbsp;%</td>
92-
<td class="coverNumLo">7 / 10</td>
93-
<td class="coverPerMed">80.0&nbsp;%</td>
94-
<td class="coverNumMed">8 / 10</td>
95-
</tr>
9684
<tr>
9785
<td class="coverFile"><a href="validation/index.html">validation</a></td>
9886
<td class="coverBar" align="center">
99-
<table border=0 cellspacing=0 cellpadding=1><tr><td class="coverBarOutline"><img src="amber.png" width=82 height=10 alt="81.7%"><img src="snow.png" width=18 height=10 alt="81.7%"></td></tr></table>
87+
<table border=0 cellspacing=0 cellpadding=1><tr><td class="coverBarOutline"><img src="amber.png" width=90 height=10 alt="89.9%"><img src="snow.png" width=10 height=10 alt="89.9%"></td></tr></table>
10088
</td>
101-
<td class="coverPerMed">81.7&nbsp;%</td>
102-
<td class="coverNumMed">134 / 164</td>
103-
<td class="coverPerLo">72.7&nbsp;%</td>
104-
<td class="coverNumLo">32 / 44</td>
105-
<td class="coverPerMed">83.0&nbsp;%</td>
106-
<td class="coverNumMed">44 / 53</td>
89+
<td class="coverPerMed">89.9&nbsp;%</td>
90+
<td class="coverNumMed">151 / 168</td>
91+
<td class="coverPerMed">84.8&nbsp;%</td>
92+
<td class="coverNumMed">39 / 46</td>
93+
<td class="coverPerHi">94.3&nbsp;%</td>
94+
<td class="coverNumHi">50 / 53</td>
10795
</tr>
10896
<tr>
10997
<td class="coverFile"><a href="validation/abstract/RuleAddressSet/index.html">validation/abstract/RuleAddressSet</a></td>
@@ -117,6 +105,18 @@
117105
<td class="coverPerHi">100.0&nbsp;%</td>
118106
<td class="coverNumHi">2 / 2</td>
119107
</tr>
108+
<tr>
109+
<td class="coverFile"><a href="validation/abstract/index.html">validation/abstract</a></td>
110+
<td class="coverBar" align="center">
111+
<table border=0 cellspacing=0 cellpadding=1><tr><td class="coverBarOutline"><img src="emerald.png" width=94 height=10 alt="93.5%"><img src="snow.png" width=6 height=10 alt="93.5%"></td></tr></table>
112+
</td>
113+
<td class="coverPerHi">93.5&nbsp;%</td>
114+
<td class="coverNumHi">29 / 31</td>
115+
<td class="coverPerHi">90.9&nbsp;%</td>
116+
<td class="coverNumHi">10 / 11</td>
117+
<td class="coverPerHi">100.0&nbsp;%</td>
118+
<td class="coverNumHi">10 / 10</td>
119+
</tr>
120120
<tr>
121121
<td class="coverFile"><a href="home/ryan/Pictures/dev/Rules/src/modules/index.html">/home/ryan/Pictures/dev/Rules/src/modules</a></td>
122122
<td class="coverBar" align="center">

‎doc/coverage/coverage/index-sort-l.html‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -31,27 +31,27 @@
3131
<td class="headerValue">lcov.info</td>
3232
<td></td>
3333
<td class="headerItem">Lines:</td>
34-
<td class="headerCovTableEntry">206</td>
35-
<td class="headerCovTableEntry">247</td>
36-
<td class="headerCovTableEntryMed">83.4 %</td>
34+
<td class="headerCovTableEntry">230</td>
35+
<td class="headerCovTableEntry">253</td>
36+
<td class="headerCovTableEntryHi">90.9 %</td>
3737
</tr>
3838
<tr>
3939
<td class="headerItem">Date:</td>
40-
<td class="headerValue">2025-12-03 14:12:50</td>
40+
<td class="headerValue">2025-12-03 15:05:37</td>
4141
<td></td>
4242
<td class="headerItem">Functions:</td>
43-
<td class="headerCovTableEntry">56</td>
44-
<td class="headerCovTableEntry">73</td>
45-
<td class="headerCovTableEntryMed">76.7 %</td>
43+
<td class="headerCovTableEntry">66</td>
44+
<td class="headerCovTableEntry">76</td>
45+
<td class="headerCovTableEntryMed">86.8 %</td>
4646
</tr>
4747
<tr>
4848
<td></td>
4949
<td></td>
5050
<td></td>
5151
<td class="headerItem">Branches:</td>
52-
<td class="headerCovTableEntry">57</td>
52+
<td class="headerCovTableEntry">65</td>
5353
<td class="headerCovTableEntry">68</td>
54-
<td class="headerCovTableEntryMed">83.8 %</td>
54+
<td class="headerCovTableEntryHi">95.6 %</td>
5555
</tr>
5656
<tr><td><img src="glass.png" width=3 height=3 alt=""></td></tr>
5757
</table>
@@ -81,29 +81,17 @@
8181
<td class="tableHead" colspan=2>Functions <span class="tableHeadSort"><a href="index-sort-f.html"><img src="updown.png" width=10 height=14 alt="Sort by function coverage" title="Sort by function coverage" border=0></a></span></td>
8282
<td class="tableHead" colspan=2>Branches <span class="tableHeadSort"><a href="index-sort-b.html"><img src="updown.png" width=10 height=14 alt="Sort by branch coverage" title="Sort by branch coverage" border=0></a></span></td>
8383
</tr>
84-
<tr>
85-
<td class="coverFile"><a href="validation/abstract/index.html">validation/abstract</a></td>
86-
<td class="coverBar" align="center">
87-
<table border=0 cellspacing=0 cellpadding=1><tr><td class="coverBarOutline"><img src="amber.png" width=76 height=10 alt="75.9%"><img src="snow.png" width=24 height=10 alt="75.9%"></td></tr></table>
88-
</td>
89-
<td class="coverPerMed">75.9&nbsp;%</td>
90-
<td class="coverNumMed">22 / 29</td>
91-
<td class="coverPerLo">70.0&nbsp;%</td>
92-
<td class="coverNumLo">7 / 10</td>
93-
<td class="coverPerMed">80.0&nbsp;%</td>
94-
<td class="coverNumMed">8 / 10</td>
95-
</tr>
9684
<tr>
9785
<td class="coverFile"><a href="validation/index.html">validation</a></td>
9886
<td class="coverBar" align="center">
99-
<table border=0 cellspacing=0 cellpadding=1><tr><td class="coverBarOutline"><img src="amber.png" width=82 height=10 alt="81.7%"><img src="snow.png" width=18 height=10 alt="81.7%"></td></tr></table>
87+
<table border=0 cellspacing=0 cellpadding=1><tr><td class="coverBarOutline"><img src="amber.png" width=90 height=10 alt="89.9%"><img src="snow.png" width=10 height=10 alt="89.9%"></td></tr></table>
10088
</td>
101-
<td class="coverPerMed">81.7&nbsp;%</td>
102-
<td class="coverNumMed">134 / 164</td>
103-
<td class="coverPerLo">72.7&nbsp;%</td>
104-
<td class="coverNumLo">32 / 44</td>
105-
<td class="coverPerMed">83.0&nbsp;%</td>
106-
<td class="coverNumMed">44 / 53</td>
89+
<td class="coverPerMed">89.9&nbsp;%</td>
90+
<td class="coverNumMed">151 / 168</td>
91+
<td class="coverPerMed">84.8&nbsp;%</td>
92+
<td class="coverNumMed">39 / 46</td>
93+
<td class="coverPerHi">94.3&nbsp;%</td>
94+
<td class="coverNumHi">50 / 53</td>
10795
</tr>
10896
<tr>
10997
<td class="coverFile"><a href="validation/abstract/RuleAddressSet/index.html">validation/abstract/RuleAddressSet</a></td>
@@ -117,6 +105,18 @@
117105
<td class="coverPerHi">100.0&nbsp;%</td>
118106
<td class="coverNumHi">2 / 2</td>
119107
</tr>
108+
<tr>
109+
<td class="coverFile"><a href="validation/abstract/index.html">validation/abstract</a></td>
110+
<td class="coverBar" align="center">
111+
<table border=0 cellspacing=0 cellpadding=1><tr><td class="coverBarOutline"><img src="emerald.png" width=94 height=10 alt="93.5%"><img src="snow.png" width=6 height=10 alt="93.5%"></td></tr></table>
112+
</td>
113+
<td class="coverPerHi">93.5&nbsp;%</td>
114+
<td class="coverNumHi">29 / 31</td>
115+
<td class="coverPerHi">90.9&nbsp;%</td>
116+
<td class="coverNumHi">10 / 11</td>
117+
<td class="coverPerHi">100.0&nbsp;%</td>
118+
<td class="coverNumHi">10 / 10</td>
119+
</tr>
120120
<tr>
121121
<td class="coverFile"><a href="home/ryan/Pictures/dev/Rules/src/modules/index.html">/home/ryan/Pictures/dev/Rules/src/modules</a></td>
122122
<td class="coverBar" align="center">

0 commit comments

Comments
 (0)