Improve test setup and player mocking in unit tests

Author: ChanceSD

pvpmanager/src/test/java/me/chancesd/pvpmanager/PluginSetup.java

@@ -1,7 +1,6 @@
 package me.chancesd.pvpmanager;
 
 import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
 
 import java.io.File;
 import java.lang.reflect.Field;
@@ -16,12 +15,19 @@
 import org.bukkit.GameMode;
 import org.bukkit.Server;
 import org.bukkit.World;
+import org.bukkit.boss.BossBar;
+import org.bukkit.command.ConsoleCommandSender;
 import org.bukkit.command.PluginCommand;
+import org.bukkit.inventory.ItemStack;
+import org.bukkit.scheduler.BukkitScheduler;
 import org.bukkit.entity.Player;
+import org.bukkit.inventory.PlayerInventory;
+import org.bukkit.plugin.PluginManager;
 import org.bukkit.plugin.PluginDescriptionFile;
 import org.bukkit.plugin.PluginLoader;
-import org.bukkit.plugin.PluginManager;
 import org.bukkit.plugin.java.JavaPlugin;
+import org.bukkit.scoreboard.Scoreboard;
+import org.bukkit.scoreboard.ScoreboardManager;
 import org.jetbrains.annotations.NotNull;
 import org.mockito.ArgumentMatchers;
 import org.mockito.Mockito;
@@ -30,6 +36,8 @@ public class PluginSetup {
 
 	private PvPManager plugin;
 	private Server server;
+	private World world;
+	private Scoreboard scoreboard;
 	private String filePath;
 	private Player attacker;
 	private Player defender;
@@ -39,14 +47,22 @@ public final void setup() throws Exception {
 		final String decoded = filePath + "TestServer/plugins/PvPManager";
 		final File pluginDirectory = new File(decoded);
 		pluginDirectory.mkdirs();
-		server = mock(Server.class, Mockito.RETURNS_MOCKS);
+		server = mock(Server.class);
 		Mockito.when(server.getPluginManager()).thenReturn(mock(PluginManager.class));
 		Mockito.when(server.getUpdateFolderFile()).thenReturn(new File(filePath + "TestServer/plugins/update"));
 		System.setProperty("java.util.logging.SimpleFormatter.format", "[%1$tT] [%4$-7s] %5$s %n");
 		Mockito.when(server.getLogger()).thenReturn(Logger.getLogger("Minecraft"));
-		final World world = mock(World.class);
-		Mockito.when(world.getName()).thenReturn("");
-		Mockito.when(server.getWorlds()).thenReturn(Arrays.asList(world));
+		Mockito.when(server.getConsoleSender()).thenReturn(mock(ConsoleCommandSender.class));
+		Mockito.when(server.getScheduler()).thenReturn(mock(BukkitScheduler.class, Mockito.RETURNS_MOCKS));
+		Mockito.when(server.getBukkitVersion()).thenReturn("1.20.4-R0.1-SNAPSHOT");
+		this.world = mock(World.class);
+		Mockito.when(this.world.getName()).thenReturn("");
+		Mockito.when(server.getWorlds()).thenReturn(Arrays.asList(this.world));
+		final ScoreboardManager scoreboardManager = mock(ScoreboardManager.class);
+		this.scoreboard = mock(Scoreboard.class, Mockito.RETURNS_MOCKS);
+		Mockito.when(server.getScoreboardManager()).thenReturn(scoreboardManager);
+		Mockito.when(scoreboardManager.getMainScoreboard()).thenReturn(this.scoreboard);
+		Mockito.when(server.createBossBar(ArgumentMatchers.anyString(), ArgumentMatchers.any(org.bukkit.boss.BarColor.class), ArgumentMatchers.any(org.bukkit.boss.BarStyle.class))).thenReturn(mock(BossBar.class));
 		Bukkit.setServer(server);
 
 		plugin = Mockito.mock(PvPManager.class, Mockito.CALLS_REAL_METHODS);
@@ -62,31 +78,34 @@ public final void setup() throws Exception {
 		method.invoke(plugin, (Object) null, server, pdf, pluginDirectory, new File(filePath), PluginSetup.class.getClassLoader());
 		Mockito.doReturn(mock(PluginCommand.class)).when(plugin).getCommand(ArgumentMatchers.anyString());
 
-		plugin.onLoad();
+		plugin.onPluginLoad();
 		plugin.onEnable();
 		setupPlayers();
 	}
 
 	public final void setupPlayers() {
-		attacker = mock(Player.class, Mockito.RETURNS_MOCKS);
-		defender = mock(Player.class, Mockito.RETURNS_MOCKS);
-		when(attacker.hasPlayedBefore()).thenReturn(true);
-		when(defender.hasPlayedBefore()).thenReturn(true);
-		when(attacker.getName()).thenReturn("Attacker");
-		when(defender.getName()).thenReturn("Defender");
-		when(attacker.getUniqueId()).thenReturn(UUID.randomUUID());
-		when(defender.getUniqueId()).thenReturn(UUID.randomUUID());
-		when(attacker.getGameMode()).thenReturn(GameMode.SURVIVAL);
-		when(defender.getKiller()).thenReturn(attacker);
+		attacker = createPlayer("Attacker");
+		defender = createPlayer("Defender");
+		Mockito.when(defender.getKiller()).thenReturn(attacker);
 	}
 
 	@NotNull
 	public final Player createPlayer(final String name) {
-		final Player player = mock(Player.class, Mockito.RETURNS_MOCKS);
-		when(player.hasPlayedBefore()).thenReturn(true);
-		when(player.getName()).thenReturn(name);
-		when(player.getUniqueId()).thenReturn(UUID.randomUUID());
-		when(player.getGameMode()).thenReturn(GameMode.SURVIVAL);
+		final Player player = mock(Player.class);
+		Mockito.when(player.hasPlayedBefore()).thenReturn(true);
+		Mockito.when(player.getName()).thenReturn(name);
+		Mockito.when(player.getDisplayName()).thenReturn(name);
+		Mockito.when(player.getUniqueId()).thenReturn(UUID.randomUUID());
+		Mockito.when(player.getGameMode()).thenReturn(GameMode.SURVIVAL);
+		Mockito.when(player.getWorld()).thenReturn(world);
+		Mockito.when(player.getServer()).thenReturn(this.server);
+		Mockito.when(player.getScoreboard()).thenReturn(this.scoreboard);
+		Mockito.when(player.isOnline()).thenReturn(true);
+		final PlayerInventory inventory = mock(PlayerInventory.class, Mockito.RETURNS_MOCKS);
+		Mockito.when(player.getInventory()).thenReturn(inventory);
+		final Player.Spigot spigot = mock(Player.Spigot.class);
+		Mockito.when(player.spigot()).thenReturn(spigot);
+		Mockito.when(player.getItemInHand()).thenReturn(mock(ItemStack.class, Mockito.RETURNS_MOCKS));
 		return player;
 	}
 

pvpmanager/src/test/java/me/chancesd/pvpmanager/listener/EntityListenerTest.java

@@ -65,6 +65,8 @@ final void setup() {
 		defender = PT.createPlayer("Defender");
 		combatAttacker = ph.createPlayer(attacker, true);
 		combatDefender = ph.createPlayer(defender, true);
+		combatAttacker.waitForPlayerToLoad();
+		combatDefender.waitForPlayerToLoad();
 	}
 
 	private void createAttack(final boolean cancelled, final Player attackerPlayer) {

pvpmanager/src/test/java/me/chancesd/pvpmanager/listener/PlayerListenerTest.java

@@ -52,6 +52,8 @@ final void setup() {
 		defender = pt.createPlayer("Defender");
 		combatAttacker = ph.createPlayer(attacker, true);
 		combatDefender = ph.createPlayer(defender, true);
+		combatAttacker.waitForPlayerToLoad();
+		combatDefender.waitForPlayerToLoad();
 	}
 
 	private void tagPlayer(final CombatPlayer player, final CombatPlayer enemy) {