chore: review pass

Author: didinele

apps/website/src/app/dashboard/[id]/settings/_components/GrantCard.tsx

@@ -42,7 +42,11 @@ export function GrantCard({ guildId, grant }: GrantCardProps) {
 	return (
 		<div className="flex w-full flex-col gap-3 rounded-lg border border-on-secondary bg-card p-4 dark:border-on-secondary-dark dark:bg-card-dark">
 			<div className="flex items-center gap-3">
-				<UserAvatar className="h-12 w-12 rounded-full" isLoading={false} user={isUserObject ? user : undefined} />
+				{isUserObject ? (
+					<UserAvatar className="h-12 w-12 rounded-full" isLoading={false} user={user} />
+				) : (
+					<div className="h-12 w-12 shrink-0 rounded-full bg-on-tertiary dark:bg-on-tertiary-dark" />
+				)}
 				<div className="flex flex-col overflow-hidden">
 					{globalName && (
 						<p className="overflow-hidden overflow-ellipsis whitespace-nowrap text-lg font-medium text-primary dark:text-primary-dark">

services/api/src/routes/guilds/getGrants.ts

@@ -39,16 +39,27 @@ export default defineRoute({
 		`;
 
 		const api = roundRobinAPI(req.guild!);
+		const resolveCache = new Map<Snowflake, Promise<APIUser | Snowflake>>();
 		const resolveUser = async (userId: Snowflake): Promise<APIUser | Snowflake> => {
-			try {
-				return await api.users.get(userId);
-			} catch (error) {
-				if (error instanceof DiscordAPIError && error.status === 404) {
-					return userId;
+			const cached = resolveCache.get(userId);
+			if (cached) {
+				return cached;
+			}
+
+			const promise = (async () => {
+				try {
+					return await api.users.get(userId);
+				} catch (error) {
+					if (error instanceof DiscordAPIError && error.status === 404) {
+						return userId;
+					}
+
+					throw error;
 				}
+			})();
 
-				throw error;
-			}
+			resolveCache.set(userId, promise);
+			return promise;
 		};
 
 		const grants = await Promise.all(