Enabled strict null checks

Author: jzongker

.changeset/strict-typescript-migration.md

@@ -0,0 +1,7 @@
+---
+"@churchapps/helpers": minor
+"@churchapps/apihelper": patch
+"@churchapps/apphelper": patch
+---
+
+Enable full TypeScript strict mode across helpers, apihelper, and apphelper (tech-debt audit item 3). All three packages now extend a shared `tsconfig.base.json` that ships in the helpers package, so consuming apps can opt in via `"extends": "@churchapps/helpers/tsconfig.base.json"`. Fixes are type-level and behavior-preserving; notable declaration changes: `ApiHelper.onRequest`/`onError` are now optional, and several component props/state types widened to `| null` to reflect actual runtime values.

apihelper/src/auth/CustomAuthProvider.ts

@@ -12,14 +12,14 @@ export class CustomAuthProvider implements interfaces.AuthProvider {
     const authHeader = req.headers.authorization;
     if (authHeader) {
       const token = authHeader.split(" ")[1];
-      if (!token) return null;
+      if (!token) return null as unknown as Principal;
       const decoded = jwt.verify(token, EnvironmentBase.jwtSecret);
 
       const result = decoded ? new Principal(typeof decoded === "object" && decoded !== null ? decoded as Record<string, unknown> : {}) : null;
       if (result) result.details.jwt = token;
-      return result;
+      return result as Principal;
     }
 
-    return null;
+    return null as unknown as Principal;
   }
 }

apihelper/src/controllers/ErrorController.ts

@@ -16,10 +16,10 @@ export class ErrorController extends CustomBaseController {
             this.logger.log(req.body[0].application, "info", e);
         }*/
     req.body.forEach(error => {
-      let fullMessage = error.message;
+      let fullMessage = error.message || "";
       if (error.additionalDetails !== undefined) fullMessage += "\n" + error.additionalDetails;
       // if (au !== null) fullMessage += "\nUser: " + au.id + " Church: " + au.churchId;
-      this.logger.log(error.application, error.level, fullMessage);
+      this.logger.log(error.application || "unknown", error.level || "error", fullMessage);
     });
     await this.logger.flush();
     return req.body;

apihelper/src/helpers/AwsHelper.ts

@@ -127,7 +127,7 @@ export class AwsHelper {
         Key: key
       });
       const response = await this.getClient().send(command);
-      return await response.Body?.transformToString();
+      return (await response.Body?.transformToString()) ?? null;
     } catch (error) {
       console.error("Error reading from S3:", error);
       return null;

apihelper/src/helpers/DB.ts

@@ -7,7 +7,7 @@ export class DB {
   // wraps in promise
   static async getConnection() {
     const promise: Promise<PoolConnection> = new Promise((resolve, reject) => {
-      Pool.current.getConnection((ex: QueryError | null, conn: PoolConnection) => { if (ex) reject(ex); else resolve(conn); });
+      Pool.current.getConnection((ex, conn) => { if (ex) reject(ex); else resolve(conn); });
     });
     const connection: PoolConnection = await promise;
     return connection;

apihelper/src/helpers/EmailHelper.ts

@@ -91,7 +91,7 @@ export class EmailHelper {
           await transporter.sendMail({ from, to, subject, html: body, replyTo });
         }
       }
-      return null;
+      return;
     } catch (err) {
       throw err;
     }

apihelper/src/helpers/EnvironmentBase.ts

@@ -55,10 +55,10 @@ export class EnvironmentBase {
     EnvironmentBase.jwtSecret = process.env.JWT_SECRET || await AwsHelper.readParameter(`/${appEnv}/jwtSecret`);
     EnvironmentBase.mailSystem = jsonData.mailSystem as string;
     EnvironmentBase.s3Bucket = jsonData.s3Bucket as string;
-    EnvironmentBase.smtpHost = process.env.SMTP_HOST;
-    EnvironmentBase.smtpPass = process.env.SMTP_PASS;
+    EnvironmentBase.smtpHost = process.env.SMTP_HOST ?? "";
+    EnvironmentBase.smtpPass = process.env.SMTP_PASS ?? "";
     EnvironmentBase.smtpSecure = process.env.SMTP_SECURE === "true";
-    EnvironmentBase.smtpUser = process.env.SMTP_USER;
+    EnvironmentBase.smtpUser = process.env.SMTP_USER ?? "";
   }
 
 }

apihelper/src/helpers/LoggingHelper.ts

@@ -4,17 +4,18 @@ import WinstonCloudWatch from "winston-cloudwatch";
 import { EnvironmentBase } from "./EnvironmentBase.js";
 
 export class LoggingHelper {
-  private static _current: LoggingHelper = null;
+  private static _current: LoggingHelper | null = null;
   public static getCurrent = () => {
-    if (LoggingHelper._current === null) {
-      LoggingHelper._current = new LoggingHelper();
-      LoggingHelper._current.init("API");
+    if (!LoggingHelper._current) {
+      const current = new LoggingHelper();
+      current.init("API");
+      LoggingHelper._current = current;
     }
     return LoggingHelper._current;
   };
 
-  private _logger: winston.Logger = null;
-  private wc: WinstonCloudWatch;
+  private _logger: winston.Logger | null = null;
+  private wc?: WinstonCloudWatch;
   private pendingMessages = false;
   private logGroupName = EnvironmentBase.appName + "_" + EnvironmentBase.appEnv;
   private logDestination = "console";
@@ -26,14 +27,14 @@ export class LoggingHelper {
   public info(msg: string | object) {
     if (this._logger === null) this.init("API");
     this.pendingMessages = true;
-    this._logger.info(msg);
+    this._logger!.info(msg);
   }
 
   public log(streamName: string, level: string, msg: string | object) {
     if (this._logger === null) this.init(streamName);
     this.pendingMessages = true;
-    if (level === "info") this._logger.info(msg);
-    else this._logger.error(msg);
+    if (level === "info") this._logger!.info(msg);
+    else this._logger!.error(msg);
   }
 
   private init(streamName: string) {

apihelper/src/helpers/Pool.ts

@@ -26,7 +26,7 @@ export class Pool {
         if ((field.type === "BIT") && (field.length === 1)) {
           try {
             const bytes = field.buffer();
-            return (bytes[0] === 1);
+            return (bytes?.[0] === 1);
           } catch { return false; }
         }
         return useDefaultTypeCasting();

apihelper/tsconfig.json

@@ -1,25 +1,18 @@
 {
+  "extends": "../helpers/tsconfig.base.json",
   "compilerOptions": {
     "module": "NodeNext",
     "moduleResolution": "NodeNext",
-    "esModuleInterop": true,
-    "allowSyntheticDefaultImports": true,
     "lib": ["ES2020", "DOM"],
     "experimentalDecorators": true,
     "emitDecoratorMetadata": true,
     "target": "ES2020",
-    "noImplicitAny": true,
     "sourceMap": true,
     "outDir": "dist",
     "baseUrl": ".",
-    "strict": false,
     "declaration": true,
-    "declarationMap": true,
-    "skipLibCheck": true,
-    "forceConsistentCasingInFileNames": true,
-    "resolveJsonModule": true,
-    "isolatedModules": true
+    "declarationMap": true
   },
   "include": ["src/**/*"],
   "exclude": ["node_modules", "dist"]
-}
+}