Skip to content

Commit eaf0d99

Browse files
Merge pull request #1025 from CityOfBoston/CYB-1264
CYB-1264: IAMDIR? PING? : Latency within AB registration process
2 parents 031e84b + a649e43 commit eaf0d99

3 files changed

Lines changed: 13 additions & 47 deletions

File tree

services-js/access-boston/src/integration/register-device.testcafe.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,7 @@ test.only('Device registration', async t => {
8383

8484
const donePage = new PageModel();
8585
await t
86-
// .expect(donePage.sectionHeader.withText('YOU’RE ALL SET!').exists)
87-
.expect(donePage.sectionHeader.withText('JUST A MOMENT!').exists)
86+
.expect(donePage.sectionHeader.withText('YOU’RE ALL SET!').exists)
8887
.ok('On done page');
8988

9089
// Now we go home to make sure that the session was destroyed. This should

services-js/access-boston/src/pages/done.tsx

Lines changed: 6 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -12,33 +12,7 @@ interface State {
1212
}
1313

1414
export default class DonePage extends React.Component<Props, State> {
15-
constructor(props: Props) {
16-
super(props);
17-
this.state = { acctFetched: false };
18-
}
19-
20-
async componentDidMount() {
21-
// TODO: DIG-4670: (BUG) Registration Workflow
22-
// THIS IS PACK TO THIS BUG, PROPER FIX NEEDS TO HAPPEN ON
23-
// THE SECURITY TEAMS Servers ...
24-
// Error = User CRUD update is slow to be available on the endpoint (api)
25-
const delay = async (ms: number) => {
26-
return new Promise(resolve => setTimeout(resolve, ms));
27-
};
28-
29-
await delay(13000);
30-
this.setState({ acctFetched: true });
31-
}
32-
3315
render() {
34-
const { acctFetched } = this.state;
35-
36-
const headerTxt = acctFetched ? 'You’re all set!' : 'Just a moment!';
37-
const loginTxt = acctFetched
38-
? `Log in now to
39-
continue.`
40-
: `You can use the button below to Log in a moment.`;
41-
4216
return (
4317
<>
4418
<Head>
@@ -48,22 +22,17 @@ export default class DonePage extends React.Component<Props, State> {
4822

4923
<AppWrapper>
5024
<div className="b b-c b-c--hsm">
51-
<SectionHeader title={headerTxt} />
25+
<SectionHeader title="You’re all set!" />
5226

5327
<div className="t--intro m-v500">
54-
You’re now set up with your Access Boston account. {loginTxt}
28+
You’re now set up with your Access Boston account. Log in now to
29+
continue.
5530
</div>
5631

5732
<div className="ta-r">
58-
{acctFetched ? (
59-
<a href="/" className="btn">
60-
Log In
61-
</a>
62-
) : (
63-
<button className={`btn`} aria-disabled disabled>
64-
Log In
65-
</button>
66-
)}
33+
<a href="/" className="btn">
34+
Log In
35+
</a>
6736
</div>
6837
</div>
6938
</AppWrapper>

services-js/access-boston/src/stories/__snapshots__/Storyshots.test.ts.snap

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4168,27 +4168,25 @@ exports[`Storyshots DonePage default 1`] = `
41684168
>
41694169
<h2
41704170
className="sh-title"
4171-
id="sh-203550349"
4171+
id="sh-2018125994"
41724172
>
4173-
Just a moment!
4173+
You’re all set!
41744174
</h2>
41754175
</div>
41764176
<div
41774177
className="t--intro m-v500"
41784178
>
4179-
You’re now set up with your Access Boston account.
4180-
You can use the button below to Log in a moment.
4179+
You’re now set up with your Access Boston account. Log in now to continue.
41814180
</div>
41824181
<div
41834182
className="ta-r"
41844183
>
4185-
<button
4186-
aria-disabled={true}
4184+
<a
41874185
className="btn"
4188-
disabled={true}
4186+
href="/"
41894187
>
41904188
Log In
4191-
</button>
4189+
</a>
41924190
</div>
41934191
</div>
41944192
</main>

0 commit comments

Comments
 (0)