Skip to content

ignoreCommits set to false, commits not checked? #24

Description

@MadeInPierre

Expected Behavior

Hi! I just tried this action with:

  • rules remained as default
  • commitTitleMatch to false
  • ignoreCommits to false

I expect to check if the PR title is correct as well as the commits in the PR.

Actual Behavior

Here is a simple test with empty commits that do not follow the naming convention (but the PR title does). The checks pass:

image

Isn't it supposed to fail since the commits inside the PR are not valid? Thanks for your help!

Steps to Reproduce the Problem

The attached image is sufficient to reproduce this issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions