Skip to content

Commit 113ca9c

Browse files
author
di57mec
committed
remove redundant path to external sub-modules (RenderingXCore / TelemetryCore)
1 parent 5b8e7ed commit 113ca9c

3 files changed

Lines changed: 15 additions & 8 deletions

File tree

app/CMakeLists.txt

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ include_directories(libs/other)
1010
#Telemetry receiver is included as an imported libarary, e.g we don't compile it here, but rather use .so and .h files
1111
##########################################################################################################
1212
#T_CORE_DIR is passed as an argument in app/build.gradle
13-
set(T_CORE_DIR ${CMAKE_SOURCE_DIR}/../../Telemetry/TelemetryCore)
13+
#set(T_CORE_DIR ${CMAKE_SOURCE_DIR}/../../Telemetry/TelemetryCore)
1414
set(T_SOURCE_DIR ${T_CORE_DIR}/src/main/cpp/Telemetry)
1515
set(T_SO_FILES ${T_CORE_DIR}/jniLibs)
1616
include_directories(${T_SOURCE_DIR})
@@ -28,7 +28,7 @@ set_target_properties( # Specifies the target library.
2828
#we just include and buld here the files from RenderingXCore directly,except glm and gvr
2929
##########################################################################################################
3030
#RX_CORE_DIR is passed as an argument in app/build.gradle
31-
set(RX_CORE_DIR ${CMAKE_SOURCE_DIR}/../../RenderingX/RenderingXCore)
31+
#set(RX_CORE_DIR ${CMAKE_SOURCE_DIR}/../../RenderingX/RenderingXCore)
3232
#first, get all the external libraries that come with RenderingXCore - glm and gvr
3333
#glm is header only, we only need to provide the path
3434
include_directories(${RX_CORE_DIR}/libs/glm)
@@ -116,11 +116,15 @@ target_link_libraries( GLRMono ${GLR_SOME_DEPENDENCIES} )
116116
#target_link_libraries( GLRMono360 ${GLR_SOME_DEPENDENCIES} )
117117

118118
add_library( GLRStereoNormal SHARED
119-
src/main/cpp/GLRenderer/GLRStereoNormal.cpp )
119+
src/main/cpp/GLRenderer/GLRStereoNormal.cpp
120+
src/main/cpp/GLRenderer/SceneStereoscopic.cpp
121+
)
120122
target_link_libraries( GLRStereoNormal ${GLR_SOME_DEPENDENCIES} )
121123

122124
add_library( GLRStereoSuperSync SHARED
123-
src/main/cpp/GLRenderer/GLRStereoSuperSync.cpp )
125+
src/main/cpp/GLRenderer/GLRStereoSuperSync.cpp
126+
src/main/cpp/GLRenderer/SceneStereoscopic.cpp
127+
)
124128
target_link_libraries( GLRStereoSuperSync ${GLR_SOME_DEPENDENCIES} SuperSync)
125129

126130
add_library( GLRStereoDaydream SHARED

app/build.gradle

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,13 @@ android {
1414
cmake {
1515
cppFlags "-std=c++17" //,"-frtti","-fexceptions"
1616
arguments "-DANDROID_STL=c++_static", //, "-DCMAKE_VERBOSE_MAKEFILE=ON"
17-
"-DT_CORE_DIR=${project.rootDir}/..Telemetry/TelemetryCore"//,
18-
//"-DRX_CORE_DIR=${project.rootDir}/../RenderingX/RenderingXCore"
17+
//Pass trough the location for cmake to find native (cpp) code of the RenderingXCore module
18+
"-DT_CORE_DIR=${project(':TelemetryCore').getProjectDir().getAbsolutePath().replace("\\","/")}",
19+
//Pass trough the location for cmake to find native (cpp) code of the TelemetryCore module
20+
"-DRX_CORE_DIR=${project(':RenderingXCore').getProjectDir().getAbsolutePath().replace("\\","/")}"
1921
}
2022
}
23+
2124
ndk {
2225
abiFilters 'armeabi-v7a', 'arm64-v8a', 'x86'
2326
}
@@ -71,7 +74,7 @@ dependencies {
7174
//firebase stuff
7275
implementation 'com.google.firebase:firebase-core:17.2.0'
7376
implementation 'com.crashlytics.sdk.android:crashlytics:2.10.1'
74-
implementation 'com.crashlytics.sdk.android:crashlytics-ndk:2.1.0'
77+
implementation 'com.crashlytics.sdk.android:crashlytics-ndk:2.1.1'
7578
//implementation 'com.google.firebase:firebase-inappmessaging-display:17.1.1'
7679

7780
//Dafuq ?

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ allprojects {
3636
constraintlayoutVersion='1.1.3'
3737
androidxpreferenceVersion='1.1.0'
3838
mGvrVersion = '1.180.0'
39-
}
39+
}
4040
}
4141

4242
task clean(type: Delete) {

0 commit comments

Comments
 (0)