Address review comments

Author: aapeliv

app/backend/resources/postcard-back.png …backend/resources/postcard-back-left.pngapp/backend/resources/postcard-back.png renamed to app/backend/resources/postcard-back-left.png app/backend/resources/postcard-back.png renamed to app/backend/resources/postcard-back-left.png

@@ -0,0 +1,10 @@
+{
+  "back_left": {
+    "qr_left": 222,
+    "qr_top": 414,
+    "qr_size": 322,
+    "code_center_x": 383,
+    "code_center_y": 801,
+    "code_font_size": 58
+  }
+}

app/backend/resources/postcard-metadata.json

@@ -1,7 +1,7 @@
 """Add mypostcard_job_id and rename country to country_code in postal_verification_attempts
 
-Revision ID: 0141
-Revises: 0140
+Revision ID: 0142
+Revises: 0141
 Create Date: 2026-03-18 12:00:00.000000
 
 """
@@ -10,8 +10,8 @@
 from alembic import op
 
 # revision identifiers, used by Alembic.
-revision = "0141"
-down_revision = "0140"
+revision = "0142"
+down_revision = "0141"
 branch_labels = None
 depends_on = None
 

…s/versions/0141_add_mypostcard_job_id.py …s/versions/0142_add_mypostcard_job_id.pyapp/backend/src/couchers/migrations/versions/0141_add_mypostcard_job_id.py renamed to app/backend/src/couchers/migrations/versions/0142_add_mypostcard_job_id.py app/backend/src/couchers/migrations/versions/0141_add_mypostcard_job_id.py renamed to app/backend/src/couchers/migrations/versions/0142_add_mypostcard_job_id.py

@@ -10,43 +10,53 @@
 
 from couchers import urls
 from couchers.config import config
-from couchers.resources import get_postcard_back_template, get_postcard_font, get_postcard_front_image
+from couchers.resources import (
+    get_postcard_back_left_template,
+    get_postcard_font,
+    get_postcard_front_image,
+    get_postcard_metadata,
+)
 
 logger = logging.getLogger(__name__)
 
 API_BASE = "https://www.mypostcard.com/api/v1"
 
 
-def _generate_back_left_side(verification_code: str) -> bytes:
+def _generate_back_left_side_png(verification_code: str) -> bytes:
     """
     Generates the back left side image (780x1016 px PNG at 300 DPI).
 
-    Overlays a QR code and verification code onto the postcard-back.png template.
+    Overlays a QR code and verification code onto the postcard-back-left.png template.
     """
+    metadata = get_postcard_metadata()["back_left"]
+
     # Load template
-    template_bytes = get_postcard_back_template()
+    template_bytes = get_postcard_back_left_template()
     img = Image.open(io.BytesIO(template_bytes)).convert("RGBA")
     draw = ImageDraw.Draw(img)
 
-    # QR code position: exact coordinates in image are (227, 419, 539, 731), extended by 5px in each direction
-    qr_left, qr_top, qr_size = 222, 414, 322
-
     # Generate QR code
     qr = qrcode.QRCode(box_size=10, border=0)
     qr.add_data(urls.postal_verification_link(code=verification_code))
     qr.make(fit=True)
     qr_img: Image.Image = qr.make_image(fill_color="black", back_color="white").get_image().convert("RGBA")
 
     # Size and paste the QR code
+    # QR code position: exact coordinates in image are (227, 419, 539, 731), extended by 5px in each direction
+    qr_size = metadata["qr_size"]
     qr_img = qr_img.resize((qr_size, qr_size), Image.Resampling.NEAREST)
-    img.paste(qr_img, (qr_left, qr_top))
+    img.paste(qr_img, (metadata["qr_left"], metadata["qr_top"]))
 
     # Verification code text center: box in image is (x=251, y=761, w=264, h=80), center is (383, 801)
-    code_center_x, code_center_y = 383, 801
-
-    font = ImageFont.truetype(io.BytesIO(get_postcard_font()), 58)
-
-    draw.text((code_center_x, code_center_y), verification_code, fill=(255, 255, 255), font=font, anchor="mm")
+    font = ImageFont.truetype(io.BytesIO(get_postcard_font()), metadata["code_font_size"])
+
+    draw.text(
+        (metadata["code_center_x"], metadata["code_center_y"]),
+        verification_code,
+        fill=(255, 255, 255),
+        font=font,
+        anchor="mm",
+    )
 
     buf = io.BytesIO()
     img.save(buf, format="PNG")
@@ -156,7 +166,7 @@ def send_postcard(
         recipient["state"] = state
 
     result = _place_order(
-        _authenticate(), recipient, get_postcard_front_image(), _generate_back_left_side(verification_code)
+        _authenticate(), recipient, get_postcard_front_image(), _generate_back_left_side_png(verification_code)
     )
     logger.info(f"MyPostcard order placed successfully: {result}")
     return int(result["job_id"])

app/backend/src/couchers/postal/my_postcard.py

@@ -121,11 +121,19 @@ def get_postcard_font() -> bytes:
 
 
 @functools.cache
-def get_postcard_back_template() -> bytes:
+def get_postcard_metadata() -> dict[str, Any]:
     """
-    Returns the back side template image for the postcard as PNG bytes.
+    Returns the postcard metadata (coordinates, sizes, etc.) from postcard-metadata.json.
     """
-    return (resources_folder / "postcard-back.png").read_bytes()
+    return cast(dict[str, Any], json.loads((resources_folder / "postcard-metadata.json").read_text()))
+
+
+@functools.cache
+def get_postcard_back_left_template() -> bytes:
+    """
+    Returns the back left side template image for the postcard as PNG bytes.
+    """
+    return (resources_folder / "postcard-back-left.png").read_bytes()
 
 
 def copy_resources_to_database(session: Session) -> None:

app/backend/src/couchers/resources.py

@@ -0,0 +1,19 @@
+* New verification page
+
+# Verification
+
+Help keep our community safe by verifying important details about yourself.
+
+
+
+How verification data is used
+
+Verification data is used for regular anti abuse work... such as making sure folks don't create multiple accounts. Additionally, we may disclose verification information to aid in an investigation of serious wrongdoing ... or if legally compelled to do so.
+
+
+
+
+now let's also implement a background job that makes sure in the last week there are no postcard jobs at mypostcard that are not tied to a verification attempt. run it once every 24hr.
+
+
+let's add metrics to postcard sending

app/backend/src/couchers/verification_page.md

@@ -18,7 +18,7 @@
 from couchers.jobs.worker import process_job
 from couchers.models import User
 from couchers.models.postal_verification import PostalVerificationAttempt
-from couchers.postal.my_postcard import _generate_back_left_side
+from couchers.postal.my_postcard import _generate_back_left_side_png
 from couchers.proto import postal_verification_pb2
 from couchers.resources import get_postcard_front_image
 from couchers.utils import now
@@ -699,7 +699,7 @@ def test_generate_postcard_images():
     """
     code = "ABC123"
     front = get_postcard_front_image()
-    back = _generate_back_left_side(code)
+    back = _generate_back_left_side_png(code)
 
     assert len(front) > 0
     assert len(back) > 0