Merge pull request #8602 from Couchers-org/Frontend-Bug-PasswordWarningError

This PR fixing a UI issue in the log in page for English language

Author: kevinortiz43

app/backend/src/couchers/i18n/locales/en.json

@@ -123,6 +123,7 @@
     "invalid_name": "Name not supported.",
     "invalid_notification_preference": "Invalid notification preference.",
     "invalid_password": "Wrong password.",
+    "invalid_password_login": "Wrong username/email or password.",
     "invalid_phone": "Phone number must be in international format without punctuation.",
     "invalid_recipients": "Invalid recipients list.",
     "invalid_region": "Invalid region.",

app/backend/src/couchers/servicers/auth.py

@@ -465,7 +465,7 @@ def Authenticate(self, request: auth_pb2.AuthReq, context: CouchersContext, sess
             else:
                 logger.debug("Wrong password")
                 # wrong password
-                context.abort_with_error_code(grpc.StatusCode.NOT_FOUND, "invalid_password")
+                context.abort_with_error_code(grpc.StatusCode.NOT_FOUND, "invalid_password_login")
         else:  # user not found
             # check if this is an email and they tried to sign up but didn't complete
             signup_flow = session.execute(

app/backend/src/tests/test_account.py

@@ -282,7 +282,7 @@ def test_ChangePasswordV2_normal_wrong_password(db, fast_passwords):
         with pytest.raises(grpc.RpcError) as e:
             account.ChangePasswordV2(
                 account_pb2.ChangePasswordV2Req(
-                    old_password="wrong password",
+                    old_password="Wrong password",
                     new_password=new_password,
                 )
             )
@@ -319,7 +319,7 @@ def test_ChangeEmailV2_wrong_password(db, fast_passwords):
         with pytest.raises(grpc.RpcError) as e:
             account.ChangeEmailV2(
                 account_pb2.ChangeEmailV2Req(
-                    password="wrong password",
+                    password="Wrong password",
                     new_email=new_email,
                 )
             )
@@ -346,7 +346,7 @@ def test_ChangeEmailV2_wrong_email(db, fast_passwords):
         with pytest.raises(grpc.RpcError) as e:
             account.ChangeEmailV2(
                 account_pb2.ChangeEmailV2Req(
-                    password="wrong password",
+                    password="Wrong password",
                     new_email=new_email,
                 )
             )

app/backend/src/tests/test_auth.py

@@ -831,7 +831,7 @@ def test_unsuccessful_authenticate(db):
         with pytest.raises(grpc.RpcError) as e:
             reply = auth_api.Authenticate(auth_pb2.AuthReq(user=user.username, password="incorrectpassword"))
         assert e.value.code() == grpc.StatusCode.NOT_FOUND
-        assert e.value.details() == "Wrong password."
+        assert e.value.details() == "Wrong username/email or password."
 
     # Invalid username
     with auth_api_session() as (auth_api, metadata_interceptor):