Merge pull request #8494 from Couchers-org/backend/bugfix/host-request-push-nights

Backend/push: Tweak host request notif for clarity

Author: aapeliv

app/backend/src/couchers/notifications/locales/en.json

@@ -290,8 +290,8 @@
         "title": "New host request from {{user}}",
         "ios_title": "{{user}}",
         "ios_subtitle": "New Host Request",
-        "body_one": "{{user}} wants to stay from {{start_date}} for {{count}} day.",
-        "body_other": "{{user}} wants to stay from {{start_date}} for {{count}} days."
+        "body_one": "{{user}} wants to stay from {{start_date}} for {{count}} night.",
+        "body_other": "{{user}} wants to stay from {{start_date}} for {{count}} nights."
       }
     },
     "message": {

app/backend/src/couchers/notifications/render_push.py

@@ -509,14 +509,14 @@ def _render_general__new_blog_post(
 def _render_host_request__create(
     data: notification_data_pb2.HostRequestCreate, loc_context: LocalizationContext
 ) -> PushNotificationContent:
-    days = (date.fromisoformat(data.host_request.to_date) - date.fromisoformat(data.host_request.from_date)).days + 1
+    night_count = (date.fromisoformat(data.host_request.to_date) - date.fromisoformat(data.host_request.from_date)).days
     return _get_content(
         NotificationTopicAction.host_request__create,
         loc_context,
         substitutions={
             "user": data.surfer.name,
             "start_date": loc_context.localize_date_from_iso(data.host_request.from_date),
-            "count": days,
+            "count": night_count,
         },
         icon_user=data.surfer,
         action_url=urls.host_request(host_request_id=data.host_request.host_request_id),