Address comments and fix failing tests

Author: nabramow

app/backend/src/couchers/i18n/locales/en.json

@@ -184,6 +184,7 @@
     "public_trip_same_gender_only": "This trip is only open to offers from people of the same gender.",
     "public_trip_not_found": "Couldn't find that public trip.",
     "public_trip_user_mismatch": "The host request recipient does not match the public trip's traveler.",
+    "public_trips_disabled": "Public trips are currently disabled.",
     "public_trips_not_enabled": "Public trips are not enabled in this community.",
     "postal_address_invalid": "The address could not be validated.",
     "postal_address_undeliverable": "The address is not deliverable.",

app/backend/src/tests/conftest.py

@@ -162,6 +162,7 @@ def db_class(setup_testdb: None, testdb_conn: Connection) -> None:
     "remove_removed_users_from_mailing_list_enabled": True,
     "notification_translations_enabled": True,
     "email_ics_attachments_enabled": True,
+    "public_trips_enabled": True,
 }
 
 

app/web/pages/my-public-trips.tsx app/web/pages/public-trips.tsxapp/web/pages/my-public-trips.tsx renamed to app/web/pages/public-trips.tsx

@@ -12,9 +12,6 @@ import nextI18nextConfig from "next-i18next.config";
 import { serverSideTranslations } from "next-i18next/serverSideTranslations";
 
 export const getStaticProps: GetStaticProps = async ({ locale }) => {
-  if (process.env.NEXT_PUBLIC_COUCHERS_ENV === "prod") {
-    return { notFound: true };
-  }
   return {
     props: {
       ...(await serverSideTranslations(

app/web/routes.ts

@@ -191,7 +191,7 @@ export const routeToCommunity = (
 export const routeToEditCommunityPage = (id: number, slug: string) =>
   `${routeToCommunity(id, slug, "info")}/edit`;
 
-export const myPublicTripsRoute = "/my-public-trips";
+export const myPublicTripsRoute = "/public-trips";
 
 export const composingDiscussionHash = "new";
 export const volunteerRoute = "/volunteer";

docs/public_trips.md

@@ -98,7 +98,7 @@ A user cannot create overlapping active trips (same node, overlapping dates, bot
 
 **"Already offered" indicator**: derive from the user's sent host requests (which already carry `public_trip_id`) — no new backend field needed. Disable the button and show a label if a matching sent request exists.
 
-### Trip dashboard (`/my-public-trips`)
+### Trip dashboard (`/public-trips`)
 
 Single page for the surfer to manage all their trips across communities: view active trips, see offers received, edit/close trips.