Merge pull request #9157 from Couchers-org/backend/feature/admin-action-level-trace

Backend: add TRACE level to AdminActionLevel

Author: aapeliv

app/backend/src/couchers/migrations/versions/0169_add_trace_admin_action_level.py

@@ -0,0 +1,25 @@
+"""Add trace to AdminActionLevel
+
+Revision ID: 0169
+Revises: 0168
+Create Date: 2026-06-20 00:00:00.000000
+
+"""
+
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision = "0169"
+down_revision = "0168"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    # 'trace' sorts below 'debug' so the enum's intrinsic ordering matches its severity
+    op.execute("ALTER TYPE adminactionlevel ADD VALUE IF NOT EXISTS 'trace' BEFORE 'debug'")
+
+
+def downgrade() -> None:
+    # PostgreSQL cannot drop a value from an enum type, so this is a no-op.
+    pass

app/backend/src/couchers/models/admin.py

@@ -23,6 +23,7 @@
 
 
 class AdminActionLevel(enum.Enum):
+    trace = enum.auto()
     debug = enum.auto()
     normal = enum.auto()
     high = enum.auto()

app/backend/src/couchers/servicers/admin.py

@@ -77,12 +77,14 @@
 
 
 adminactionlevel2api = {
+    AdminActionLevel.trace: admin_pb2.ADMIN_ACTION_LEVEL_TRACE,
     AdminActionLevel.debug: admin_pb2.ADMIN_ACTION_LEVEL_DEBUG,
     AdminActionLevel.normal: admin_pb2.ADMIN_ACTION_LEVEL_NORMAL,
     AdminActionLevel.high: admin_pb2.ADMIN_ACTION_LEVEL_HIGH,
 }
 
 api2adminactionlevel = {
+    admin_pb2.ADMIN_ACTION_LEVEL_TRACE: AdminActionLevel.trace,
     admin_pb2.ADMIN_ACTION_LEVEL_DEBUG: AdminActionLevel.debug,
     admin_pb2.ADMIN_ACTION_LEVEL_NORMAL: AdminActionLevel.normal,
     admin_pb2.ADMIN_ACTION_LEVEL_HIGH: AdminActionLevel.high,

app/backend/src/tests/test_admin.py

@@ -1277,6 +1277,17 @@ def test_admin_actions_level(db):
         assert len(res.admin_actions) == 3
         assert res.admin_actions[2].level == admin_pb2.ADMIN_ACTION_LEVEL_HIGH
 
+        # Explicitly set to TRACE
+        res = api.AddAdminNote(
+            admin_pb2.AddAdminNoteReq(
+                user=normal_user.username,
+                admin_note="trace note",
+                level=admin_pb2.ADMIN_ACTION_LEVEL_TRACE,
+            )
+        )
+        assert len(res.admin_actions) == 4
+        assert res.admin_actions[3].level == admin_pb2.ADMIN_ACTION_LEVEL_TRACE
+
 
 def test_admin_actions_on_mutations(db, push_collector: PushCollector):
     super_user, super_token = generate_user(is_superuser=True)

app/proto/admin.proto

@@ -11,6 +11,7 @@ import "api.proto";
 
 enum AdminActionLevel {
   ADMIN_ACTION_LEVEL_UNSPECIFIED = 0;
+  ADMIN_ACTION_LEVEL_TRACE = 4;    // firehose, below debug
   ADMIN_ACTION_LEVEL_DEBUG = 1;    // low-importance chatter
   ADMIN_ACTION_LEVEL_NORMAL = 2;   // regular admin work
   ADMIN_ACTION_LEVEL_HIGH = 3;     // significant state changes