Frontend/landing: Improve app store badge string keys (#8669)

Author: tristanlabelle

app/web/components/Footer/Footer.tsx

@@ -258,7 +258,7 @@ export default function Footer({ bottomMargin }: { bottomMargin?: string }) {
               >
                 <img
                   src="/img/Download_on_the_App_Store_Badge_US-UK_RGB_blk_092917.svg"
-                  alt={t("download_on_app_store")}
+                  alt={t("app_store_badge_a11y")}
                   style={{ height: "26px", width: "auto", display: "block" }}
                 />
               </a>
@@ -277,7 +277,7 @@ export default function Footer({ bottomMargin }: { bottomMargin?: string }) {
                 >
                   <img
                     src="/img/GetItOnGooglePlay_Badge_Web_color_English.svg"
-                    alt={t("get_it_on_google_play")}
+                    alt={t("google_play_badge_a11y")}
                     style={{
                       height: "39px",
                       width: "auto",

app/web/features/landing/CouchersIntroduction.tsx

@@ -32,7 +32,7 @@ function AppStoreBadges({ appStoreHeight = 38 }: { appStoreHeight?: number }) {
       <a href={couchersAppStoreURL} target="_blank" rel="noopener noreferrer">
         <img
           src="/img/Download_on_the_App_Store_Badge_US-UK_RGB_blk_092917.svg"
-          alt={t("download_on_app_store")}
+          alt={t("app_store_badge_a11y")}
           style={{
             height: `${appStoreHeight}px`,
             width: "auto",
@@ -51,7 +51,7 @@ function AppStoreBadges({ appStoreHeight = 38 }: { appStoreHeight?: number }) {
         >
           <img
             src="/img/GetItOnGooglePlay_Badge_Web_color_English.svg"
-            alt={t("get_it_on_google_play")}
+            alt={t("google_play_badge_a11y")}
             style={{
               height: `${googlePlayHeight}px`,
               width: "auto",

app/web/resources/locales/de.json

@@ -338,6 +338,6 @@
     "a11y": "Kopieren",
     "copied_tooltip": "In die Zwischenablage kopiert"
   },
-  "download_on_app_store": "Im App Store herunterladen",
-  "get_it_on_google_play": "Bei Google Play herunterladen"
+  "app_store_badge_a11y": "Im App Store herunterladen",
+  "google_play_badge_a11y": "Bei Google Play herunterladen"
 }

app/web/resources/locales/en.json

@@ -6,8 +6,8 @@
   "retract": "Retract",
   "couchers": "Couchers.org",
   "learn_more": "Learn more",
-  "download_on_app_store": "Download on the App Store",
-  "get_it_on_google_play": "Get it on Google Play",
+  "app_store_badge_a11y": "Download on the App Store",
+  "google_play_badge_a11y": "Get it on Google Play",
   "legal_name": "Couchers, Inc.",
   "login": "Log in",
   "sign_up": "Sign up",