Trim verbose comments in native diagnostics code

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: aapeliv

app/backend/src/couchers/servicers/bugs.py

@@ -196,12 +196,9 @@ def ReportDiagnostics(
     def CheckNativeStatus(
         self, request: bugs_pb2.CheckNativeStatusReq, context: CouchersContext, session: Session
     ) -> bugs_pb2.CheckNativeStatusRes:
-        # Stub for now: just log the client's diagnostics blob alongside the session user so we can
-        # see real pings in prod. A later pass will persist these and decide whether to force-update.
+        # Stub: log the ping for now. TODO: persist it and decide whether to force-update.
         logger.info("CheckNativeStatus: user_id=%s debug=%s", context._user_id, request.debug_json)
 
-        # TODO: decide based on the reported app version / build whether this client is below a
-        # minimum supported version and should be force-updated.
         return bugs_pb2.CheckNativeStatusRes(
             update_required=False,
             update_available=False,

app/mobile/features/diagnostics/installId.ts

@@ -2,9 +2,7 @@ import AsyncStorage from "@react-native-async-storage/async-storage";
 import * as Application from "expo-application";
 import { Platform } from "react-native";
 
-// A UUID we generate and persist on first launch. It's the primary key for a device install in the
-// diagnostics pipeline. It survives app restarts and OTA updates, but resets on reinstall (the
-// platform identifiers below cover cross-install correlation where the OS allows it).
+// UUID generated and persisted on first launch; survives restarts/OTA, resets on reinstall.
 const INSTALL_ID_KEY = "diagnostics.installId";
 
 function uuidv4(): string {
@@ -25,11 +23,7 @@ export async function getInstallId(): Promise<string> {
   return id;
 }
 
-// Best-effort platform identifiers reported alongside install_id for cross-install correlation.
-// - iOS: identifierForVendor persists across reinstall only while another app from our Apple Team
-//   is installed; otherwise it regenerates.
-// - Android: ANDROID_ID (SSAID) is stable across reinstalls of apps signed with the same key and
-//   resets only on factory reset.
+// Best-effort platform identifiers for cross-install correlation (iOS IDFV, Android SSAID).
 export async function getPlatformDeviceIds(): Promise<{
   idfv?: string;
   androidId?: string;
@@ -43,7 +37,7 @@ export async function getPlatformDeviceIds(): Promise<{
       return { androidId: Application.getAndroidId() ?? undefined };
     }
   } catch {
-    // Identifiers are best-effort; never block a diagnostics ping on them.
+    // best-effort; never block a ping
   }
   return {};
 }

app/mobile/features/diagnostics/pushTokenStore.ts

@@ -1,8 +1,6 @@
 import AsyncStorage from "@react-native-async-storage/async-storage";
 
-// The last Expo push token we successfully registered with the backend. Persisted so the
-// diagnostics ping can report it (letting the backend correlate push reachability with delivery
-// receipts) without re-fetching a token on every app open.
+// The last Expo push token registered with the backend, persisted so diagnostics can report it.
 const PUSH_TOKEN_KEY = "diagnostics.pushToken";
 
 export async function setStoredPushToken(token: string): Promise<void> {

app/mobile/features/diagnostics/useNativeDiagnostics.ts

@@ -16,26 +16,16 @@ import {
 import { getStoredPushToken } from "@/features/diagnostics/pushTokenStore";
 import { checkNativeStatus } from "@/service/checkNativeStatus";
 
-// We treat each foreground activation as a potential "app open", but throttle pings so a user
-// quickly toggling in and out of the app doesn't flood the pipeline. time_since_last_open is the
-// gap since the previous ping, which for a normally-used app is the day-to-day open cadence.
 const LAST_OPEN_KEY = "diagnostics.lastOpenAt";
-const PING_THROTTLE_MS = 30 * 60 * 1000; // 30 minutes
+const PING_THROTTLE_MS = 30 * 60 * 1000;
 
-/**
- * Periodically reports a diagnostics snapshot (app version, OTA bundle, push state, etc.) to the
- * backend's CheckNativeStatus endpoint. Fires on cold start and on each background→foreground
- * transition, throttled to at most once per PING_THROTTLE_MS.
- *
- * Everything here is best-effort and fire-and-forget: a failed or skipped ping must never affect
- * app startup or the user.
- */
+// Reports a diagnostics snapshot to CheckNativeStatus on cold start and each foreground
+// transition, throttled to at most once per PING_THROTTLE_MS. Best-effort and fire-and-forget.
 export function useNativeDiagnostics(): void {
   const { authenticated } = useAuthContext();
   const { i18n } = useTranslation();
 
-  // Read auth/locale via refs so the AppState listener always sees current values without
-  // re-subscribing on every change.
+  // Refs so the AppState listener sees current values without re-subscribing.
   const authenticatedRef = useRef(authenticated);
   authenticatedRef.current = authenticated;
   const localeRef = useRef(i18n.language);
@@ -92,9 +82,7 @@ export function useNativeDiagnostics(): void {
 
         await AsyncStorage.setItem(LAST_OPEN_KEY, String(now));
 
-        // TODO: surface a force-update / soft-update UI when the backend asks the client to update.
-        // For now the server always returns permissive defaults; once the decision logic exists
-        // we'll wire result.updateRequired / updateAvailable into a modal here.
+        // TODO: wire result.updateRequired / updateAvailable into a force-update UI.
         if (result.updateRequired || result.updateAvailable) {
           console.log("Native status update prompt:", result);
         }
@@ -103,10 +91,8 @@ export function useNativeDiagnostics(): void {
       }
     }
 
-    // Cold start.
     maybeReport();
 
-    // Subsequent background→foreground transitions.
     const subscription = AppState.addEventListener(
       "change",
       (state: AppStateStatus) => {

app/mobile/service/checkNativeStatus.ts

@@ -8,13 +8,7 @@ export interface NativeStatusResult {
   updateMessage: string;
 }
 
-/**
- * Sends a best-effort diagnostics snapshot to the backend and returns its update decision.
- *
- * The snapshot is an arbitrary object (app version, OTA bundle, push state, etc.) that we just
- * JSON-encode into a single field; the backend only logs it for now, so new fields can be added
- * here without a proto change.
- */
+// JSON-encodes a diagnostics snapshot into debug_json and returns the backend's update decision.
 export async function checkNativeStatus(
   debugInfo: Record<string, unknown>,
 ): Promise<NativeStatusResult> {

app/proto/bugs.proto

@@ -52,9 +52,8 @@ service Bugs {
   rpc ReportDiagnostics(ReportDiagnosticsReq) returns (google.protobuf.Empty) {}
 
   rpc CheckNativeStatus(CheckNativeStatusReq) returns (CheckNativeStatusRes) {
-    // Diagnostics ping from the native mobile apps. The client sends a best-effort JSON blob of
-    // diagnostics (app version, OTA bundle, push state, etc.); for now the backend just logs it.
-    // The response carries status back to the client, e.g. whether it must force the user to update.
+    // Diagnostics ping from the native mobile apps. The client sends a JSON blob (just logged for
+    // now); the response tells the client whether it must force the user to update.
   }
 
   rpc EvaluateFeatureFlag(EvaluateFeatureFlagReq) returns (EvaluateFeatureFlagRes) {
@@ -127,10 +126,8 @@ message ReportDiagnosticsReq {
 }
 
 message CheckNativeStatusReq {
-  // Best-effort diagnostics snapshot, JSON-encoded by the client (app/build version, OTA bundle,
-  // platform/device, push state, install id, etc.). Free-form on purpose: the backend just logs it
-  // for now, so the client can add fields without a proto change. The session's user is read
-  // server-side, so this need not (and should not) contain auth tokens or PII.
+  // Free-form diagnostics snapshot, JSON-encoded by the client. The session's user is read
+  // server-side, so this should not contain auth tokens or PII.
   string debug_json = 1;
 }