Skip to content

Commit bb43578

Browse files
committed
Backend/moderation: simplify from_visibility validation
Use a set comprehension and a single None check instead of an explicit loop.
1 parent 7157804 commit bb43578

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

app/backend/src/couchers/servicers/moderation.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -542,12 +542,9 @@ def SetUserContentVisibility(
542542
if new_visibility is None:
543543
context.abort_with_error_code(grpc.StatusCode.INVALID_ARGUMENT, "visibility_must_be_specified")
544544

545-
from_visibilities: set[ModerationVisibility] = set()
546-
for v in request.from_visibility:
547-
mapped = moderationvisibility2sql[v]
548-
if mapped is None:
549-
context.abort_with_error_code(grpc.StatusCode.INVALID_ARGUMENT, "visibility_must_be_specified")
550-
from_visibilities.add(mapped)
545+
from_visibilities = {moderationvisibility2sql[v] for v in request.from_visibility}
546+
if None in from_visibilities:
547+
context.abort_with_error_code(grpc.StatusCode.INVALID_ARGUMENT, "visibility_must_be_specified")
551548

552549
user = session.execute(select(User).where(User.id == request.user_id)).scalar_one_or_none()
553550
if not user:

0 commit comments

Comments
 (0)