Skip to content

Commit c880794

Browse files
authored
Merge pull request #8770 from Couchers-org/na/web/fix-reminder-text
Fix reminder text host vs surf reference
2 parents 5b4bc01 + 67ace94 commit c880794

3 files changed

Lines changed: 10 additions & 5 deletions

File tree

app/web/features/dashboard/ReminderItem.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ describe("ReminderItem", () => {
6565
).toBeVisible();
6666
expect(
6767
screen.getByText(
68-
t("dashboard:reminder.write_reference.description", {
68+
t("dashboard:reminder.write_reference.description_hosted", {
6969
name: surferUser.name,
7070
}),
7171
),

app/web/features/dashboard/ReminderItem.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import { useTranslation } from "i18n";
77
import { DASHBOARD } from "i18n/namespaces";
88
import Link from "next/link";
99
import { Reminder } from "proto/account_pb";
10+
import { ReferenceType } from "proto/references_pb";
1011
import {
1112
referenceTypeRoute,
1213
routeToEditProfile,
@@ -44,9 +45,12 @@ export default function ReminderItem({
4445
const { hostRequestId, otherUser, referenceType } =
4546
reminder.writeReferenceReminder;
4647
title = t("reminder.write_reference.title");
47-
description = t("reminder.write_reference.description", {
48-
name: otherUser.name,
49-
});
48+
description = t(
49+
referenceType === ReferenceType.REFERENCE_TYPE_SURFED
50+
? "reminder.write_reference.description_surfed"
51+
: "reminder.write_reference.description_hosted",
52+
{ name: otherUser.name },
53+
);
5054
buttonText = t("reminder.write_reference.button");
5155
href = routeToLeaveReference(
5256
referenceTypeRoute[referenceType],

app/web/features/dashboard/locales/en.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@
8181
},
8282
"write_reference": {
8383
"title": "Write a reference",
84-
"description": "Leave a reference for {{name}}'s stay",
84+
"description_surfed": "Leave a reference for your stay at {{name}}'s",
85+
"description_hosted": "Leave a reference for {{name}}'s stay",
8586
"button": "Write reference"
8687
},
8788
"complete_profile": {

0 commit comments

Comments
 (0)