Fix some call sites

Author: tristanlabelle

app/backend/src/couchers/notifications/render_push.py

@@ -195,7 +195,7 @@ def _get_string(
         full_key = f"{string_group.topic}.{string_group.action}.push.{key}"
     else:
         full_key = f"{string_group}.{key}"
-    return get_notifs_i18next().localize(full_key, loc_context.locale, substitutions)
+    return get_notifs_i18next().localize(full_key, loc_context.locale_list, substitutions)
 
 
 def _avatar_url_or_default(user: api_pb2.User) -> str:

app/backend/src/couchers/notifications/settings.py

@@ -337,7 +337,7 @@ def get_user_setting_groups(
                 actions = []
                 for topic_action in items:
                     delivery_types = get_preference(session, user_id, topic_action)
-                    description = get_topic_action_description(topic_action, locale=loc_context.locale)
+                    description = get_topic_action_description(topic_action, locales=loc_context.locale_list)
                     actions.append(
                         notifications_pb2.NotificationItem(
                             action=topic_action.action,

app/backend/src/couchers/notifications/utils.py

@@ -17,6 +17,6 @@ def can_notify_deleted_user(topic_action: NotificationTopicAction) -> bool:
     return topic_action in _DELETED_USER_NOTIFICATIONS
 
 
-def get_topic_action_description(topic_action: NotificationTopicAction, locale: str) -> str:
+def get_topic_action_description(topic_action: NotificationTopicAction, locales: list[str]) -> str:
     description_key = f"{topic_action.topic}.{topic_action.action}.event_description"
-    return get_notifs_i18next().localize(description_key, locale)
+    return get_notifs_i18next().localize(description_key, locales)

app/backend/src/tests/test_notification_settings.py

@@ -33,7 +33,7 @@ def test_all_notifications_appear_in_settings() -> None:
 def test_all_notifications_have_descriptions() -> None:
     for topic_action in NotificationTopicAction:
         # Will throw if there's no string
-        assert get_topic_action_description(topic_action, locale=DEFAULT_LOCALE) != ""
+        assert get_topic_action_description(topic_action, locales=[DEFAULT_LOCALE]) != ""
 
 
 def test_topic_action_unsubscribe_text_iff_unsubscribable() -> None: