Skip to content

Commit fb79b20

Browse files
committed
Fix browser warning for isNativeEmbed
1 parent d89c5e9 commit fb79b20

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

app/web/components/Navigation/LoggedInMenu.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,9 @@ type LoggedInMenuDialogItem = {
4444

4545
export type LoggedInMenuItem = LoggedInMenuLinkItem | LoggedInMenuDialogItem;
4646

47-
const StyledMenu = styled(Menu)<{ $isNativeEmbed?: boolean }>(({
48-
theme,
49-
$isNativeEmbed,
50-
}) => {
47+
const StyledMenu = styled(Menu, {
48+
shouldForwardProp: (prop) => prop !== "$isNativeEmbed",
49+
})<{ $isNativeEmbed?: boolean }>(({ theme, $isNativeEmbed }) => {
5150
// Native embed: full height (native tabs handle safe area)
5251
// Mobile web: subtract bottom nav + safe area
5352
const menuHeight = $isNativeEmbed

app/web/features/profile/edit/EditProfile.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,9 @@ const AvatarTextWrapper = styled(Box)(({ theme }) => ({
162162
},
163163
}));
164164

165-
const StickySaveBar = styled(Box)<{ $isNativeEmbed?: boolean }>(({
166-
theme,
167-
$isNativeEmbed,
168-
}) => {
165+
const StickySaveBar = styled(Box, {
166+
shouldForwardProp: (prop) => prop !== "$isNativeEmbed",
167+
})<{ $isNativeEmbed?: boolean }>(({ theme, $isNativeEmbed }) => {
169168
// Mobile web has bottom nav (55px), native embed doesn't
170169
const bottomNavHeight = $isNativeEmbed ? 0 : 55;
171170
// Native tabs handle safe area, mobile web needs extra padding

0 commit comments

Comments
 (0)