Web/bugfix/language picker mobile - #8550
Conversation
…ly based. Adds test cases.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…chers-org/couchers into web/bugfix/language-picker-mobile
|
@christiansaavedra Are you still planning on finishing this? Just checking so it doesn't stay blocked a long time. |
…m/Couchers-org/couchers into web/bugfix/language-picker-mobile
Hey Nicole, can you confirm me if this is the expected behaviour? Im a bit confused but my understanding is that this should be the expected behavior: a) Logged in case:
b) Logged out case:
Please let me know, thanks |
Here are the four views we want: Desktop
Mobile View
This shows on landing page, sign up, login so should cover everything. Also remove LanguagePicker from the bottom of the Signup and Login pages
Let me know if that makes sense! |
Preview buildsMobile Dev Tool previewScan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client. ios — Open in Dev Tool Deep linkandroid — Open in Dev Tool Deep linkcommit |
Pushed, let me know! Thank you |
|
@christiansaavedra Put in one small suggestion then this is ready to go! |
Co-authored-by: Nicole <nabramow@gmail.com>
Awesome, I accepted it. LFG! |
📝 Release NotesThis PR should be included in the release notes. Suggested release note: 🤖 Bot Debug InformationModel: |













This PR implements conditional validation for displaying the language selector in the navigation bar. The language picker is shown on desktop and on mobile for unauthenticated users, but hidden on mobile for authenticated users to streamline the interface and reduce clutter. Jest uni tests added.
The solution uses a useMemo hook in the [Navigation.tsx] component to compute shouldShowLanguagePickerSelect boolean based on isMobile and authState.authenticated.
On mobile devices, the selector is only displayed when the user is not authenticated, improving the user experience by avoiding unnecessary UI elements for logged-in users who likely have their language preferences set elsewhere.
Testing
Jest files added. I tested this by running the web app locally using yarn start. I verified the language selector visibility on desktop (always shown), mobile unauthenticated (shown), and mobile authenticated (hidden). Used browser dev tools to simulate mobile viewports and authentication states. No console warnings were observed during testing.
Reference issues
"closes #8097"
Backend checklist
developif necessary for linear migration historyWeb frontend checklist
For maintainers