Skip to content

Frontend/i18n: Localize list separators#9163

Closed
tristanlabelle wants to merge 3 commits into
developfrom
frontend/feature/i18n-loc-lists
Closed

Frontend/i18n: Localize list separators#9163
tristanlabelle wants to merge 3 commits into
developfrom
frontend/feature/i18n-loc-lists

Conversation

@tristanlabelle

@tristanlabelle tristanlabelle commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Not all languages use the western comma. I'm not using Intl.ListFormat directly because it will always add "and" / "or", which we don't want in our current contexts.

Testing

View a profile with regions visited:

image image

Web frontend checklist

  • There are no console warnings when running the app
  • Added tests where relevant
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

For maintainers

  • Maintainers can push commits to my branch
  • Maintainers can merge this PR for me

@CouchersBot

CouchersBot commented Jun 22, 2026

Copy link
Copy Markdown
Member

Mobile

Install the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here.

Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.

    iOS         Android    
    QR to open the iOS build         QR to open the Android build    
    Open in Dev Tool         Open in Dev Tool    
Deep links

iOS

couchers-devtool://expo-development-client/?url=https%3A%2F%2F816449d8--ota.preview.couchershq.org%2Fios%2Fmanifest

Android

couchers-devtool://expo-development-client/?url=https%3A%2F%2F816449d8--ota.preview.couchershq.org%2Fandroid%2Fmanifest

Web (Vercel)

View the Vercel web preview for this branch.

Backend

Schema Schema diff Sample emails

Other

Protos Backend coverage Web coverage

@tristanlabelle
tristanlabelle marked this pull request as ready for review June 22, 2026 15:27
@tristanlabelle
tristanlabelle requested a review from nabramow as a code owner June 22, 2026 15:27
@tristanlabelle
tristanlabelle requested review from a team and HankAviator June 22, 2026 15:27
@nabramow

nabramow commented Jun 24, 2026

Copy link
Copy Markdown
Member

Wow new fun fact for me, I did not know this!

Just checking scope, this is only the regions visited in the profile yeah? Will this eventually apply to everywhere we have commas like in the dashboard widgets, map search results card, etc? Or it's just where we have lists of things?

Screenshot 2026-06-24 at 10 43 34

@HankAviator HankAviator left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite detailed-oriented commit. The usage of the enumeration comma has a rule of thumb: there aren't many items (less than or equal to 5 items usually), each item should be short (about 4 characters or less). Considering the country list can be very long, this punctuation will make user feel "busy" or "messy", in that case, a comma is better.

This commit itself is fine but using comma will be much simpler @tristanlabelle

@tristanlabelle

Copy link
Copy Markdown
Contributor Author

@nabramow It's specifically for lists of things. I'm not sure what the exact boundary is but Chinese uses regular commas between clauses of a sentence, but the enumeration back-comma for lists (especially of nouns).

But we have the expert here :) @HankAviator , Interesting! What happens with longer lists of nouns? What about when we'll have localized the region names as well? Which one would you prefer seeing?

  1. 加拿大,墨西哥,美國
  2. 加拿大、墨西哥、美國

(assuming those lists are arbitrarily long, as some people have visited 50 countries)

@HankAviator

Copy link
Copy Markdown
Contributor

is completely fine, people rarely use nowadays online (except for grammar police like me but even I use it so rarely as it can't be well understood internationally). In your example both are fine, 2nd looks slightly better to me, but I don't feel it's worthwhile to make the change just for Chinese (not sure about JK though). @tristanlabelle

@tristanlabelle

Copy link
Copy Markdown
Contributor Author

Ok! I'll drop this change then. Thanks for being such a permissive grammar police :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants