Frontend/i18n: Localize list separators#9163
Conversation
MobileInstall the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here. Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.
Deep linksiOS Android Web (Vercel)View the Vercel web preview for this branch. Backend
Other
|
HankAviator
left a comment
There was a problem hiding this comment.
Quite detailed-oriented commit. The usage of the enumeration comma has a rule of thumb: there aren't many items (less than or equal to 5 items usually), each item should be short (about 4 characters or less). Considering the country list can be very long, this punctuation will make user feel "busy" or "messy", in that case, a comma is better.
This commit itself is fine but using comma will be much simpler @tristanlabelle
|
@nabramow It's specifically for lists of things. I'm not sure what the exact boundary is but Chinese uses regular commas between clauses of a sentence, but the enumeration back-comma for lists (especially of nouns). But we have the expert here :) @HankAviator , Interesting! What happens with longer lists of nouns? What about when we'll have localized the region names as well? Which one would you prefer seeing?
(assuming those lists are arbitrarily long, as some people have visited 50 countries) |
|
|
|
Ok! I'll drop this change then. Thanks for being such a permissive grammar police :) |



Not all languages use the western comma. I'm not using
Intl.ListFormatdirectly because it will always add "and" / "or", which we don't want in our current contexts.Testing
View a profile with regions visited:
Web frontend checklist
For maintainers