Frontend: Split key/labels in ProfileTagInput - #9169
Conversation
MobileInstall the Dev Tool (iOS via TestFlight, iOS Simulator, or Android .apk) here. Scan the QR with your phone camera, or tap Open in Dev Tool on the device, to open this branch in the installed Dev Tool dev client.
Deep linksiOS Android Web (Vercel)View the Vercel web preview for this branch. Backend
Other
|
|
@nabramow , yes, my next PR will bake localization in |
nabramow
left a comment
There was a problem hiding this comment.
LGTM pulled the branch and nothing looks different at least
📝 Release NotesThis PR does not need to be included in release notes. Reason: This PR is explicitly a refactor with no functional changes and no visible user-facing impact yet. It prepares profile tag inputs for future localization work, but on its own it does not add a feature, fix an important user-facing bug, or introduce a major technical infrastructure improvement that end users would notice. 🤖 Bot Debug InformationModel: |



Refactors
ProfileTagInputto take key:label pairs as the list of options, for example{ en: "English", fr: "French" }. We still display the labels, but only expose the keys to consuming code since those are what the business logic needs. This way consumers don't need to map and reverse-map display strings.This is related to and motivated by #8424: it will then make it trivial to translate spoken languages by providing a dictionary like
{ en: "Anglais", fr: "Français" }since we have translation keys for (some) language codes.No functional changes.
Testing
Edited profile using the Vercel link on this PR.
Web frontend checklist
For maintainers