Commit ba3499e
committed
fix(release): ggml_backend_is_cuda is unlinkable in the shipped .so; gate cosyvoice3's tail per backend
Two things, both from the v0.8.33 tag run.
1. THE RELEASE BUILD FAILED TO LINK. build-linux-x86_64-cuda and -cuda13 both
died with:
libcrispasr.so.0.8.33: undefined reference to `ggml_backend_is_cuda'
Same class as the ggml_backend_is_cpu break fixed earlier this cycle:
ggml_backend_is_cuda is a CUDA-MODULE symbol and is not linkable into the
shared library. Two call sites had it — mimo_tokenizer.cpp and parakeet.cpp.
Both now test the backend NAME via ggml_backend_name(), which is core ggml,
matching what granite_speech, dots_tts and omnivoice already do — copying the
code that demonstrably links rather than inventing a fourth approach. ROCm is
included for the same reason granite_speech includes it. Swept src/*.cpp for
the rest of the class: the only other hit, ggml_backend_is_metal, is a
comment.
Every other tag workflow passed — Docker, language wrappers, Win CUDA13,
Piper Windows, ISA fallback and all four bindings — so this is the release
artifacts only, not the tag.
2. CRISPASR_COSYVOICE3_CAMPP_TAIL=legacy, a per-backend switch for the
unresolved tail-divisor question. Both paths synthesise correctly (8/8 each),
so this is a CONSISTENCY control, not correctness: by default `--voice
ref.wav` differs from the baked voice bank by cos ~0.998 for the same voice,
because the shipped bank was produced with the old divisor. `legacy` makes
the two agree.
Backend-specific ON PURPOSE. CRISPASR_CAMPP_LEGACY_SEGPOOL already exists but
is global, and would drag chatterbox, confucius4, dots-tts and fireredtts3
away from their own settled PyTorch references to answer a question that is
only open for cosyvoice3.1 parent cdb6ab0 commit ba3499e
4 files changed
Lines changed: 64 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1603 | 1603 | | |
1604 | 1604 | | |
1605 | 1605 | | |
| 1606 | + | |
| 1607 | + | |
| 1608 | + | |
| 1609 | + | |
| 1610 | + | |
| 1611 | + | |
| 1612 | + | |
| 1613 | + | |
| 1614 | + | |
| 1615 | + | |
| 1616 | + | |
| 1617 | + | |
| 1618 | + | |
| 1619 | + | |
| 1620 | + | |
| 1621 | + | |
| 1622 | + | |
| 1623 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3121 | 3121 | | |
3122 | 3122 | | |
3123 | 3123 | | |
| 3124 | + | |
| 3125 | + | |
| 3126 | + | |
| 3127 | + | |
| 3128 | + | |
| 3129 | + | |
| 3130 | + | |
| 3131 | + | |
| 3132 | + | |
| 3133 | + | |
| 3134 | + | |
| 3135 | + | |
| 3136 | + | |
| 3137 | + | |
| 3138 | + | |
| 3139 | + | |
| 3140 | + | |
| 3141 | + | |
| 3142 | + | |
| 3143 | + | |
| 3144 | + | |
| 3145 | + | |
| 3146 | + | |
| 3147 | + | |
| 3148 | + | |
| 3149 | + | |
| 3150 | + | |
3124 | 3151 | | |
3125 | 3152 | | |
3126 | 3153 | | |
| |||
5620 | 5647 | | |
5621 | 5648 | | |
5622 | 5649 | | |
5623 | | - | |
| 5650 | + | |
| 5651 | + | |
5624 | 5652 | | |
5625 | 5653 | | |
5626 | 5654 | | |
| |||
6353 | 6381 | | |
6354 | 6382 | | |
6355 | 6383 | | |
6356 | | - | |
| 6384 | + | |
| 6385 | + | |
6357 | 6386 | | |
6358 | 6387 | | |
6359 | 6388 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
443 | 443 | | |
444 | 444 | | |
445 | 445 | | |
446 | | - | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
447 | 454 | | |
448 | 455 | | |
449 | 456 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1404 | 1404 | | |
1405 | 1405 | | |
1406 | 1406 | | |
1407 | | - | |
| 1407 | + | |
| 1408 | + | |
| 1409 | + | |
| 1410 | + | |
| 1411 | + | |
| 1412 | + | |
| 1413 | + | |
1408 | 1414 | | |
1409 | 1415 | | |
1410 | 1416 | | |
| |||
0 commit comments