Multilayer#129
Open
CyprienBosserelle wants to merge 90 commits into
Open
Conversation
Reading init ok
Add functions to calculate basic culvert / pump system and its modification of h
Basic error fixed but complex error declaration functions ?
* Catchup ML with Dev branch
Lower default culvert Qmax from 200.0 to 1.0 in Input.h. Allow user input of Qmax as 6th parameter. In ReadInput.cu, cache the parsed culvert type into MyCulvertType and assign myculvert.type from it, then conditionally interpret the 6th CSV field as either shape (for type >= 1) or Qmax (for other types). Also refactor to avoid repeated stoi calls and add parsing guards.
Commented out a debug printf in the AddCulverts template function that printed nblkculvert and XCulverts.size(). This removes noisy debug output without changing functionality.
Q in the equation was not calculated properly. Now fixed
Trying different Culvert outlet equation.... the original one did not conserve energy! New one seem less stable
This should only be needed if/when optimizing
adding Culverts to multilayer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix and Test New hydrostatic engine
engine = 5allows the user to use the equivalent of the 1-layered multi-layer hydrostatic engine from basilisk. The engine has been rewritten for BG_Flood but it is essentially/hopefully the same. We are running extra test to check if it is as good or better than other engine available.Still to do: