Skip to content

Commit 1a41fc4

Browse files
committed
Always show drive picker on Linux, conditional yellow explanation
Drive picker now shows on every Linux install regardless of transport mix. Users can exclude any drive (USB backup, test drives, etc.) not just iSCSI. Yellow transport explanation only appears when yellow drives are present. Updated README exclude_devices docs to reflect always-show behavior.
1 parent 9da9191 commit 1a41fc4

2 files changed

Lines changed: 14 additions & 17 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ filesystems: # optional -- set by installer's disk usage picke
166166
167167
All options can also be set via CLI flags: `--port`, `--token`, `--scan-interval`, `--interface`, `--config`.
168168

169-
**Exclude devices:** Device paths listed in `exclude_devices` are skipped during every scan. The agent resolves symlinks at startup, so `/dev/disk/by-id/...` paths and their `/dev/sdX` equivalents both match. The installer's drive picker sets this automatically when it detects iSCSI, Fibre Channel, or other remote-storage transports that don't support SMART passthrough. You can also add paths manually and restart the service. If a device appears in both `exclude_devices` and `device_overrides`, the exclusion wins and a warning is logged.
169+
**Exclude devices:** Device paths listed in `exclude_devices` are skipped during every scan. The agent resolves symlinks at startup, so `/dev/disk/by-id/...` paths and their `/dev/sdX` equivalents both match. The installer's drive picker (Linux) shows all detected drives and lets you choose which ones to monitor -- useful for excluding iSCSI LUNs, USB backup drives, or anything you don't want polled. Drives with remote-storage transports (iSCSI, Fibre Channel) are flagged in yellow and excluded from the default selection. You can also add paths manually and restart the service. If a device appears in both `exclude_devices` and `device_overrides`, the exclusion wins and a warning is logged.
170170

171171
**Scan interval:** Uses Go duration syntax -- `30s`, `5m`, `1h`, `24h` are all valid. When `standby_mode` is set, the agent skips sleeping drives and serves cached data, so the interval does not cause unnecessary wake-ups. When `standby_mode` is `never` (the default), each poll wakes any drive that is spun down. This is the *agent-side* read cadence and is separate from the HA Poll Interval entity, which reflects how often Home Assistant pulls fresh data from the agent itself.
172172

install.sh

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -687,19 +687,6 @@ pick_drives() {
687687

688688
default_nums=$(IFS=','; echo "${default_selected[*]}")
689689

690-
# If all drives are green (no yellow), skip the picker entirely.
691-
local has_yellow="false"
692-
for i in "${!dev_paths[@]}"; do
693-
if [ "${is_yellow[$i]}" = "1" ]; then
694-
has_yellow="true"
695-
break
696-
fi
697-
done
698-
699-
if [ "$has_yellow" = "false" ]; then
700-
return
701-
fi
702-
703690
# Display the picker.
704691
echo ""
705692
echo -e " ${BOLD}Drive Scanner${NC}"
@@ -725,9 +712,19 @@ pick_drives() {
725712
done
726713

727714
echo ""
728-
echo " Yellow drives use network storage or unknown transport and may not"
729-
echo " support SMART. They are excluded from the default selection."
730-
echo ""
715+
# Only show yellow explanation if there are yellow drives.
716+
local has_yellow="false"
717+
for i in "${!dev_paths[@]}"; do
718+
if [ "${is_yellow[$i]}" = "1" ]; then
719+
has_yellow="true"
720+
break
721+
fi
722+
done
723+
if [ "$has_yellow" = "true" ]; then
724+
echo " Yellow drives use network storage or unknown transport and may not"
725+
echo " support SMART. They are excluded from the default selection."
726+
echo ""
727+
fi
731728

732729
local range_hint="1"
733730
[ "$count" -gt 1 ] && range_hint="1,2..${count}"

0 commit comments

Comments
 (0)