Skip to content

Feature/4382 publisher dashboard labels#2607

Merged
RK206 merged 2 commits into
developfrom
feature/4382_publisher_dashboard_labels
Jun 24, 2026
Merged

Feature/4382 publisher dashboard labels#2607
RK206 merged 2 commits into
developfrom
feature/4382_publisher_dashboard_labels

Conversation

@brendan-oconnell

@brendan-oconnell brendan-oconnell commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Change My draft Applications to "My Applications" in Publisher Dashboard, add descriptive text about 6 month application processing time

This PR...

  • has scripts to run
  • has migrations to run
  • adds new infrastructure
  • changes the CI pipeline
  • affects the public site
  • affects the editorial area
  • affects the publisher area
  • affects the monitoring

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Project's coding standards are met
    • No deprecated methods are used
    • No magic strings/numbers - all strings are in constants or messages files
    • ES queries are wrapped in a Query object rather than inlined in the code
    • Where possible our common library functions have been used (e.g. dates manipulated via dates)
    • Cleaned up commented out code, etc
    • Urls are constructed with url_for not hard-coded
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested
  • There is a recent merge from develop

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Project's coding standards are met
    • No deprecated methods are used
    • No magic strings/numbers - all strings are in constants or messages files
    • ES queries are wrapped in a Query object rather than inlined in the code
    • Where possible our common library functions have been used (e.g. dates manipulated via dates)
    • Cleaned up commented out code, etc
    • Urls are constructed with url_for not hard-coded
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested
  • There is a recent merge from develop

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run by reviewers

Deployment

What deployment considerations are there? (delete any sections you don't need)

Configuration changes

What configuration changes are included in this PR, and do we need to set specific values for production

Scripts

What scripts need to be run from the PR (e.g. if this is a report generating feature), and when (once, regularly, etc).

Migrations

What migrations need to be run to deploy this

Monitoring

What additional monitoring is required of the application as a result of this feature

New Infrastructure

What new infrastructure does this PR require (e.g. new services that need to run on the back-end).

Continuous Integration

What CI changes are required for this

@brendan-oconnell brendan-oconnell marked this pull request as ready for review June 19, 2026 14:41
@brendan-oconnell brendan-oconnell self-assigned this Jun 19, 2026
@brendan-oconnell

Copy link
Copy Markdown
Contributor Author

@richard-jones as you'll see, this is a very small change to the page text from Editorial. Since the page in the Publisher Dashboard is now "My applications", the file doaj/portality/templates-v2/public/publisher/drafts.html should probably become applications.html

and

<script type="text/javascript" src="/static/js/edges/publisher.mydrafts.edge.js?v={{config.get('DOAJ_VERSION')}}"></script>

should become myapplications.edge, etc.

However, I'm not familiar enough with the codebase to follow through and rename everything, and I'm not sure if it's essential, since the Editorial team may want to change the title of this page again in the future.

@RK206 RK206 merged commit ce52d1a into develop Jun 24, 2026
1 of 2 checks passed
@RK206 RK206 deleted the feature/4382_publisher_dashboard_labels branch June 24, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants