Apply suggestions

Author: bencalegari

app/app/views/launcher/advanced.html.erb

@@ -111,7 +111,8 @@
             <div class="usa-radio">
               <input class="usa-radio__input usa-radio__input--tile" type="radio"
                      name="test_scenario" id="test_scenario_scott" value="scott"
-                     data-action="advanced-launcher#selectScenario">
+                     data-action="advanced-launcher#selectScenario"
+                     data-reporting-window-months="2">
               <label class="usa-radio__label" for="test_scenario_scott">
                 <strong>Scott Tobin</strong>
                 <span class="advanced-launcher__scenario-desc">Not currently enrolled (enrollment older than 18 months)</span>
@@ -120,7 +121,8 @@
             <div class="usa-radio">
               <input class="usa-radio__input usa-radio__input--tile" type="radio"
                      name="test_scenario" id="test_scenario_linda" value="linda"
-                     data-action="advanced-launcher#selectScenario">
+                     data-action="advanced-launcher#selectScenario"
+                     data-reporting-window-months="2">
               <label class="usa-radio__label" for="test_scenario_linda">
                 <strong>Linda Cooper</strong>
                 <span class="advanced-launcher__scenario-desc">No NSC record found</span>

app/spec/controllers/launcher_controller_advanced_spec.rb

@@ -54,6 +54,17 @@
       expect(rendered).to include('Ziggy Testuser')
     end
 
+    it "gives every NSC test scenario a reporting window so selecting one does not leave a stale months pill", :aggregate_failures do
+      get :advanced
+      rendered = response.body
+
+      %w[lynette rick dominique scott linda].each do |scenario_key|
+        radio = rendered[/<input[^>]*id="test_scenario_#{scenario_key}"[^>]*>/]
+        expect(radio).to be_present, "expected a radio for #{scenario_key}"
+        expect(radio).to include('data-reporting-window-months'), "expected #{scenario_key} to set reporting window months"
+      end
+    end
+
     it "displays fake test scenario options with single and multi-term" do
       get :advanced
       rendered = response.body

app/spec/support/nsc_api_helper.rb

@@ -56,10 +56,10 @@ def nsc_load_relative_json_file(user_folder, filename)
     JSON.parse(File.read(nsc_fixture_path(user_folder, filename)))
   end
 
-  # Re-record every fixture against the live NSC sandbox:
+  # Re-record every fixture against the live NSC sandbox, from the repo root:
   #
   # ```
-  # bin/rails runner 'require "./spec/support/nsc_api_helper"; include NscApiHelper; nsc_save_all_fixtures'
+  # cd app && bin/rails runner 'require "./spec/support/nsc_api_helper"; include NscApiHelper; nsc_save_all_fixtures'
   # ```
   def nsc_save_all_fixtures
     FIXTURE_PERSONAS.each_key { |user_folder| nsc_save_fixture_for_user(user_folder) }