chore(deps): runtime go runtime go1.24.4 → go1.26.2 [pkg/dyninst/testprogs/progs]#49792
Conversation
github-actions
Bot
added
the
short review
|
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
dd-octo-sts-98cdbc
Bot
force-pushed
the
engraver-auto-version-upgrade/eol-runtime/go/progs/5-1776955431
branch
from
31bdc27 to
5177a95
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
|
Auto-rebase failedLockfile regeneration failed during rebase onto Error detailschild workflow execution error (type: engraver.Engraver_AllManagersWorkflow, workflowID: 019e8981-46d3-7c7d-bb5e-fa7de52cf4c6_63, runID: 019e8982-0695-7c6b-a525-731b820578d6, initiatedEventID: 63, startedEventID: 64): Child workflow timeout (type: StartToClose) Auto-Rebase · Add |
dd-octo-sts-0c48d7
Bot
force-pushed
the
engraver-auto-version-upgrade/eol-runtime/go/progs/5-1776955431
branch
from
5177a95 to
44da461
Compare
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44da4613d3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,7 @@ | |||
| go 1.25.10 | |||
|
|
|||
| toolchain go1.26.2 | |||
There was a problem hiding this comment.
This update targets pkg/dyninst/testprogs/progs, but adding toolchain go1.26.2 to the root workspace changes toolchain selection for every Go command run from the repository root; the Go toolchain docs state that the current workspace's go.work toolchain line is consulted during startup selection. The dyninst test-program build path explicitly disables the workspace with GOWORK=off because this module is not listed in go.work, so this line does not scope the upgrade to those test programs and instead makes default GOTOOLCHAIN=auto users/CI switch or download Go 1.26.2 for unrelated Agent modules.
Useful? React with 👍 / 👎.
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
dd-octo-sts-019303
Bot
force-pushed
the
engraver-auto-version-upgrade/eol-runtime/go/progs/5-1776955431
branch
from
44da461 to
dcf054c
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcf054cce7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,7 @@ | |||
| go 1.25.10 | |||
|
|
|||
| toolchain go1.26.2 | |||
There was a problem hiding this comment.
When the binary-build jobs run dda inv -- check-go-version (for example in .gitlab/build/binary_build/linux.yml), tasks/go.py compares go version against .go-version, which is still 1.25.10. A toolchain directive in the root go.work is workspace-wide, so with the default GOTOOLCHAIN=auto the go command in the repo root selects/reports go1.26.2 before that check runs (or tries to download it if it is not installed), making those CI jobs fail even though this PR only intended to update the dyninst testprogs module. Please drop the root go.work toolchain change unless .go-version and the repo-wide Go runtime are being updated together.
Useful? React with 👍 / 👎.
github-actions
Bot
added
medium review
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a9bb7db4a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,7 @@ | |||
| go 1.26.4 | |||
|
|
|||
| toolchain go1.26.2 | |||
There was a problem hiding this comment.
In environments that bootstrap with an older Go and GOTOOLCHAIN=path/offline toolchain selection, this explicit toolchain go1.26.2 is consulted before the go 1.26.4 line, so the Go command looks for an exact go1.26.2 binary even when the required go1.26.4 toolchain is installed; without this new line the workspace's implicit toolchain would match go 1.26.4. The Go docs describe this precedence and exact lookup behavior for toolchain lines (https://go.dev/doc/toolchain), so the workspace should either omit this line or set it to go1.26.4 or newer.
Useful? React with 👍 / 👎.
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fdb2d02ef
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,7 @@ | |||
| go 1.26.4 | |||
|
|
|||
| toolchain go1.26.2 | |||
There was a problem hiding this comment.
Adding this toolchain line makes Bazel stop using the workspace's go 1.26.4 as its SDK version: deps/go.MODULE.bazel calls go_sdk.from_file(go_work = "//:go.work"), and rules_go v0.61.1's version_from_go_work returns the toolchain directive when present. On Bazel jobs such as bazel:mod-deps, which re-evaluates the module lock and diffs it, this selects/downloads Go 1.26.2 instead of the repo-pinned 1.26.4, causing lockfile churn/failure and making Bazel builds run on an older patch release than the rest of the repo. Remove the workspace toolchain line or set it to go1.26.4.
Useful? React with 👍 / 👎.
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88463fe292
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,7 @@ | |||
| go 1.26.4 | |||
|
|
|||
| toolchain go1.26.2 | |||
There was a problem hiding this comment.
When the default Go installation is older than 1.26.2, Go's toolchain selection will honor this new toolchain go1.26.2 preference before falling back to the go 1.26.4 line, but the workspace itself requires Go 1.26.4. That can make any root-workspace dda inv/Go invocation fail or require a manual GOTOOLCHAIN override on machines with older Go; set the workspace toolchain to at least go1.26.4 or omit the line.
Useful? React with 👍 / 👎.
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e1bb3ee89
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,7 @@ | |||
| go 1.26.4 | |||
|
|
|||
| toolchain go1.26.2 | |||
There was a problem hiding this comment.
In environments whose default Go is older than 1.26.2, this explicit workspace toolchain line takes precedence over the existing go 1.26.4 line during startup selection, so the repo can select Go 1.26.2 even though the workspace declares 1.26.4 as its minimum. The Go toolchain docs describe go as the minimum required version and the toolchain as the preferred toolchain, with the Go dependency requiring a toolchain dependency of greater-or-equal version; please remove this line or set it to at least go1.26.4 so repo-wide dda inv/Go commands don't downgrade below the workspace requirement.
Useful? React with 👍 / 👎.
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
|
@codex review |
Co-authored-by: dd-octo-sts[bot] <200755185+dd-octo-sts[bot]@users.noreply.github.com>
Co-authored-by: dd-octo-sts[bot] <200755185+dd-octo-sts[bot]@users.noreply.github.com>
Co-authored-by: dd-octo-sts[bot] <200755185+dd-octo-sts[bot]@users.noreply.github.com>
Auto-rebase completeBranch is up to date with Auto-Rebase · Add |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb928b343f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,7 @@ | |||
| go 1.26.4 | |||
|
|
|||
| toolchain go1.26.2 | |||
There was a problem hiding this comment.
In environments whose default go is older than 1.26.4 and use the normal GOTOOLCHAIN=auto behavior, this newly added workspace directive can select go1.26.2 before considering the go 1.26.4 line; the Go toolchain docs state that auto mode consults the toolchain line first and runs it when newer than the default. That conflicts with the workspace's required Go version and .go-version (1.26.4), so repo commands may run the wrong toolchain or fail the version check. Please either omit this line or set it to go1.26.4.
Useful? React with 👍 / 👎.
Summary: Security update — 1 package upgraded (MAJOR changes included)
Manifests changed:
pkg/dyninst/testprogs/progs(go)✅ Action Required: Please review the changes below. If they look good, approve and merge this PR.
Runtime Upgrade
This update includes a go runtime upgrade.
What changed in
go.modThe
toolchaindirective specifies which Go version to use when building this module. Adding it is best practice — it keeps local development in sync with CI and makes the intended Go version explicit. Build systems that manage their own Go installation may ignore this directive.The
toolchaindirective controls only the Go binary used for compilation. Language features remain governed by thegodirective ingo.mod, which the owning team should bump when ready to adopt a newer language version.Updates
Security Details
go1.24.4go1.26.2pkg/dyninst/testprogs/progs/go.modReview Checklist
Standard review:
Update Mode: Runtime EOL Upgrade
🤖 Generated by DataDog Automated Dependency Management System