Skip to content

Default metrics v3 intake to Datadog URLs only#53466

Open
rayz wants to merge 5 commits into
mainfrom
rayz/v3-datadog-only-default
Open

Default metrics v3 intake to Datadog URLs only#53466
rayz wants to merge 5 commits into
mainfrom
rayz/v3-datadog-only-default

Conversation

@rayz

@rayz rayz commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Changes the default for use_v3_api.series.enabled from "true" to "datadog_only".

With this default, metrics use the v3 intake for Datadog URLs, while destinations configured with non-Datadog-looking URLs, such as additional_endpoints and reverse proxies, continue using the v2 series intake unless explicitly opted into v3.

Motivation

additional_endpoints may be configured to destinations that do not support the v3 metrics intake route. With v3 enabled for every destination by default, those endpoints can return 404s.

Describe how you validated your changes

dda inv test --targets=./pkg/serializer

Additional Notes

@rayz rayz added this to the 7.81.1 milestone Jul 9, 2026
@rayz rayz requested review from a team as code owners July 9, 2026 17:00
@rayz rayz requested a review from hush-hush July 9, 2026 17:00
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Jul 9, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Jul 9, 2026
@rayz rayz modified the milestones: 7.81.1, 7.82.0 Jul 9, 2026
@rayz rayz added backport/7.81.x Automatically create a backport PR to the 7.81.x branch once the PR is merged qa/done QA done before merge and regressions are covered by tests labels Jul 9, 2026
Comment on lines +7 to +12
Metric destinations configured with non-Datadog-looking URLs, such as
custom ``additional_endpoints`` and reverse proxies, continue to use the
v2 intake by default. To enable v3 for every destination, set
``use_v3_api.series.enabled: "true"``. To keep using v2 intake, set
``use_v3_api.series.enabled: "false"`` (global) or
``use_v3_api.series.endpoints: { "<url>": "false" }`` (per-endpoint).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like this instruction for folks to opt-in if they want. Could mention the estimated bandwidth savings (~60%) to encourage opting in.

@jszwedko

jszwedko commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Actually, one thought, it seems like the datadog_only pattern is a bit more restrictive than it needs to be:

var ddURLRegexp = regexp.MustCompile(`^app(\.mrf)?\.` + ddSitePattern + `\.?$`)

I think that would preclude customers that have configured dd_url to, for example, their custom subdomain like foo.datadoghq.com (erroneously). For the backport I think this is fine to reduce risk, but we could consider making the check a bit more permissive in the future.

@jszwedko jszwedko added the ask-review Ask in slack required teams to review this PR label Jul 9, 2026
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 51.74% (+0.12%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7ad4370 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor f86c1933:

Results for datadog-agent_7.83.0~devel.git.19.7ad4370.pipeline.124090914-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor f86c193
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 750.390 MiB
agent_deb_amd64_fips 705.418 MiB
agent_heroku_amd64 307.493 MiB
agent_msi 645.033 MiB
agent_rpm_amd64 750.374 MiB
agent_rpm_amd64_fips 705.402 MiB
agent_rpm_arm64 725.410 MiB
agent_rpm_arm64_fips 684.159 MiB
agent_suse_amd64 750.374 MiB
agent_suse_amd64_fips 705.402 MiB
agent_suse_arm64 725.410 MiB
agent_suse_arm64_fips 684.159 MiB
docker_agent_amd64 809.108 MiB
docker_agent_arm64 809.201 MiB
docker_agent_jmx_amd64 1000.006 MiB
docker_agent_jmx_arm64 988.750 MiB
docker_cluster_agent_amd64 209.687 MiB
docker_cluster_agent_arm64 222.765 MiB
docker_cws_instrumentation_amd64 7.447 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.192 MiB
docker_dogstatsd_arm64 37.305 MiB
docker_host_profiler_amd64 302.586 MiB
docker_host_profiler_arm64 314.119 MiB
dogstatsd_deb_amd64 29.927 MiB
dogstatsd_deb_arm64 27.963 MiB
dogstatsd_rpm_amd64 29.927 MiB
dogstatsd_suse_amd64 29.927 MiB
iot_agent_deb_amd64 46.132 MiB
iot_agent_deb_arm64 42.812 MiB
iot_agent_deb_armhf 43.592 MiB
iot_agent_rpm_amd64 46.132 MiB
iot_agent_suse_amd64 46.131 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 9, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 105dbff2-2bfa-4737-8823-80bc2777af05

Baseline: f86c193
Comparison: 7ad4370
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.48 [+0.49, +2.46] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +1.23 [+1.18, +1.28] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.93 [+0.89, +0.97] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.82 [+0.78, +0.86] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.73 [+0.48, +0.97] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.61 [+0.52, +0.71] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.36 [+0.30, +0.43] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 148.57MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 730.20KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 488.86MiB ≤ 495MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 179.83MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.15MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 360.95 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 406.34MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.93GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 29.64 ≤ 40 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 296.42MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 63.92 ≤ 80 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 274.81MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 26.50 ≤ 40 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 283.84MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_mean_fs_load baseline 10 Oom killed Debug Dashboard
quality_gate_security_mean_fs_load comparison 10 Oom killed Debug Dashboard
quality_gate_security_no_fs_load baseline 10 Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

@rayz rayz requested a review from a team as a code owner July 9, 2026 19:40
@rayz rayz force-pushed the rayz/v3-datadog-only-default branch from 706796f to 72a1f64 Compare July 9, 2026 22:10
@rayz rayz requested a review from a team as a code owner July 9, 2026 22:10
@rayz rayz requested review from RiantZ and removed request for a team July 9, 2026 22:10
@jszwedko

jszwedko commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

/merge -m squash

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 9, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-09 23:17:04 UTC ℹ️ Start processing command /merge -m squash


2026-07-09 23:17:14 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-07-10 03:28:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@rayz

rayz commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/merge -m squash

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 10, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-10 13:42:19 UTC ℹ️ Start processing command /merge -m squash


2026-07-10 13:42:25 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 4h (p90).


2026-07-10 15:37:51 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.


2026-07-10 17:41:03 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.


2026-07-10 19:04:32 UTCMergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for fd22648:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@rayz rayz added the backport/7.82.x Automatically create a backport PR to the 7.82.x branch once the PR is merged label Jul 10, 2026
@rayz

rayz commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/merge -m squash

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 10, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-10 19:16:38 UTC ℹ️ Start processing command /merge -m squash
Use /merge -c to cancel this operation!


2026-07-10 19:16:45 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!


2026-07-10 21:03:09 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 4h (p90).

Use /merge -c to cancel this operation!


2026-07-11 02:12:03 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.
Use /merge -c to cancel this operation!


⏳ waiting for a build ahead of yours to finish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask in slack required teams to review this PR backport/7.81.x Automatically create a backport PR to the 7.81.x branch once the PR is merged backport/7.82.x Automatically create a backport PR to the 7.82.x branch once the PR is merged internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-configuration team/agent-devx team/agent-metric-pipelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants