Merge pull request #507 from DelegoLabs/chore/ci-tests-pass

fix(lint): resolve all eslint warnings

Author: ScriptedBro

.github/workflows/ci.yml

@@ -6,6 +6,10 @@ on:
   pull_request:
     branches: [main]
 
+permissions:
+  packages: read
+  contents: read
+
 concurrency:
   group: ci-${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
@@ -38,7 +42,7 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
         env:
-          NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN || secrets.GITHUB_TOKEN }}
 
       - name: Run linter
         run: pnpm lint
@@ -65,7 +69,7 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
         env:
-          NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN || secrets.GITHUB_TOKEN }}
 
       - name: Build shared packages
         run: pnpm --filter "./packages/*" --filter "./apps/frontend" build
@@ -96,7 +100,7 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
         env:
-          NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN || secrets.GITHUB_TOKEN }}
 
       - name: Build shared packages
         run: pnpm --filter "./packages/*" --filter "./apps/frontend" build
@@ -127,7 +131,7 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
         env:
-          NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN || secrets.GITHUB_TOKEN }}
 
       - name: Build project
         run: pnpm build
@@ -154,7 +158,7 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
         env:
-          NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN || secrets.GITHUB_TOKEN }}
 
       - name: Run audit
         run: pnpm audit --prod --audit-level=high

apps/frontend/components/delegations/DelegationQR.test.tsx

@@ -1,7 +1,6 @@
 import React from "react";
 import { describe, it, expect, vi, beforeEach } from "vitest";
 import { render, screen, waitFor } from "@testing-library/react";
-import userEvent from "@testing-library/user-event";
 import { DelegationQR } from "./DelegationQR";
 
 vi.mock("qrcode", () => ({

apps/frontend/components/delegations/DelegationQR.tsx

@@ -124,6 +124,7 @@ export function DelegationQR({
         Delegation QR Code
       </h3>
       {qrDataUrl && (
+        // eslint-disable-next-line @next/next/no-img-element -- QR code is a data URL; next/image optimization is unnecessary
         <img
           src={qrDataUrl}
           alt="Delegation QR Code"

apps/frontend/components/onboarding/OnboardingStep.tsx

@@ -1,6 +1,5 @@
 "use client";
 
-import { useState } from "react";
 import { Card, Button } from "@delegolabs/ui";
 
 export interface OnboardingStepProps {

apps/frontend/hooks/useDelegations.ts

@@ -165,7 +165,7 @@ export function useDelegations(): UseDelegationsResult {
         return null;
       }
     },
-    []
+    [setPending]
   );
 
   const updateDelegation = useCallback(
@@ -205,7 +205,7 @@ export function useDelegations(): UseDelegationsResult {
         return null;
       }
     },
-    [delegations]
+    [delegations, setPending]
   );
 
   const revokeDelegation = useCallback(
@@ -231,7 +231,7 @@ export function useDelegations(): UseDelegationsResult {
         return false;
       }
     },
-    [delegations]
+    [delegations, setPending]
   );
 
   useEffect(() => {

apps/frontend/tests/EscrowCard.test.tsx

@@ -1,4 +1,4 @@
-import { describe, it, expect, vi, beforeEach } from "vitest";
+import { describe, it, expect } from "vitest";
 import { render, screen } from "@testing-library/react";
 import { EscrowCard } from "../components/escrows/EscrowCard";
 import type { Escrow } from "@delegolabs/types";