[Fix] ReflectionExtensions Performance Improvments (BrighterCommand#3991)

* add ReflectionExtensions tests

and make Paramore.Brighter InternalsVisibleTo  to Paramore.Brighter.Core.Tests

* Update ReflectionExtensionsTests.cs

* Update ReflectionExtensions.cs

* Update ReflectionExtensions.cs

* more tests and simplify ReflectionExtensions

* .

---------

Co-authored-by: Ian Cooper <ian_hammond_cooper@yahoo.co.uk>

Author: 2 people

src/Paramore.Brighter/Extensions/ReflectionExtensions.cs

@@ -22,9 +22,7 @@ THE SOFTWARE. */
 
 #endregion
 
-using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Reflection;
 using Paramore.Brighter.Inbox.Attributes;
 
@@ -33,50 +31,19 @@ namespace Paramore.Brighter.Extensions
     internal static class ReflectionExtensions
     {
         internal static IEnumerable<RequestHandlerAttribute> GetOtherHandlersInPipeline(this MethodInfo targetMethod)
-        {
-            var customAttributes = targetMethod.GetCustomAttributes(true);
-            return customAttributes
-                .Select(attr => (Attribute) attr)
-                .Where(a => a.GetType().BaseType == typeof (RequestHandlerAttribute))
-                .Cast<RequestHandlerAttribute>()
-                .ToList();
-        }
+            => targetMethod.GetCustomAttributes<RequestHandlerAttribute>(true);
 
         internal static IEnumerable<WrapWithAttribute> GetOtherWrapsInPipeline(this MethodInfo targetMethod)
-        {
-            var customAttributes = targetMethod.GetCustomAttributes(true);
-            return customAttributes
-                .Select(attr => (Attribute) attr)
-                .Where(a => a.GetType().BaseType == typeof (WrapWithAttribute))
-                .Cast<WrapWithAttribute>()
-                .ToList();
-        }
-        
+            => targetMethod.GetCustomAttributes<WrapWithAttribute>(true);
+
         internal static IEnumerable<UnwrapWithAttribute> GetOtherUnwrapsInPipeline(this MethodInfo targetMethod)
-        {
-            var customAttributes = targetMethod.GetCustomAttributes(true);
-            return customAttributes
-                .Select(attr => (Attribute) attr)
-                .Where(a => a.GetType().BaseType == typeof (UnwrapWithAttribute))
-                .Cast<UnwrapWithAttribute>()
-                .ToList();
-        } 
-        
+            => targetMethod.GetCustomAttributes<UnwrapWithAttribute>(true);
+
         internal static bool HasNoInboxAttributesInPipeline(this MethodInfo targetMethod)
-        {
-             var customAttributes = targetMethod.GetCustomAttributes(true);
-             return customAttributes
-                .Select(attr => (Attribute) attr)
-                .Any(a => a.GetType() == typeof (NoGlobalInboxAttribute));
-        }
+            => targetMethod.IsDefined(typeof(NoGlobalInboxAttribute), true);
 
         internal static bool HasExistingUseInboxAttributesInPipeline(this MethodInfo targetMethod)
-        {
-              var customAttributes = targetMethod.GetCustomAttributes(true);
-              return customAttributes
-                .Select(attr => (Attribute) attr)
-                .Any(a => a.GetType() == typeof (UseInboxAttribute)
-                          || a.GetType() == typeof (UseInboxAsyncAttribute));
-        }
+            => targetMethod.IsDefined(typeof(UseInboxAttribute), true)
+               || targetMethod.IsDefined(typeof(UseInboxAsyncAttribute), true);
     }
 }