fix: Navigation Bar Custom bugs

Author: choubeyaditya80

.fvmrc

@@ -18,10 +18,7 @@ migrate_working_dir/
 *.iws
 .idea/
 
-# The .vscode folder contains launch configuration and tasks you configure in
-# VS Code which you may wish to be included in version control, so this line
-# is commented out by default.
-#.vscode/
+.vscode/
 
 # Flutter/Dart/Pub related
 **/doc/api/
@@ -47,12 +44,12 @@ app.*.map.json
 android/local.properties
 /android/local.properties
 pubspec.lock
-.vscode/launch.json
 example/ios/Podfile.lock
 macos/Podfile.lock
 
-# FVM Version Cache
-.fvm/
-
-ios/Flutter/flutter_export_environment.sh
-ios/Flutter/Generated.xcconfig
+# Flutter tool output (flutter pub get); nested example/*/.gitignore also lists these
+**/ios/Flutter/Generated.xcconfig
+**/ios/Flutter/flutter_export_environment.sh
+**/Runner/GeneratedPluginRegistrant.h
+**/Runner/GeneratedPluginRegistrant.m
+**/io/flutter/plugins/GeneratedPluginRegistrant.java

.gitignore

@@ -39,29 +39,6 @@ class BottomNavigationBar extends StatefulWidget {
 }
 
 class _BottomNavigationBarState extends State<BottomNavigationBar> {
-  late int _selectedIndex;
-
-  @override
-  void initState() {
-    super.initState();
-    _selectedIndex = widget.selectedIndex;
-  }
-
-  @override
-  void didUpdateWidget(BottomNavigationBar oldWidget) {
-    if (widget.selectedIndex != oldWidget.selectedIndex) {
-      _selectedIndex = widget.selectedIndex;
-    }
-    super.didUpdateWidget(oldWidget);
-  }
-
-  void _handleDestinationSelected(int index) {
-    _selectedIndex = index;
-    if (widget.onDestinationSelected != null) {
-      widget.onDestinationSelected!(index);
-    }
-  }
-
   @override
   Widget build(BuildContext context) {
     return DecoratedBox(
@@ -72,8 +49,8 @@ class _BottomNavigationBarState extends State<BottomNavigationBar> {
           backgroundColor: widget.backgroundColor,
           animationDuration: widget.animationDuration,
           elevation: widget.elevation,
-          selectedIndex: _selectedIndex,
-          onDestinationSelected: _handleDestinationSelected,
+          selectedIndex: widget.selectedIndex,
+          onDestinationSelected: widget.onDestinationSelected,
           surfaceTintColor: widget.surfaceTintColor,
           indicatorColor: widget.indicatorColor,
           indicatorShape: widget.indicatorShape,

.vscode/settings.json

@@ -34,13 +34,19 @@ class VWNavigationBarCustom
   ) {
     if (index >= 0 && index < visibleChildren.length) {
       final selectedChild = visibleChildren[index];
-      final onPageSelected = selectedChild.props.onSelect;
-      final onPageSelectedAction = onPageSelected?['action'];
-      if (onPageSelectedAction != null) {
-        payload.executeAction(
-          ActionFlow.fromJson(onPageSelectedAction),
-          triggerType: 'onPageSelected',
-        );
+      final onSelect = selectedChild.props.onSelect;
+      final type = onSelect?['type'] as String?;
+
+      if (type == 'action') {
+        final action = onSelect?['action'];
+        if (action != null) {
+          payload.executeAction(
+            ActionFlow.fromJson(action),
+            triggerType: 'onNavBarItemSelected',
+          );
+        }
+        // Action-type items execute their action but do not change the selected tab.
+        return;
       }
     }
     onDestinationSelected?.call(index);
@@ -55,7 +61,11 @@ class VWNavigationBarCustom
       destinations.add(
         InheritedNavigationBarController(
           itemIndex: i,
-          child: navItems[i].toWidget(payload),
+          child: Builder(
+            builder: (context) => navItems[i].toWidget(
+              payload.copyWith(buildContext: context),
+            ),
+          ),
         ),
       );
     }