address some reviews

Author: trangdoan982

apps/roam/src/components/AdvancedNodeSearchDialog/index.tsx

@@ -38,10 +38,6 @@ import {
 
 type Props = Record<string, unknown>;
 
-const focusSearchInput = (input: HTMLInputElement | null): void => {
-  input?.focus();
-};
-
 const getNodeBadgeText = (node: DiscourseNode): string =>
   (node.tag?.trim() || node.text).slice(0, 3).toUpperCase();
 
@@ -182,7 +178,6 @@ const AdvancedNodeSearchDialog = ({
     SearchResult & { id: string }
   > | null>(null);
   const allResultsRef = useRef<SearchResult[]>([]);
-  const visibleResultsRef = useRef<SearchResult[]>([]);
   const contentCacheRef = useRef<Map<string, NodeContent>>(new Map());
   const resultsPanelRef = useRef<HTMLDivElement | null>(null);
   const inputRef = useRef<HTMLInputElement | null>(null);
@@ -197,7 +192,7 @@ const AdvancedNodeSearchDialog = ({
   useEffect(() => {
     if (!isOpen) return;
 
-    const focusInput = () => focusSearchInput(inputRef.current);
+    const focusInput = () => inputRef.current?.focus();
 
     focusInput();
     const rafId = requestAnimationFrame(focusInput);
@@ -219,7 +214,6 @@ const AdvancedNodeSearchDialog = ({
       setIndexError(false);
       miniSearchRef.current = null;
       allResultsRef.current = [];
-      visibleResultsRef.current = [];
       contentCacheRef.current.clear();
       return;
     }
@@ -273,7 +267,6 @@ const AdvancedNodeSearchDialog = ({
 
     const query = debouncedSearchTerm;
     if (!query || !miniSearchRef.current) {
-      visibleResultsRef.current = [];
       setResults([]);
       setActiveIndex(0);
       setPreviewContent(null);
@@ -285,7 +278,6 @@ const AdvancedNodeSearchDialog = ({
       allResults: allResultsRef.current,
       searchTerm: query,
     });
-    visibleResultsRef.current = matchedResults;
 
     if (!matchedResults.length) {
       setResults([]);

apps/roam/src/components/AdvancedNodeSearchDialog/utils.ts

@@ -13,7 +13,6 @@ import {
 
 export const DEBOUNCE_MS = 250;
 export const MAX_RESULTS = 50;
-export const MIN_SEARCH_SCORE = DISCOURSE_NODE_MIN_SEARCH_SCORE;
 export const EXCERPT_LENGTH = 200;
 
 export type SearchResult = {
@@ -202,7 +201,7 @@ export const searchIndexedNodes = ({
       fields: ["title", "nodeTypeLabel"],
       ...DISCOURSE_NODE_MINI_SEARCH_OPTIONS,
     })
-    .filter((result) => result.score > MIN_SEARCH_SCORE)
+    .filter((result) => result.score > DISCOURSE_NODE_MIN_SEARCH_SCORE)
     .slice(0, MAX_RESULTS)
     .map((result) => resultsByUid.get(String(result.id)))
     .filter((result): result is SearchResult => !!result);

apps/roam/src/components/DiscourseNodeSearchMenu.tsx

@@ -173,7 +173,7 @@ const NodeSearchMenu = ({
       });
 
       const filteredResults = rawSearchResults.filter(
-        (r) => r.score > MIN_SEARCH_SCORE,
+        (r) => r.score > DISCOURSE_NODE_MIN_SEARCH_SCORE,
       );
 
       const searchResults = (