Optimize graph command recording fan-out

Author: DoubleStyx

crates/renderide/src/backend/asset_transfers/video_runtime.rs

@@ -28,11 +28,19 @@ impl VideoAssetRuntime {
     }
 
     /// Starts shutdown for an unloaded player and keeps it alive until the worker joins.
+    #[cfg(feature = "video-textures")]
     pub(crate) fn retire_player(&mut self, mut player: VideoPlayer) {
         player.begin_shutdown();
         self.retiring_video_players.push(player);
     }
 
+    /// Starts shutdown for an unloaded player and keeps it alive until the worker joins.
+    #[cfg(not(feature = "video-textures"))]
+    pub(crate) fn retire_player(&mut self, player: VideoPlayer) {
+        player.begin_shutdown();
+        self.retiring_video_players.push(player);
+    }
+
     /// Polls unloaded players and drops only those whose worker has fully shut down.
     pub(crate) fn poll_retiring_players(&mut self) {
         self.retiring_video_players

crates/renderide/src/backend/facade.rs

@@ -224,6 +224,15 @@ impl RenderBackend {
             .unwrap_or_default()
     }
 
+    /// Snapshot of the live command-recording mode for the current frame.
+    fn command_recording_mode(&self) -> crate::config::CommandRecordingMode {
+        self.renderer_settings
+            .as_ref()
+            .and_then(|h| h.read().ok())
+            .map(|s| s.debug.command_recording)
+            .unwrap_or_default()
+    }
+
     /// Snapshot of the live experimental renderer settings.
     pub(crate) fn experimental_settings(&self) -> crate::config::ExperimentalSettings {
         self.renderer_settings
@@ -535,6 +544,7 @@ impl RenderBackend {
         let gpu_limits = self.gpu_limits().cloned();
         let msaa_depth_resolve = self.frame_services.msaa_depth_resolve();
         let live_post_processing = self.live_post_processing_settings();
+        let command_recording_mode = self.command_recording_mode();
         let wall_frame_time_ms = self.debug_frame_time_ms();
         let skin_weight_mode = self.skin_weight_mode();
         let (transient_pool, history_registry, upload_arena, latest_upload_stats) =
@@ -560,6 +570,7 @@ impl RenderBackend {
             msaa_depth_resolve,
             skin_weight_mode,
             live_post_processing,
+            command_recording_mode,
             wall_frame_time_ms,
         }
     }

crates/renderide/src/backend/facade/graph_access.rs

@@ -86,6 +86,8 @@ pub(crate) struct BackendGraphAccess<'a> {
     pub(super) skin_weight_mode: crate::shared::SkinWeightMode,
     /// Live post-processing settings seeded into per-view blackboards.
     pub(super) live_post_processing: LivePostProcessingSettings,
+    /// Live command-recording mode selected before graph execution borrows backend fields.
+    pub(super) command_recording_mode: crate::config::CommandRecordingMode,
     /// Wall-frame delta snapshot in milliseconds.
     pub(super) wall_frame_time_ms: f64,
 }
@@ -218,6 +220,11 @@ impl<'a> BackendGraphAccess<'a> {
         self.debug_hud.has_visible_content()
     }
 
+    /// Render-graph command-recording mode selected for this frame.
+    pub(crate) fn command_recording_mode(&self) -> crate::config::CommandRecordingMode {
+        self.command_recording_mode
+    }
+
     /// Encodes the debug HUD overlay.
     pub(crate) fn encode_debug_hud_overlay(
         &mut self,
@@ -376,6 +383,10 @@ impl GraphExecutionBackend for BackendGraphAccess<'_> {
         BackendGraphAccess::per_view_hud_config(self)
     }
 
+    fn command_recording_mode(&self) -> crate::config::CommandRecordingMode {
+        BackendGraphAccess::command_recording_mode(self)
+    }
+
     fn debug_hud_has_visible_content(&self) -> bool {
         BackendGraphAccess::debug_hud_has_visible_content(self)
     }

crates/renderide/src/config.rs

@@ -62,7 +62,7 @@ pub use persist::{
 #[cfg(test)]
 pub(crate) use persist::{ConfigResolveOutcome, ConfigSource};
 pub use types::{
-    AutoExposureSettings, BloomCompositeMode, BloomSettings, DebugHudMainTab,
+    AutoExposureSettings, BloomCompositeMode, BloomSettings, CommandRecordingMode, DebugHudMainTab,
     DebugHudMainTabVisibility, DebugHudRendererConfigTab, DebugHudRendererConfigTabVisibility,
     DebugHudSettings, ExperimentalSettings, GTAO_MAX_DENOISE_PASSES, GTAO_MAX_QUALITY_LEVEL,
     GTAO_MAX_RESOLUTION_DIVISOR, GTAO_MAX_SLICE_COUNT, GTAO_MAX_STEPS_PER_SLICE,

crates/renderide/src/config/types.rs

@@ -14,7 +14,7 @@ mod watchdog;
 
 pub use crate::render_graph::RenderGraphValidationMode;
 pub use debug::{
-    DebugHudMainTab, DebugHudMainTabVisibility, DebugHudRendererConfigTab,
+    CommandRecordingMode, DebugHudMainTab, DebugHudMainTabVisibility, DebugHudRendererConfigTab,
     DebugHudRendererConfigTabVisibility, DebugHudSettings, DebugSettings, PowerPreferenceSetting,
 };
 pub use display::DisplaySettings;

crates/renderide/src/config/types/debug.rs

@@ -6,10 +6,12 @@
 //! - [`settings`]: the `[debug]` table struct that aggregates the master toggles plus the HUD
 //!   state.
 
+mod command_recording;
 mod hud;
 mod power_preference;
 mod settings;
 
+pub use command_recording::CommandRecordingMode;
 pub use hud::{
     DebugHudMainTab, DebugHudMainTabVisibility, DebugHudRendererConfigTab,
     DebugHudRendererConfigTabVisibility, DebugHudSettings,

crates/renderide/src/config/types/debug/settings.rs

@@ -2,7 +2,7 @@
 
 use serde::{Deserialize, Serialize};
 
-use super::{DebugHudSettings, PowerPreferenceSetting};
+use super::{CommandRecordingMode, DebugHudSettings, PowerPreferenceSetting};
 use crate::render_graph::RenderGraphValidationMode;
 
 /// Debug and diagnostics flags. Persisted as `[debug]`.
@@ -51,6 +51,9 @@ pub struct DebugSettings {
     /// Render-graph declaration and runtime validation policy.
     #[serde(default)]
     pub render_graph_validation: RenderGraphValidationMode,
+    /// Render-graph command-recording strategy override for profiling and diagnostics.
+    #[serde(default)]
+    pub command_recording: CommandRecordingMode,
 }
 
 impl Default for DebugSettings {
@@ -66,6 +69,7 @@ impl Default for DebugSettings {
             debug_hud_links: true,
             hud: DebugHudSettings::default(),
             render_graph_validation: RenderGraphValidationMode::default(),
+            command_recording: CommandRecordingMode::default(),
         }
     }
 }

crates/renderide/src/diagnostics/hud/windows/renderer_config/debug.rs

@@ -1,8 +1,8 @@
 //! Debug, diagnostics, and watchdog renderer-config HUD controls.
 
 use crate::config::{
-    DebugHudSettings, PowerPreferenceSetting, RenderGraphValidationMode, RendererSettings,
-    WatchdogAction,
+    CommandRecordingMode, DebugHudSettings, PowerPreferenceSetting, RenderGraphValidationMode,
+    RendererSettings, WatchdogAction,
 };
 
 use super::controls::{drag_f32_slider_setting, drag_u32_slider_setting};
@@ -109,6 +109,21 @@ fn debug_diagnostics_section(ui: &imgui::Ui, g: &mut RendererSettings, dirty: &m
         }
     }
     ui.text_disabled("Warn logs declaration/runtime issues; Strict turns them into graph errors.");
+    ui.text_disabled("Command recording");
+    for (i, &mode) in CommandRecordingMode::ALL.iter().enumerate() {
+        let _id = ui.push_id_int(700 + i as i32);
+        if ui
+            .selectable_config(mode.label())
+            .selected(g.debug.command_recording == mode)
+            .build()
+        {
+            g.debug.command_recording = mode;
+            *dirty = true;
+        }
+    }
+    ui.text_disabled(
+        "Auto is conservative; other modes are profiling overrides applied next frame.",
+    );
     ui.text_disabled("Power preference (applies at next renderer launch)");
     for (i, &pref) in PowerPreferenceSetting::ALL.iter().enumerate() {
         let _id = ui.push_id_int(i as i32);

crates/renderide/src/profiling/plots/command_encoding.rs

@@ -14,6 +14,18 @@ pub struct CommandEncodingProfileSample {
     pub command_buffers: usize,
     /// Command recording path selected by the graph executor.
     pub recording_path: u64,
+    /// Command recording strategy selected by the graph executor.
+    pub recording_strategy: u64,
+    /// Requested command recording mode from renderer config.
+    pub requested_recording_mode: u64,
+    /// Estimated draw count visible to per-view command recording.
+    pub estimated_per_view_draw_count: usize,
+    /// Estimated draw-equivalent work visible to per-view command recording diagnostics.
+    pub estimated_per_view_record_work: usize,
+    /// Whether automatic per-view recording would have used Rayon.
+    pub auto_per_view_record_admitted: u64,
+    /// Whether the effective per-view recording plan uses Rayon.
+    pub per_view_record_admitted: u64,
     /// Frame-global pass count in the compiled schedule.
     pub frame_global_passes: usize,
     /// Per-view pass count in the compiled schedule.
@@ -127,6 +139,30 @@ fn plot_pass_counts(sample: &CommandEncodingProfileSample) {
         "command_encoding::recording_path",
         sample.recording_path as f64
     );
+    tracy_plot!(
+        "command_encoding::recording_strategy",
+        sample.recording_strategy as f64
+    );
+    tracy_plot!(
+        "command_encoding::requested_recording_mode",
+        sample.requested_recording_mode as f64
+    );
+    tracy_plot!(
+        "command_encoding::estimated_per_view_draw_count",
+        sample.estimated_per_view_draw_count as f64
+    );
+    tracy_plot!(
+        "command_encoding::estimated_per_view_record_work",
+        sample.estimated_per_view_record_work as f64
+    );
+    tracy_plot!(
+        "command_encoding::auto_per_view_record_admitted",
+        sample.auto_per_view_record_admitted as f64
+    );
+    tracy_plot!(
+        "command_encoding::per_view_record_admitted",
+        sample.per_view_record_admitted as f64
+    );
     tracy_plot!(
         "command_encoding::frame_global_passes",
         sample.frame_global_passes as f64

crates/renderide/src/render_graph/builder.rs

@@ -467,6 +467,7 @@ impl GraphBuilder {
         for (idx, entry) in self.passes.iter_mut().enumerate() {
             let id = PassId(idx);
             let name = entry.pass.name().to_string();
+            let profiling_label = entry.pass.profiling_label().into_owned();
             let mut builder = PassBuilder::new(&name);
             entry
                 .pass
@@ -497,6 +498,7 @@ impl GraphBuilder {
             setups.push(SetupEntry {
                 group: entry.group,
                 name,
+                profiling_label,
                 setup,
             });
         }