fix ci

Author: DrBlury

.golangci.yml

@@ -68,6 +68,10 @@ linters:
       - linters:
           - goconst
         path: (.+)_test\.go
+      - linters:
+          - funlen
+          - gocyclo
+        path: (.+)_test\.go
     paths:
       - third_party$
       - builtin$

internal/runtime/cloudevents/event_test.go

@@ -172,7 +172,7 @@ func TestGetExtensionBool(t *testing.T) {
 func TestGetExtensionTime(t *testing.T) {
 	evt := New("test.event", "test-source", nil)
 	testTime := time.Now().UTC()
-	
+
 	// Test with time.Time
 	evt.Extensions["time_key"] = testTime
 	value := evt.GetExtensionTime("time_key")
@@ -304,7 +304,7 @@ func TestEventClone(t *testing.T) {
 func TestEventMarshalJSON(t *testing.T) {
 	subject := "test-subject"
 	contentType := "application/json"
-	
+
 	evt := Event{
 		SpecVersion:     SpecVersion,
 		Type:            "test.event",
@@ -377,7 +377,7 @@ func TestEventUnmarshalJSON_MissingRequired(t *testing.T) {
 	err := evt.UnmarshalJSON([]byte(jsonData))
 	// UnmarshalJSON doesn't validate required fields, so no error
 	assert.NoError(t, err)
-	
+
 	// But Validate should catch missing required fields
 	err = evt.Validate()
 	assert.Error(t, err)
@@ -386,7 +386,7 @@ func TestEventUnmarshalJSON_MissingRequired(t *testing.T) {
 func TestEventRoundTrip(t *testing.T) {
 	subject := "test-subject"
 	contentType := "application/json"
-	
+
 	original := Event{
 		SpecVersion:     SpecVersion,
 		Type:            "test.event",

internal/runtime/cloudevents/time_test.go

@@ -113,10 +113,10 @@ func TestFormatTime_NonUTC(t *testing.T) {
 	require.NoError(t, err)
 	testTime := time.Date(2024, 1, 1, 12, 30, 45, 0, loc)
 	formatted := FormatTime(testTime)
-	
+
 	// Should be in UTC
 	assert.Contains(t, formatted, "Z")
-	
+
 	// Parse it back to verify
 	parsed, err := time.Parse(time.RFC3339, formatted)
 	require.NoError(t, err)

internal/runtime/handlers/context_test.go

@@ -16,14 +16,14 @@ func TestMessageContextBase_Get(t *testing.T) {
 		"key1": "value1",
 		"key2": "value2",
 	}
-	
+
 	logger := loggingpkg.NewSlogServiceLogger(slog.New(slog.NewTextHandler(io.Discard, nil)))
-	
+
 	ctx := MessageContextBase{
 		Metadata: metadata,
 		Logger:   logger,
 	}
-	
+
 	assert.Equal(t, "value1", ctx.Get("key1"))
 	assert.Equal(t, "value2", ctx.Get("key2"))
 	assert.Equal(t, "", ctx.Get("nonexistent"))
@@ -48,9 +48,9 @@ func TestMessageContextBase_CorrelationID(t *testing.T) {
 			want:     "",
 		},
 	}
-	
+
 	logger := loggingpkg.NewSlogServiceLogger(slog.New(slog.NewTextHandler(io.Discard, nil)))
-	
+
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			ctx := MessageContextBase{
@@ -67,24 +67,24 @@ func TestMessageContextBase_CloneMetadata(t *testing.T) {
 		"key1": "value1",
 		"key2": "value2",
 	}
-	
+
 	logger := loggingpkg.NewSlogServiceLogger(slog.New(slog.NewTextHandler(io.Discard, nil)))
-	
+
 	ctx := MessageContextBase{
 		Metadata: original,
 		Logger:   logger,
 	}
-	
+
 	cloned := ctx.CloneMetadata()
-	
+
 	// Verify clone has same values
 	assert.Equal(t, "value1", cloned["key1"])
 	assert.Equal(t, "value2", cloned["key2"])
-	
+
 	// Modify clone
 	cloned["key1"] = "modified"
 	cloned["key3"] = "new"
-	
+
 	// Verify original is unchanged
 	assert.Equal(t, "value1", ctx.Metadata["key1"])
 	assert.Equal(t, "", ctx.Metadata["key3"])

internal/runtime/service_test.go

@@ -8,7 +8,6 @@ import (
 	"testing"
 	"time"
 
-	"github.com/stretchr/testify/require"
 	"github.com/ThreeDotsLabs/watermill"
 	"github.com/ThreeDotsLabs/watermill-amqp/v3/pkg/amqp"
 	"github.com/ThreeDotsLabs/watermill-aws/sns"
@@ -567,58 +566,58 @@ func TestGetErrorClassifier_NilClassifier(t *testing.T) {
 }
 
 func TestService_Publish(t *testing.T) {
-t.Run("nil service", func(t *testing.T) {
-var svc *Service
-err := svc.Publish(context.Background(), "test.topic", nil)
-if err == nil {
-t.Fatal("expected error for nil service")
-}
-})
+	t.Run("nil service", func(t *testing.T) {
+		var svc *Service
+		err := svc.Publish(context.Background(), "test.topic", nil)
+		if err == nil {
+			t.Fatal("expected error for nil service")
+		}
+	})
 
-t.Run("nil publisher", func(t *testing.T) {
-svc := &Service{}
-err := svc.Publish(context.Background(), "test.topic", nil)
-if err == nil {
-t.Fatal("expected error for nil publisher")
-}
-})
+	t.Run("nil publisher", func(t *testing.T) {
+		svc := &Service{}
+		err := svc.Publish(context.Background(), "test.topic", nil)
+		if err == nil {
+			t.Fatal("expected error for nil publisher")
+		}
+	})
 
-t.Run("empty topic", func(t *testing.T) {
-svc := &Service{
-publisher: &testPublisher{},
-}
-err := svc.Publish(context.Background(), "", nil)
-if err == nil {
-t.Fatal("expected error for empty topic")
-}
-})
+	t.Run("empty topic", func(t *testing.T) {
+		svc := &Service{
+			publisher: &testPublisher{},
+		}
+		err := svc.Publish(context.Background(), "", nil)
+		if err == nil {
+			t.Fatal("expected error for empty topic")
+		}
+	})
 
-t.Run("successful publish", func(t *testing.T) {
-pub := &testPublisher{}
-svc := &Service{
-publisher: pub,
-}
-msg := message.NewMessage("test-id", []byte("test"))
-err := svc.Publish(context.Background(), "test.topic", msg)
-if err != nil {
-t.Fatalf("unexpected error: %v", err)
-}
-})
+	t.Run("successful publish", func(t *testing.T) {
+		pub := &testPublisher{}
+		svc := &Service{
+			publisher: pub,
+		}
+		msg := message.NewMessage("test-id", []byte("test"))
+		err := svc.Publish(context.Background(), "test.topic", msg)
+		if err != nil {
+			t.Fatalf("unexpected error: %v", err)
+		}
+	})
 
-t.Run("publishes with context", func(t *testing.T) {
-pub := &testPublisher{}
-svc := &Service{
-publisher: pub,
-}
-ctx := context.Background()
-msg := message.NewMessage("test-id", []byte("test"))
-err := svc.Publish(ctx, "test.topic", msg)
-if err != nil {
-t.Fatalf("unexpected error: %v", err)
-}
-// Message should have context set
-if msg.Context() == nil {
-t.Fatal("expected message to have context set")
-}
-})
+	t.Run("publishes with context", func(t *testing.T) {
+		pub := &testPublisher{}
+		svc := &Service{
+			publisher: pub,
+		}
+		ctx := context.Background()
+		msg := message.NewMessage("test-id", []byte("test"))
+		err := svc.Publish(ctx, "test.topic", msg)
+		if err != nil {
+			t.Fatalf("unexpected error: %v", err)
+		}
+		// Message should have context set
+		if msg.Context() == nil {
+			t.Fatal("expected message to have context set")
+		}
+	})
 }

internal/runtime/transport/capabilities_test.go

@@ -10,13 +10,13 @@ func TestGetCapabilities(t *testing.T) {
 	// Test that GetCapabilities returns capabilities for known transports
 	// The actual values come from the registry after the transports register themselves
 	tests := []string{"channel", "kafka", "rabbitmq", "nats", "jetstream", "aws", "http", "io", "sqlite", "postgres"}
-	
+
 	for _, transportName := range tests {
 		t.Run(transportName, func(t *testing.T) {
 			caps := GetCapabilities(transportName)
 			// Just verify we get capabilities back with the name set
 			assert.NotNil(t, caps)
-			// The transport may or may not be registered in tests, 
+			// The transport may or may not be registered in tests,
 			// so we just check the function works
 		})
 	}

internal/runtime/transport/factory_test.go

@@ -30,7 +30,7 @@ func TestDefaultFactory_Build_Channel(t *testing.T) {
 	// being imported and registered via their init() functions. The factory.go file
 	// imports all transports with _ "github.com/drblury/protoflow/transport/..."
 	// which triggers their registration.
-	
+
 	factory := DefaultFactory()
 	ctx := context.Background()
 	cfg := &config.Config{
@@ -39,15 +39,15 @@ func TestDefaultFactory_Build_Channel(t *testing.T) {
 	logger := testLogger()
 
 	transport, err := factory.Build(ctx, cfg, logger)
-	
+
 	// If the transport isn't registered (e.g., in minimal test environment),
 	// this will error. That's okay - we're testing the factory interface.
 	if err != nil {
 		// Expected in some test environments where transports aren't registered
 		t.Skipf("Transport not registered in test environment: %v", err)
 		return
 	}
-	
+
 	require.NoError(t, err)
 	assert.NotNil(t, transport.Publisher)
 	assert.NotNil(t, transport.Subscriber)