Skip to content

Commit 12be1f2

Browse files
grantfirlLarissaReamesdustinswalesSamuel Trahan
authored
Update calculation of time-averaged radiation variables (NOAA-EMC#941)
* Modify calculation of bucket average radiation variables to be accurate at sub-radiation-timestep output frequency. * Update bucket radiation scaling for rad_swlw_min variables * Bug fix in rad_lwsw_min scaling parameter. Merge GFS_rrtmg/rrtmgp_post.F90 in to GFS_radiation_post.F90 in ccpp/physics, requiring changes to all suites. * Add SW clear-sky downward flux at surface to available diagnostics * fix compilation error in GFS_diagnostics.F90 * update atmos_cubed_sphere to turn ENABLE_PARALLELRESTART OFF by default to avoid RT errors on some platforms (Hera, Hercules at least) * ccpp-physics - wet() bug fix and workaround for bad tsfco * update CCPP SDFs to replace GFS_rrtmg_post with GFS_radiation_post * change GFS_rrtmg_post in MPAS-based suite * fix MPAS-based ccpp_prebuild config that still referenced GFS_rrtmgX_post --------- Co-authored-by: Larissa Reames <larissa.reames@noaa.gov> Co-authored-by: Dustin Swales <dustin.swales@noaa.gov> Co-authored-by: Samuel Trahan <samuel,trahan@noaa.gov>
1 parent 67961c1 commit 12be1f2

56 files changed

Lines changed: 68 additions & 65 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

ccpp/config/ccpp_prebuild_config_fv3.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,15 +104,14 @@
104104
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_photochemistry.F90',
105105
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rad_time_vary.fv3.F90',
106106
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_radiation_surface.F90',
107-
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmg_post.F90',
107+
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_radiation_post.F90',
108108
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmg_pre.F90',
109109
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmg_setup.F90',
110110
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_setup.F90',
111111
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_pre.F90',
112112
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_cloud_diagnostics.F90',
113113
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_cloud_mp.F90',
114114
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_cloud_overlap.F90',
115-
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_post.F90',
116115
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_stochastics.F90',
117116
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_suite_interstitial_1.F90',
118117
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_suite_interstitial_2.F90',

ccpp/config/ccpp_prebuild_config_mpas.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,15 +97,14 @@
9797
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rad_time_vary.mpas.F90',
9898
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_time_vary_pre.fv3.F90',
9999
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_radiation_surface.F90',
100-
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmg_post.F90',
100+
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_radiation_post.F90',
101101
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmg_pre.F90',
102102
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmg_setup.F90',
103103
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_setup.F90',
104104
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_pre.F90',
105105
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_cloud_diagnostics.F90',
106106
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_cloud_mp.F90',
107107
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_cloud_overlap.F90',
108-
'physics/physics/Interstitials/UFS_SCM_NEPTUNE/GFS_rrtmgp_post.F90',
109108
'physics/physics/Radiation/RRTMG/radsw_main.F90',
110109
'physics/physics/Radiation/RRTMG/radlw_main.F90',
111110
'physics/physics/Radiation/RRTMG/rrtmg_lw_post.F90',

ccpp/suites/suite_FV3_GFS_v15_thompson_mynn_lam3km.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<scheme>rrtmg_lw</scheme>
2222
<scheme>sgscloud_radpost</scheme>
2323
<scheme>rrtmg_lw_post</scheme>
24-
<scheme>GFS_rrtmg_post</scheme>
24+
<scheme>GFS_radiation_post</scheme>
2525
</subcycle>
2626
</group>
2727
<group name="phys_ps">

ccpp/suites/suite_FV3_GFS_v15p2.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<scheme>rrtmg_sw_post</scheme>
2525
<scheme>rrtmg_lw</scheme>
2626
<scheme>rrtmg_lw_post</scheme>
27-
<scheme>GFS_rrtmg_post</scheme>
27+
<scheme>GFS_radiation_post</scheme>
2828
</subcycle>
2929
</group>
3030
<group name="phys_ps">

ccpp/suites/suite_FV3_GFS_v16.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<scheme>rrtmg_sw_post</scheme>
2525
<scheme>rrtmg_lw</scheme>
2626
<scheme>rrtmg_lw_post</scheme>
27-
<scheme>GFS_rrtmg_post</scheme>
27+
<scheme>GFS_radiation_post</scheme>
2828
</subcycle>
2929
</group>
3030
<group name="phys_ps">

ccpp/suites/suite_FV3_GFS_v16_csawmg.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<scheme>rrtmg_sw_post</scheme>
2020
<scheme>rrtmg_lw</scheme>
2121
<scheme>rrtmg_lw_post</scheme>
22-
<scheme>GFS_rrtmg_post</scheme>
22+
<scheme>GFS_radiation_post</scheme>
2323
</subcycle>
2424
</group>
2525
<group name="phys_ps">

ccpp/suites/suite_FV3_GFS_v16_flake.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<scheme>rrtmg_sw_post</scheme>
2525
<scheme>rrtmg_lw</scheme>
2626
<scheme>rrtmg_lw_post</scheme>
27-
<scheme>GFS_rrtmg_post</scheme>
27+
<scheme>GFS_radiation_post</scheme>
2828
</subcycle>
2929
</group>
3030
<group name="phys_ps">

ccpp/suites/suite_FV3_GFS_v16_fv3wam.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<scheme>rrtmg_sw_post</scheme>
2020
<scheme>rrtmg_lw</scheme>
2121
<scheme>rrtmg_lw_post</scheme>
22-
<scheme>GFS_rrtmg_post</scheme>
22+
<scheme>GFS_radiation_post</scheme>
2323
</subcycle>
2424
</group>
2525
<group name="phys_ps">

ccpp/suites/suite_FV3_GFS_v16_gfdlmpv3.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<scheme>rrtmg_sw_post</scheme>
2525
<scheme>rrtmg_lw</scheme>
2626
<scheme>rrtmg_lw_post</scheme>
27-
<scheme>GFS_rrtmg_post</scheme>
27+
<scheme>GFS_radiation_post</scheme>
2828
</subcycle>
2929
</group>
3030
<group name="phys_ps">

0 commit comments

Comments
 (0)