[Cherry-pick] DYN-10639: Revert DYN-8575 to fix pop-ups flashing then disappearing (#17179)

Co-authored-by: john pierson <john.pierson@autodesk.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: 3 people

src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs

@@ -1592,11 +1592,7 @@ private void HidePopupWhenWindowDeactivated(object obj)
         {
             var workspace = this.ChildOfType<WorkspaceView>();
             if (workspace != null)
-            {
                 workspace.HideAllPopUp(obj);
-                workspace.DestroyPortContextMenu();
-            }
-
         }
 
         private void TrackStartupAnalytics()

src/DynamoCoreWpf/Views/Core/WorkspaceView.xaml.cs

@@ -108,11 +108,6 @@ public WorkspaceView()
 
             InitializeComponent();
 
-            Loaded += WorkspaceView_Loaded;
-            Unloaded += WorkspaceView_Unloaded;
-
-            LostFocus += WorkspaceView_LostFocus;
-
             DataContextChanged += OnWorkspaceViewDataContextChanged;
 
             // view of items to drag
@@ -124,11 +119,6 @@ public WorkspaceView()
             dictionaries.Add(SharedDictionaryManager.DataTemplatesDictionary);
         }
 
-        private void WorkspaceView_LostFocus(object sender, RoutedEventArgs e)
-        {
-            DestroyPortContextMenu();
-        }
-
         void ViewModel_PropertyChanged(object sender, PropertyChangedEventArgs e)
         {
             switch (e.PropertyName)
@@ -914,47 +904,20 @@ private void OnCanvasMouseDown(object sender, MouseButtonEventArgs e)
             InCanvasSearchBar.IsOpen = false;
             if (GeoScalingPopup != null)
                 GeoScalingPopup.IsOpen = false;
-
-            if (PortContextMenu.IsOpen) DestroyPortContextMenu();
+            
+            if(PortContextMenu.IsOpen) DestroyPortContextMenu();
 
             if (!ViewModel.IsConnecting && !ViewModel.IsPanning && e.MiddleButton == MouseButtonState.Pressed)
             {
                 ViewModel.RequestTogglePanMode();
             }
         }
 
-        private void WorkspaceView_Loaded(object sender, RoutedEventArgs e)
-        {
-            var ownerWindow = Window.GetWindow(this);
-            if (ownerWindow != null)
-            {
-                ownerWindow.Deactivated += OwnerWindow_Deactivated;
-            }
-        }
-
-        private void WorkspaceView_Unloaded(object sender, RoutedEventArgs e)
-        {
-            var ownerWindow = Window.GetWindow(this);
-            if (ownerWindow != null)
-            {
-                ownerWindow.Deactivated -= OwnerWindow_Deactivated;
-            }
-        }
-
-        /// <summary>
-        /// When the Dynamo/Revit window loses focus, close the port context menu
-        /// so it doesn't float above other windows.
-        /// </summary>
-        private void OwnerWindow_Deactivated(object sender, EventArgs e)
-        {
-            DestroyPortContextMenu();
-        }
-
         /// <summary>
         /// Closes the port's context menu and sets its references to null.
         /// </summary>
-        internal void DestroyPortContextMenu() => PortContextMenu.IsOpen = false;
-
+        private void DestroyPortContextMenu() => PortContextMenu.IsOpen = false;
+        
         private void OnMouseRelease(object sender, MouseButtonEventArgs e)
         {
             if (e == null) return; // in certain bizarre cases, e can be null
@@ -1296,10 +1259,6 @@ private void OnGeometryScaling_Click(object sender, RoutedEventArgs e)
         public void Dispose()
         {
             RemoveViewModelsubscriptions(ViewModel);
-
-            Loaded -= WorkspaceView_Loaded;
-            Unloaded -= WorkspaceView_Unloaded;
-            LostFocus -= WorkspaceView_LostFocus;
             DataContextChanged -= OnWorkspaceViewDataContextChanged;
         }
     }