Commit 287ef4c
fix(table): keep rows rendered when pageSizes prop changes at runtime
Pagination's mount effect persists the initial page size into Table's
internal pagination state. If a consumer later passes a different
pagination.pageSizes (e.g. derived from the viewport height), the stale
internal pageSize no longer matches any entry: the pageData memo's lookup
loop falls through to return null and the table renders its empty state
("No data found") with data still present, recovering only on remount.
Two-layer fix:
- usePagination: normalize a merged pageSize that is not contained in the
merged pageSizes to pageSizes[0], keeping the data slice, pager count,
and currentPage clamp consistent.
- Table pageData memo: replace the terminal return-null fallthrough with a
defensive slice using the first available size.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>1 parent f22fb38 commit 287ef4c
3 files changed
Lines changed: 39 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
83 | 92 | | |
84 | 93 | | |
85 | 94 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
579 | 579 | | |
580 | 580 | | |
581 | 581 | | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
582 | 590 | | |
583 | 591 | | |
584 | 592 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
80 | 102 | | |
81 | 103 | | |
82 | 104 | | |
| |||
0 commit comments