Skip to content

Commit 271edc6

Browse files
committed
refs #10612 remove unused code for security
1 parent 54a987d commit 271edc6

1 file changed

Lines changed: 3 additions & 12 deletions

File tree

pageant/src/wmmessage.rs

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -233,24 +233,15 @@ pub fn query_pageant_direct(cookie: String, msg: &[u8]) -> Result<Vec<u8>, Error
233233
let hwnd = find_pageant_window()?;
234234
let map_name = format!("PageantRequest{cookie}");
235235

236-
let user = get_current_process_user()?;
237-
238-
let mut sd = SECURITY_DESCRIPTOR::default();
239-
let psd = PSECURITY_DESCRIPTOR(&mut sd as *mut _ as *mut _);
240-
241-
unsafe {
242-
InitializeSecurityDescriptor(psd, 1)?;
243-
SetSecurityDescriptorOwner(psd, Some(user.User.Sid), false)?;
244-
}
245-
246236
let mut map: MemoryMap = MemoryMap::new(map_name.clone(), _AGENT_MAX_MSGLEN, None)?;
247237
map.write(msg)?;
248238

249239
let char_buffer = CString::new(map_name.as_bytes()).map_err(|_| Error::InvalidCookie)?;
240+
let char_buffer_bytes = char_buffer.as_bytes_with_nul();
250241
let cds = COPYDATASTRUCT {
251242
dwData: _AGENT_COPYDATA_ID as usize,
252-
cbData: char_buffer.as_bytes().len() as u32 + 1,
253-
lpData: char_buffer.as_bytes().as_ptr() as *mut _,
243+
cbData: char_buffer_bytes.len() as u32,
244+
lpData: char_buffer_bytes.as_ptr() as *mut _,
254245
};
255246

256247
let response = unsafe {

0 commit comments

Comments
 (0)