fix Tabby#10301 Still cannot login with pageant

two problems:
1. pageant protocol does not support streaming, so PageantStream should receive enough data for pageant, and then forward into.
2. [SECURITY_ATTRIBUTES] should have the correct nLength
3. [SetSecurityDescriptorOwner] in version 0.58 have bug, upgrade to 0.59 is ok.

Author: vzex

pageant/Cargo.toml

@@ -13,11 +13,12 @@ rust-version = "1.75"
 futures.workspace = true
 thiserror.workspace = true
 rand.workspace = true
+byteorder.workspace = true
 log.workspace = true
 tokio = { workspace = true, features = ["io-util", "rt"] }
 bytes.workspace = true
 delegate.workspace = true
-windows = { version = "0.58", features = [
+windows = { version = "0.59", features = [
     "Win32_UI_WindowsAndMessaging",
     "Win32_System_Memory",
     "Win32_Security",

pageant/src/pageant_impl.rs

@@ -1,3 +1,4 @@
+use byteorder::{BigEndian, ByteOrder};
 use std::io::IoSlice;
 use std::mem::size_of;
 use std::pin::Pin;
@@ -61,7 +62,14 @@ impl PageantStream {
                 if n == 0 {
                     break;
                 }
-                let msg = buf.split().freeze();
+                if buf.len() < 4 {
+                    continue;
+                }
+                let len = BigEndian::read_u32(&buf) as usize;
+                if buf.len() < len + 4 {
+                    continue;
+                }
+                let msg = buf.split_to(len + 4).freeze();
                 let Ok(response) = query_pageant_direct(cookie.clone(), &msg).map_err(|e| {
                     debug!("Pageant query failed: {:?}", e);
                     e
@@ -253,14 +261,14 @@ pub fn query_pageant_direct(cookie: String, msg: &[u8]) -> Result<Vec<u8>, Error
     let sa = SECURITY_ATTRIBUTES {
         lpSecurityDescriptor: &mut sd as *mut _ as *mut _,
         bInheritHandle: true.into(),
-        ..Default::default()
+        nLength: size_of::<SECURITY_ATTRIBUTES>() as u32,
     };
 
     let psd = PSECURITY_DESCRIPTOR(&mut sd as *mut _ as *mut _);
 
     unsafe {
         InitializeSecurityDescriptor(psd, 1)?;
-        SetSecurityDescriptorOwner(psd, user.User.Sid, false)?;
+        SetSecurityDescriptorOwner(psd, Some(user.User.Sid), false)?;
     }
 
     let mut map: MemoryMap = MemoryMap::new(map_name.clone(), _AGENT_MAX_MSGLEN, Some(sa))?;