ok

Author: Tchoupinax

example/generate.ts

@@ -1,13 +1,11 @@
 import { generate } from '../src'
 import path from 'path'
-import { inspect } from 'util'
-import fs from 'fs'
 
 generate({
   tsconfigFilePath: path.resolve(__dirname, './tsconfig.json'),
   controllers: [path.resolve(__dirname, './*.ts')],
   openapi: {
-    filePath: '/tmp/openapi.yaml',
+    filePath: '../tmp/openapi.yaml',
     service: {
       name: 'my-service',
       version: '1.0.0'
@@ -24,15 +22,4 @@ generate({
     filePath: './router.ts',
     securityMiddlewarePath: './security.ts'
   }
-})
-  .then(() =>
-    console.log(
-      inspect(
-        JSON.parse(fs.readFileSync('/tmp/openapi.yaml').toString()),
-        false,
-        100,
-        true
-      )
-    )
-  )
-  .catch(err => console.error('error', err))
+}).catch(err => console.error('error', err))

src/runtime/validator.ts

@@ -558,9 +558,7 @@ function validateAndParseValueAgainstSchema(
 
     if (
       (features?.enableThrowOnUnexpectedAdditionalData ||
-        features?.enableLogUnexpectedAdditionalData) &&
-      (currentSchema.additionalProperties === false ||
-        typeof currentSchema.additionalProperties === 'undefined')
+        features?.enableLogUnexpectedAdditionalData) && currentSchema.additionalProperties === false
     ) {
       if (additionalKeys.length > 0) {
         if (features.enableLogUnexpectedAdditionalData) {

tests/fixtures/controllers/controller.ts

@@ -56,8 +56,6 @@ type ValidationTestBody = {
   boolean: boolean
   tuple: [string, number]
   array: string[]
-  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
-  object: {}
   record: Record<string, string>
   mappedType: { [key: string]: number }
   objectWithProps: {

tests/integration/router-validation-additional-properties.test.ts

@@ -21,9 +21,7 @@ const validBody = {
   number: 1,
   numberEnum: 4,
   numberWithMinAndMax: 5,
-  object: { ignored: 1 },
   objectWithProps: { string: 'my-string' },
-  readonlyProp: 'my prop',
   record: { foo: '1' },
   string: 'my-string',
   stringEnum: 'foo',
@@ -93,17 +91,20 @@ after(async () => {
 
 describe('Additional properties', () => {
   test('Should reject if a given property does not exist in the schema', async () => {
+    const id = randomUUID()
     const res = await request(app)
       .post('/my-controller/')
       .set('x-custom-header', 'my-header')
-      .send({ ...validBody, [randomUUID()]: 'random' })
+      .send({ ...validBody, [id]: 'random' })
       .expect(400)
 
     assert.deepStrictEqual(res.body.fields, {
-      'body.object': {
-        message: 'Additional properties are not allowed. Found: ignored',
+      body: {
+        message: `Additional properties are not allowed. Found: ${id}`,
         value: {
-          ignored: 1
+          ...validBody,
+          [id]: 'random',
+          stringWithFormat: new Date(validBody.stringWithFormat).toISOString()
         }
       }
     })