Skip to content

Refreshing Reports causes InvalidFormatException for DECAPITATION victoryCondition #264

Description

@magge-faf

How to reproduce:

  1. Start Client
  2. Switch to report-tab
  3. Hit 'Refresh'
  4. At least one or more error boxes pop up seemingly randomly after a few seconds or minutes

TMK the related report/s causing above error, are not shown in Mordor.


client.log
stracktrace error.txt


Screenshot of error box Image

In my modified Mordor (MM), the AI suggested back then using a custom Jackson deserializer as a very quick fix to at least see the related reports again.

(Related commit in MM: magge-faf/faf-moderator-client-develop-modified@bb097a7 )


My research/thinking to fix it properly:

  1. Making sure the value DECAPITATION exists for victoryCondition in our related dependency faf-java-commons - It was already committed ~2 months ago.

  2. Which means, it traces back to the used version of the dependency in Mordor. Currently, we have the following:

def commonsVersion = "9972c3d"
implementation("com.github.FAForever.faf-java-commons:data:${commonsVersion}")
implementation("com.github.FAForever.faf-java-commons:api:${commonsVersion}")

9972c3d is an older commit - On jitpack it is the latest working one I have found, tho.

I tried to initiate a new Jitpack release, but it failed:

https://jitpack.io/com/github/FAForever/faf-java-commons/597cae49015eb3c2698bd953a971ed2470b45a07/build.log

It is related to some maven related error:

* What went wrong:
Execution failed for task ':api:publishMavenPublicationToMavenLocal'.
> Failed to publish publication 'maven' to repository 'mavenLocal'
   > Invalid publication 'maven': artifact file does not exist: '/home/jitpack/build/api/build/publications/maven/pom-default.xml.asc'

At this point, I have hit a wall. The AI suggests that if I am unable to create the signing file for the related dependency, or disable signing completely, then I should ask the dependency maintainer to provide the signing file.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions