refactor: Improve code readability and fix minor issues in HoldingsCsvTransformer

Author: mtrineyev

src/folio_migration_tools/migration_tasks/holdings_csv_transformer.py

@@ -166,7 +166,8 @@ class TaskConfiguration(AbstractTaskConfiguration):
                 title="Statistical code map file name",
                 description=(
                     "Path to the file containing the mapping of statistical codes. "
-                    "The file should be in TSV format with legacy_stat_code and folio_code columns."
+                    "The file should be in TSV format with legacy_stat_code and "
+                    "folio_code columns."
                 ),
             ),
         ] = ""
@@ -182,6 +183,7 @@ def __init__(
         folio_client,
         use_logging: bool = True,
     ):
+        self.task_configuration = task_config
         super().__init__(library_config, task_config, folio_client, use_logging)
         self.fallback_holdings_type = None
         self.folio_keys, self.holdings_field_map = self.load_mapped_fields()
@@ -214,7 +216,7 @@ def __init__(
                 self.folio_client.folio_get_all("/holdings-types", "holdingsTypes")
             )
             logging.info("%s\tholdings types in tenant", len(self.holdings_types))
-            self.validate_merge_criterias()
+            self.validate_merge_criteria()
             self.check_source_files(
                 self.folder_structure.data_folder / "items", self.task_configuration.files
             )
@@ -282,28 +284,31 @@ def load_call_number_type_map(self):
             self.folder_structure.mapping_files_folder
             / self.task_configuration.call_number_type_map_file_name,
             "r",
-        ) as callnumber_type_map_f:
+        ) as call_number_type_map_f:
             return self.load_ref_data_map_from_file(
-                callnumber_type_map_f, "Found %s rows in call number type map"
+                call_number_type_map_f, "Found %s rows in call number type map"
             )
 
     def load_location_map(self):
         with open(
-            self.folder_structure.mapping_files_folder / self.task_configuration.location_map_file_name
+            self.folder_structure.mapping_files_folder /
+            self.task_configuration.location_map_file_name
         ) as location_map_f:
             return self.load_ref_data_map_from_file(
                 location_map_f, "Found %s rows in location map"
             )
 
     # TODO Rename this here and in `load_call_number_type_map` and `load_location_map`
-    def load_ref_data_map_from_file(self, file, message):
+    @staticmethod
+    def load_ref_data_map_from_file(file, message):
         ref_dat_map = list(csv.DictReader(file, dialect="tsv"))
         logging.info(message, len(ref_dat_map))
         return ref_dat_map
 
     def load_mapped_fields(self):
         with open(
-            self.folder_structure.mapping_files_folder / self.task_configuration.holdings_map_file_name
+            self.folder_structure.mapping_files_folder
+            / self.task_configuration.holdings_map_file_name
         ) as holdings_mapper_f:
             holdings_map = json.load(holdings_mapper_f)
             logging.info("%s fields in holdings mapping file map", len(holdings_map["data"]))
@@ -331,7 +336,8 @@ def do_work(self):
                 print(f"\n{error_str}\nHalting")
                 sys.exit(1)
         logging.info(
-            f"processed {self.total_records:,} records in {len(self.task_configuration.files)} files"
+            f"processed {self.total_records:,} records in "
+            f"{len(self.task_configuration.files)} files"
         )
 
     def wrap_up(self):
@@ -373,16 +379,18 @@ def wrap_up(self):
         logging.info("All done!")
         self.clean_out_empty_logs()
 
-    def validate_merge_criterias(self):
+    def validate_merge_criteria(self):
         holdings_schema = self.folio_client.get_holdings_schema()
         properties = holdings_schema["properties"].keys()
         logging.info(properties)
         logging.info(self.task_configuration.holdings_merge_criteria)
-        res = [mc for mc in self.task_configuration.holdings_merge_criteria if mc not in properties]
+        res = [
+            mc for mc in self.task_configuration.holdings_merge_criteria if mc not in properties
+        ]
         if any(res):
             logging.critical(
                 (
-                    "Merge criteria(s) is not a property of a holdingsrecord: %s"
+                    "Merge criteria is not a property of a holdings record: %s"
                     "check the merge criteria names and try again"
                 ),
                 ", ".join(res),
@@ -409,8 +417,8 @@ def process_single_file(self, file_def: FileDefinition):
                     self.mapper.handle_transformation_process_error(idx, process_error)
                 except TransformationRecordFailedError as error:
                     self.mapper.handle_transformation_record_failed_error(idx, error)
-                except Exception as excepion:
-                    self.mapper.handle_generic_exception(idx, excepion)
+                except Exception as e:
+                    self.mapper.handle_generic_exception(idx, e)
                 self.mapper.migration_report.add_general_statistics(
                     i18n.t("Number of Legacy items in file")
                 )
@@ -461,14 +469,14 @@ def create_bound_with_holdings(self, folio_holding, legacy_id: str):
     def merge_holding_in(
         self, incoming_holding: dict, instance_ids: list[str], legacy_item_id: str
     ) -> None:
-        """Determines what newly generated holdingsrecords are to be merged with
+        """Determines what newly generated holdings records are to be merged with
         previously created ones. When that is done, it generates the correct boundwith
         parts needed.
 
         Args:
             incoming_holding (dict): The newly created FOLIO Holding
             instance_ids (list): the instance IDs tied to the current item
-            legacy_item_id (str): Id of the Item the holding was generated from
+            legacy_item_id (str): ID of the Item the holding was generated from
         """
         if len(instance_ids) > 1:
             # Is boundwith
@@ -495,7 +503,7 @@ def merge_holding_in(
                     i18n.t("BW Items found tied to previously created BW Holdings")
                 )
         else:
-            # Regular holding. Merge according to criteria
+            # Regular holding. Merge, according to criteria
             new_holding_key = HoldingsHelper.to_key(
                 incoming_holding,
                 self.task_configuration.holdings_merge_criteria,