Refactor logging to use logger.exception for better error tracking and fix some typing errors

- Updated multiple instances across various modules to replace logger.error with logger.exception to capture stack traces and provide more context for errors.
- Ensured that all relevant error messages are logged with exception details to facilitate debugging and monitoring.
- Fix some failed type checks

Author: bltravis

src/folio_migration_tools/circulation_helper.py

@@ -67,7 +67,7 @@ def get_user_by_barcode(self, user_barcode):
             self.missing_patron_barcodes.add(user_barcode)
             return {}
         except Exception as ee:
-            logger.error(f"{ee} {user_path}")
+            logger.exception(f"{ee} {user_path}")
             return {}
 
     def get_item_by_barcode(self, item_barcode):
@@ -85,7 +85,7 @@ def get_item_by_barcode(self, item_barcode):
             self.missing_item_barcodes.add(item_barcode)
             return {}
         except Exception as ee:
-            logger.error(f"{ee} {item_path}")
+            logger.exception(f"{ee} {item_path}")
             return {}
 
     def is_checked_out(self, legacy_loan: LegacyLoan) -> bool:
@@ -119,15 +119,15 @@ def get_active_loan_by_item_id(self, item_id: str) -> dict:
             loans = self.folio_client.folio_get(loan_path, "loans")
             return next((loan for loan in loans if loan["status"]["name"] == "Open"), {})
         except Exception as ee:
-            logger.error(f"{ee} {loan_path}")
+            logger.exception(f"{ee} {loan_path}")
             return {}
 
     def get_holding_by_uuid(self, holdings_uuid):
         holdings_path = f"/holdings-storage/holdings/{holdings_uuid}"
         try:
             return self.folio_client.folio_get_single_object(holdings_path)
         except Exception as ee:
-            logger.error(f"{ee} {holdings_path}")
+            logger.exception(f"{ee} {holdings_path}")
             return {}
 
     def check_out_by_barcode(self, legacy_loan: LegacyLoan) -> TransactionResult:
@@ -297,7 +297,7 @@ def create_request(
             return True
         except FolioValidationError as fve:
             message = folio_client.handle_json_response(fve.response)["errors"][0]["message"]
-            logger.error(message)
+            logger.exception(message)
             migration_report.add_general_statistics(message)
             return False
         except (FolioConnectionError, FolioClientError) as fce:
@@ -306,14 +306,14 @@ def create_request(
                     f"HTTP {client_response.status_code} Error creating request: "
                     f"{client_response.text}"
                 )
-                logger.error(message)
+                logger.exception(message)
                 migration_report.add_general_statistics(message)
             else:
-                logger.error(f"Connection error creating request: {fce}")
+                logger.exception(f"Connection error creating request: {fce}")
                 migration_report.add_general_statistics("Connection error creating request")
             return False
         except Exception as exception:
-            logger.error(exception, exc_info=True)
+            logger.exception(exception, exc_info=True)
             migration_report.add("Details", exception)
             Helper.log_data_issue(
                 legacy_request.item_barcode,

src/folio_migration_tools/extradata_writer.py

@@ -50,7 +50,7 @@ def write(self, record_type: str, data_to_write: dict, flush=False):
                     logger.debug("Extradata writer flushing the cache")
         except Exception as ee:
             error_message = "Something went wrong in extradata Writer"
-            logger.error(error_message)
+            logger.exception(error_message)
             raise TransformationProcessError("", error_message, record_type) from ee
 
     def flush(self):

src/folio_migration_tools/holdings_helper.py

@@ -67,7 +67,7 @@ def to_key(
                 )
             return "-".join(values)
         except Exception as exception:
-            logger.error(json.dumps(holdings_record, indent=4))
+            logger.exception(json.dumps(holdings_record, indent=4))
             raise exception from exception
 
     @staticmethod

src/folio_migration_tools/mapper_base.py

@@ -97,7 +97,7 @@ def report_folio_mapping(self, folio_record, schema):
                 if prop not in self.mapped_folio_fields:
                     self.mapped_folio_fields[prop] = [0]
         except Exception as ee:
-            logger.error(ee, stack_info=True)
+            logger.exception(ee, stack_info=True)
             raise ee from ee
 
     def report_legacy_mapping_no_schema(self, legacy_object):
@@ -281,7 +281,7 @@ def handle_transformation_record_failed_error(
                 ),
                 self.num_criticalerrors,
             )
-            logger.error(
+            logger.exception(
                 "Errors: %s\terrors/records: %s",
                 self.num_criticalerrors,
                 (self.num_criticalerrors / (records_processed + 1)),
@@ -306,7 +306,7 @@ def handle_generic_exception(self, idx, exception: Exception):
             f"Row {idx:,} failed with the following unhandled Exception: {exception}  "
             f"of type {type(exception).__name__}"
         )
-        logger.error(exception, exc_info=True)
+        logger.exception(exception, exc_info=True)
         if self.num_exceptions > self.library_configuration.generic_exception_threshold:
             logging.fatal(
                 "Stopping. More than %s unhandled exceptions. Code needs fixing",

src/folio_migration_tools/mapping_file_transformation/mapping_file_mapper_base.py

@@ -363,7 +363,7 @@ def map_property(
                     logger.info("Edge case %s", schema_property_name)
 
             except KeyError as schema_anomaly:
-                logger.error(
+                logger.exception(
                     "Cannot create property '%s'. Unsupported schema format: %s",
                     schema_property_name,
                     schema_anomaly,
@@ -752,7 +752,7 @@ def get_objects(self, source_file, file_name: Path):
         try:
             yield from reader
         except Exception as exception:
-            logger.error("%s at row %s", exception, reader.line_num)
+            logger.exception("%s at row %s", exception, reader.line_num)
             raise exception from exception
 
     def has_property(self, legacy_object, folio_prop_name: str):

src/folio_migration_tools/mapping_file_transformation/order_mapper.py

@@ -400,7 +400,7 @@ def build_extended_object(object_schema, submodule_path, github_headers):
             return object_schema
 
         except HTTPError as he:
-            logger.error(he)
+            logger.exception(he)
 
     @staticmethod
     def inject_schema_by_ref(submodule_path, github_headers, property: dict):
@@ -419,7 +419,7 @@ def inject_schema_by_ref(submodule_path, github_headers, property: dict):
             req.raise_for_status()
             return dict(property, **json.loads(req.text))
         except Exception as ee:
-            logger.error(ee)
+            logger.exception(ee)
             return {}
 
     @staticmethod
@@ -433,7 +433,7 @@ def inject_items_schema_by_ref(submodule_path, github_headers, property: dict):
             req.raise_for_status()
             return dict(property["items"], **json.loads(req.text))
         except Exception as ee:
-            logger.error(ee)
+            logger.exception(ee)
             return {}
 
     def perform_additional_mapping(self, index_or_id, composite_order):

src/folio_migration_tools/mapping_file_transformation/organization_mapper.py

@@ -422,7 +422,7 @@ def build_extended_object(object_schema, submodule_path, github_headers, release
             return object_schema
 
         except httpx.HTTPError as he:
-            logger.error(he)
+            logger.exception(he)
 
     @staticmethod
     def resolve_uuid_refs(schema):

src/folio_migration_tools/mapping_file_transformation/ref_data_mapping.py

@@ -101,7 +101,7 @@ def setup_mappings(self):
                 raise transformation_process_error from transformation_process_error
             except Exception as ee:
                 logger.info(json.dumps(self.map, indent=4))
-                logger.error(ee)
+                logger.exception(ee)
                 raise TransformationProcessError(
                     "",
                     f'"{mapping[f"folio_{self.key_type}"]}" could not be found in FOLIO',

src/folio_migration_tools/mapping_file_transformation/user_mapper.py

@@ -217,7 +217,7 @@ def get_parsed_date(self, mapped_value, folio_prop_name: str):
             return format_date.isoformat()
         except Exception as ee:
             v = mapped_value
-            logger.error(f"{folio_prop_name} {v} could not be parsed: {ee}")
+            logger.exception(f"{folio_prop_name} {v} could not be parsed: {ee}")
             fmt_string = i18n.t(
                 "Parsing error! %{prop_name}: %{value}. The empty string was returned",
                 prop_name=folio_prop_name,

src/folio_migration_tools/marc_rules_transformation/conditions.py

@@ -429,7 +429,7 @@ def condition_set_holdings_note_type_id(
             self.mapper.migration_report.add("MappedNoteTypes", t[1])
             return t[0]
         except Exception as ee:
-            logger.error(ee)
+            logger.exception(ee)
             raise TransformationRecordFailedError(
                 legacy_id,
                 f"Holdings note type mapping error.\tParameter: {parameter.get('name', '')}\t"