Make type checker happier

Author: bltravis

src/folio_migration_tools/marc_rules_transformation/conditions.py

@@ -386,7 +386,7 @@ def condition_set_identifier_type_id_by_value(
                 "MappedIdentifierTypes", f"{marc_field.tag} -> {t[1]}"
             )
             return t[0]
-        identifier_type: dict = next(
+        identifier_type: dict | None = next(
             (
                 f
                 for f in self.folio.identifier_types  # type: ignore
@@ -397,6 +397,12 @@ def condition_set_identifier_type_id_by_value(
             ),
             None,
         )
+        if identifier_type is None:
+            raise TransformationFieldMappingError(
+                legacy_id,
+                i18n.t("no matching identifier_types in %{names}", names=parameter["names"]),
+                marc_field,
+            )
         self.mapper.migration_report.add("MappedIdentifierTypes", identifier_type["name"])
         my_id = identifier_type["id"]
         if not my_id:

src/folio_migration_tools/marc_rules_transformation/rules_mapper_bibs.py

@@ -287,7 +287,7 @@ def handle_holdings(self, marc_record: Record):
     def wrap_up(self):
         logger.info("Mapper wrapping up")
         if self.create_source_records:
-            if self.task_configuration.update_hrid_settings:
+            if getattr(self.task_configuration, "update_hrid_settings", False):
                 self.hrid_handler.store_hrid_settings()
 
     def get_instance_type_id(self, marc_record: Record, legacy_ids: List[str]) -> str: