Fix path normalization for array object nested objects

Author: bltravis

src/folio_migration_tools/mapping_file_transformation/mapping_file_mapper_base.py

@@ -561,6 +561,12 @@ def map_object_props(
         index_or_id,
         level: int,
     ):
+        def _normalize_local_object_path(path: str) -> str:
+            # When mapping nested object fields under an array item (for example,
+            # "poLines[0].cost.currency") into a temporary item object, keep only
+            # the local path segment ("cost.currency").
+            return path.split("].", 1)[1] if "]." in path else path
+
         temp_object: dict = {}
         for child_property_name, child_property in schema_property["properties"].items():
             sub_prop_path = f"{schema_property_name}.{child_property_name}"
@@ -607,12 +613,12 @@ def map_object_props(
                 if p := self.get_prop(
                     legacy_object, sub_prop_path, index_or_id, child_property.get("default", "")
                 ):
-                    set_at_path(folio_object, sub_prop_path, p)
+                    set_at_path(folio_object, _normalize_local_object_path(sub_prop_path), p)
                 # temp_object[child_property_name] = p
             elif p := self.get_prop(
                 legacy_object, sub_prop_path, index_or_id, child_property.get("default", "")
             ):
-                set_at_path(folio_object, sub_prop_path, p)
+                set_at_path(folio_object, _normalize_local_object_path(sub_prop_path), p)
         if temp_object:
             set_deep(folio_object, schema_property_name, temp_object)
             # folio_object[schema_property_name] = temp_object

tests/test_mapping_file_mapper_base.py

@@ -6343,3 +6343,62 @@ def test_field_mapping_errors_report_is_json_serializable(mocked_file_mapper):
     assert "FieldMappingErrors" in payload
     assert isinstance(payload["FieldMappingErrors"], dict)
     assert payload["FieldMappingErrors"]["Required properties missing in poLines item\torderFormat,source"] == 1
+
+
+def test_nested_object_fields_under_array_item_are_local_to_item(
+    mocked_folio_client, mocked_file_mapper
+):
+    schema = {
+        "$schema": "http://json-schema.org/draft-04/schema#",
+        "type": "object",
+        "properties": {
+            "id": {"type": "string"},
+            "lines": {
+                "type": "array",
+                "items": {
+                    "type": "object",
+                    "properties": {
+                        "title": {"type": "string"},
+                        "source": {"type": "string"},
+                        "cost": {
+                            "type": "object",
+                            "properties": {
+                                "currency": {"type": "string"},
+                                "listUnitPrice": {"type": "number"},
+                            },
+                        },
+                    },
+                    "required": ["title", "source"],
+                },
+            },
+        },
+        "required": [],
+    }
+    record = {
+        "id": "rec-1",
+        "line_title": "Example title",
+        "line_source": "API",
+    }
+    the_map = {
+        "data": [
+            {"folio_field": "legacyIdentifier", "legacy_field": "id", "value": "", "description": ""},
+            {"folio_field": "lines[0].title", "legacy_field": "line_title", "value": "", "description": ""},
+            {"folio_field": "lines[0].source", "legacy_field": "line_source", "value": "", "description": ""},
+            {"folio_field": "lines[0].cost.currency", "legacy_field": "", "value": "USD", "description": ""},
+            {"folio_field": "lines[0].cost.listUnitPrice", "legacy_field": "", "value": 10.5, "description": ""},
+        ]
+    }
+    mapper = MappingFileMapperBase(
+        mocked_folio_client,
+        schema,
+        the_map,
+        None,
+        FOLIONamespaces.orders,
+        mocked_classes.get_mocked_library_config(),
+        mocked_file_mapper.task_configuration,
+    )
+
+    folio_rec, _ = mapper.do_map(record, record["id"], FOLIONamespaces.orders)
+
+    assert folio_rec["lines"][0]["cost"]["currency"] == "USD"
+    assert folio_rec["lines"][0]["cost"]["listUnitPrice"] == 10.5